2009-05-15 19:40:43

by Mario Limonciello

[permalink] [raw]
Subject: [PATCH 2/3] Add support for switching from HCI->HID mode for Dell BT adapters.

This allows Dell BT adapters to be able to be switched back to HID mode
(if users desire to do so).

---
tools/hid2hci.c | 11 ++++++++++-
1 files changed, 10 insertions(+), 1 deletions(-)

Attaching patch to prevent Exchange mangling.
--
Mario Limonciello
*Dell | Linux Engineering*
[email protected]

Attachments:
0001-Add-support-for-switching-from-HCI-HID-mode-for-Del.patch (872.00 B)
 signature.asc (260.00 B)
OpenPGP digital signature Download all attachments

2009-05-16 13:36:21

by Marcel Holtmann

[permalink] [raw]
Subject: Re: [PATCH 2/3] Add support for switching from HCI->HID mode for Dell BT adapters.

Hi Mario,

> > did you ever tested this patch with --enable-debug compilation? No code
> > before variable declaration. Please fix that.
> >
> >
> No, I didn't realize I was supposed to test with --enable-debug. I've
> done so now and fixed up this patch. See attached.

patch has been applied. Thanks.

Regards

Marcel



2009-05-15 22:07:52

by Mario Limonciello

[permalink] [raw]
Subject: Re: [PATCH 2/3] Add support for switching from HCI->HID mode for Dell BT adapters.

Hi Marcel:

Marcel Holtmann wrote:
> Hi Mario,
>
> did you ever tested this patch with --enable-debug compilation? No code
> before variable declaration. Please fix that.
>
> Regards
>
> Marcel
>
No, I didn't realize I was supposed to test with --enable-debug. I've
done so now and fixed up this patch. See attached.

Regards
--
Mario Limonciello
*Dell | Linux Engineering*
[email protected]

Attachments:
0002-Add-support-for-switching-from-HCI-HID-mode-for-Del.patch (1.05 kB)
 signature.asc (260.00 B)
OpenPGP digital signature Download all attachments

2009-05-15 20:06:25

by Marcel Holtmann

[permalink] [raw]
Subject: Re: [PATCH 2/3] Add support for switching from HCI->HID mode for Dell BT adapters.

Hi Mario,

> This allows Dell BT adapters to be able to be switched back to HID mode
> (if users desire to do so).
>
> ---
> tools/hid2hci.c | 11 ++++++++++-
> 1 files changed, 10 insertions(+), 1 deletions(-)
>
> Attaching patch to prevent Exchange mangling.

did you ever tested this patch with --enable-debug compilation? No code
before variable declaration. Please fix that.

Regards

Marcel