2010-07-26 06:02:37

by Suraj Sumangala

Subject: [RFC] Bluetooth: Provide access to reassembled Rx packets

Provide the HCI transport driver access to reassembled Rx packets before
sending to Host.

Signed-off-by: Suraj Sumangala <[email protected]>
---
include/net/bluetooth/hci_core.h | 1 +
net/bluetooth/hci_core.c | 4 ++++
2 files changed, 5 insertions(+), 0 deletions(-)

diff --git a/include/net/bluetooth/hci_core.h b/include/net/bluetooth/hci_core.h
index 350b3e6..769530b 100644
--- a/include/net/bluetooth/hci_core.h
+++ b/include/net/bluetooth/hci_core.h
@@ -156,6 +156,7 @@ struct hci_dev {
int (*close)(struct hci_dev *hdev);
int (*flush)(struct hci_dev *hdev);
int (*send)(struct sk_buff *skb);
+ int (*recv)(struct hci_dev *hdev, struct sk_buff *skb);
void (*destruct)(struct hci_dev *hdev);
void (*notify)(struct hci_dev *hdev, unsigned int evt);
int (*ioctl)(struct hci_dev *hdev, unsigned int cmd, unsigned long arg);
diff --git a/net/bluetooth/hci_core.c b/net/bluetooth/hci_core.c
index 995c9f9..8d74f9d 100644
--- a/net/bluetooth/hci_core.c
+++ b/net/bluetooth/hci_core.c
@@ -1132,6 +1132,10 @@ static int hci_reassembly(struct hci_dev *hdev, int type, void *data,
/* Complete frame */

bt_cb(skb)->pkt_type = type;
+
+ if (hdev->recv)
+ hdev->recv(hdev, skb);
+
hci_recv_frame(skb);

hdev->reassembly[index] = NULL;
--
1.7.0.4

2010-07-26 06:27:36

by Suraj Sumangala

Subject: Re: [RFC] Bluetooth: Provide access to reassembled Rx packets

Hi Marcel,

On 7/26/2010 11:43 AM, Marcel Holtmann wrote:
> Hi Suraj,
>
>> Provide the HCI transport driver access to reassembled Rx packets before
>> sending to Host.
>>
>> Signed-off-by: Suraj Sumangala<[email protected]>
>> ---
>> include/net/bluetooth/hci_core.h | 1 +
>> net/bluetooth/hci_core.c | 4 ++++
>> 2 files changed, 5 insertions(+), 0 deletions(-)
>>
>> diff --git a/include/net/bluetooth/hci_core.h b/include/net/bluetooth/hci_core.h
>> index 350b3e6..769530b 100644
>> --- a/include/net/bluetooth/hci_core.h
>> +++ b/include/net/bluetooth/hci_core.h
>> @@ -156,6 +156,7 @@ struct hci_dev {
>> int (*close)(struct hci_dev *hdev);
>> int (*flush)(struct hci_dev *hdev);
>> int (*send)(struct sk_buff *skb);
>> + int (*recv)(struct hci_dev *hdev, struct sk_buff *skb);
>
> besides the fact that skb->dev == hdev, why would be doing something
> like this? This is highly inefficient.
The idea was to provide the driver access the hci_dev structure.
Yes, as long as we have "skb->dev == hdev", called should be able to
extract it from the skbuff.
>
> Regards
>
> Marcel
>

Regards
Suraj

2010-07-26 06:13:08

by Marcel Holtmann

Subject: Re: [RFC] Bluetooth: Provide access to reassembled Rx packets

Hi Suraj,

> Provide the HCI transport driver access to reassembled Rx packets before
> sending to Host.
>
> Signed-off-by: Suraj Sumangala <[email protected]>
> ---
> include/net/bluetooth/hci_core.h | 1 +
> net/bluetooth/hci_core.c | 4 ++++
> 2 files changed, 5 insertions(+), 0 deletions(-)
>
> diff --git a/include/net/bluetooth/hci_core.h b/include/net/bluetooth/hci_core.h
> index 350b3e6..769530b 100644
> --- a/include/net/bluetooth/hci_core.h
> +++ b/include/net/bluetooth/hci_core.h
> @@ -156,6 +156,7 @@ struct hci_dev {
> int (*close)(struct hci_dev *hdev);
> int (*flush)(struct hci_dev *hdev);
> int (*send)(struct sk_buff *skb);
> + int (*recv)(struct hci_dev *hdev, struct sk_buff *skb);

besides the fact that skb->dev == hdev, why would be doing something
like this? This is highly inefficient.

Regards

Marcel