2011-11-16 12:58:23

by Mikel Astiz

Subject: [PATCH 1/3] media: release transport locks on acquisition failure

---
audio/transport.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/audio/transport.c b/audio/transport.c
index 2739199..7bde32d 100644
--- a/audio/transport.c
+++ b/audio/transport.c
@@ -670,6 +670,7 @@ static DBusMessage *acquire(DBusConnection *conn,
DBusMessage *msg,
owner = media_owner_create(conn, msg, accesstype);
id = transport->resume(transport, owner);
if (id == 0) {
+ media_transport_release(transport, accesstype);
media_owner_free(owner);
return btd_error_not_authorized(msg);
}
--
1.7.6.4

2011-11-16 13:28:47

by Luiz Augusto von Dentz

Subject: Re: [PATCH 1/3] media: release transport locks on acquisition failure

Hi Mikel,

On Wed, Nov 16, 2011 at 2:58 PM, Mikel Astiz <[email protected]> wrote:
> ---
> ?audio/transport.c | ? ?1 +
> ?1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/audio/transport.c b/audio/transport.c
> index 2739199..7bde32d 100644
> --- a/audio/transport.c
> +++ b/audio/transport.c
> @@ -670,6 +670,7 @@ static DBusMessage *acquire(DBusConnection *conn,
> DBusMessage *msg,
> ? ? ? ?owner = media_owner_create(conn, msg, accesstype);
> ? ? ? ?id = transport->resume(transport, owner);
> ? ? ? ?if (id == 0) {
> + ? ? ? ? ? ? ? media_transport_release(transport, accesstype);
> ? ? ? ? ? ? ? ?media_owner_free(owner);
> ? ? ? ? ? ? ? ?return btd_error_not_authorized(msg);
> ? ? ? ?}
> --
> 1.7.6.4

Ack.

--
Luiz Augusto von Dentz