2023-03-16 09:54:03

by Yun-hao Chung

Subject: [PATCH v2] Bluetooth: mgmt: Fix MGMT add advmon with RSSI command

The MGMT command: MGMT_OP_ADD_ADV_PATTERNS_MONITOR_RSSI uses variable
length argumenent. This patch adds right the field.

Reviewed-by: Archie Pusaka <[email protected]>
Fixes: b338d91703fa ("Bluetooth: Implement support for Mesh")
Signed-off-by: Howard Chung <[email protected]>
---
Hi upstream maintainers,
Host is not able to register advmon with rssi due to the bug.
This patch has been locally tested by adding monitor with rssi via
btmgmt on a kernel 6.1 machine.
Thanks

Changes in v2:
- Fixed git user name
- Included commit notes for the test step.

net/bluetooth/mgmt.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/net/bluetooth/mgmt.c b/net/bluetooth/mgmt.c
index 39589f864ea7..249dc6777fb4 100644
--- a/net/bluetooth/mgmt.c
+++ b/net/bluetooth/mgmt.c
@@ -9357,7 +9357,8 @@ static const struct hci_mgmt_handler mgmt_handlers[] = {
{ add_ext_adv_data, MGMT_ADD_EXT_ADV_DATA_SIZE,
HCI_MGMT_VAR_LEN },
{ add_adv_patterns_monitor_rssi,
- MGMT_ADD_ADV_PATTERNS_MONITOR_RSSI_SIZE },
+ MGMT_ADD_ADV_PATTERNS_MONITOR_RSSI_SIZE,
+ HCI_MGMT_VAR_LEN },
{ set_mesh, MGMT_SET_MESH_RECEIVER_SIZE,
HCI_MGMT_VAR_LEN },
{ mesh_features, MGMT_MESH_READ_FEATURES_SIZE },
--
2.40.0.rc2.332.ga46443480c-goog

2023-03-16 10:03:04

by Paul Menzel

Subject: Re: [PATCH v2] Bluetooth: mgmt: Fix MGMT add advmon with RSSI command

Dear Yun-hao,


Am 16.03.23 um 10:53 schrieb Howard Chung:
> The MGMT command: MGMT_OP_ADD_ADV_PATTERNS_MONITOR_RSSI uses variable
> length argumenent. This patch adds right the field.

There is still the typo in argument.

> Reviewed-by: Archie Pusaka <[email protected]>
> Fixes: b338d91703fa ("Bluetooth: Implement support for Mesh")
> Signed-off-by: Howard Chung <[email protected]>
> ---
> Hi upstream maintainers,
> Host is not able to register advmon with rssi due to the bug.
> This patch has been locally tested by adding monitor with rssi via
> btmgmt on a kernel 6.1 machine.

I would add that information to the commit message.

[…]


Kind regards,

Paul

2023-03-16 10:34:41

by bluez.test.bot

Subject: RE: [v2] Bluetooth: mgmt: Fix MGMT add advmon with RSSI command

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=730700

---Test result---

Test Summary:
CheckPatch PASS 0.74 seconds
GitLint PASS 0.36 seconds
SubjectPrefix PASS 0.13 seconds
BuildKernel PASS 32.75 seconds
CheckAllWarning PASS 35.33 seconds
CheckSparse PASS 40.09 seconds
CheckSmatch PASS 108.18 seconds
BuildKernel32 PASS 31.15 seconds
TestRunnerSetup PASS 451.98 seconds
TestRunner_l2cap-tester PASS 17.22 seconds
TestRunner_iso-tester PASS 17.74 seconds
TestRunner_bnep-tester PASS 5.73 seconds
TestRunner_mgmt-tester PASS 113.90 seconds
TestRunner_rfcomm-tester PASS 9.10 seconds
TestRunner_sco-tester PASS 8.43 seconds
TestRunner_ioctl-tester PASS 9.85 seconds
TestRunner_mesh-tester PASS 7.24 seconds
TestRunner_smp-tester PASS 8.34 seconds
TestRunner_userchan-tester PASS 6.09 seconds
IncrementalBuild PASS 29.70 seconds



---
Regards,
Linux Bluetooth