2020-06-26 20:53:56

by Alain Michaud

Subject: [BlueZ PATCH v1] profiles/scanparam: use configured scanparams when available

This patch updates the scan parameter service to use the configured scan
parameters when available rather than the hardcoded kernel defaults.

---

profiles/scanparam/scan.c | 14 ++++++++++----
1 file changed, 10 insertions(+), 4 deletions(-)

diff --git a/profiles/scanparam/scan.c b/profiles/scanparam/scan.c
index 9e8f57747..fd22b876b 100644
--- a/profiles/scanparam/scan.c
+++ b/profiles/scanparam/scan.c
@@ -45,12 +45,11 @@
#include "src/shared/gatt-db.h"
#include "src/shared/gatt-client.h"
#include "attrib/att.h"
+#include "src/hcid.h"

#define SCAN_INTERVAL_WIN_UUID 0x2A4F
#define SCAN_REFRESH_UUID 0x2A31

-#define SCAN_INTERVAL 0x0060
-#define SCAN_WINDOW 0x0030
#define SERVER_REQUIRES_REFRESH 0x00

struct scan {
@@ -75,8 +74,15 @@ static void write_scan_params(struct scan *scan)
{
uint8_t value[4];

- put_le16(SCAN_INTERVAL, &value[0]);
- put_le16(SCAN_WINDOW, &value[2]);
+ /* Unless scan parameters are configured, use the known kernel default
+ * parameters */
+ put_le16(main_opts.default_params.le_scan_interval_autoconnect ?
+ main_opts.default_params.le_scan_interval_autoconnect :
+ 0x60, &value[0]);
+
+ put_le16(main_opts.default_params.le_scan_win_autoconnect ?
+ main_opts.default_params.le_scan_win_autoconnect :
+ 0x30, &value[2]);

bt_gatt_client_write_without_response(scan->client, scan->iwhandle,
false, value, sizeof(value));
--
2.27.0.212.ge8ba1cc988-goog

2020-06-26 21:18:47

by bluez.test.bot

Subject: RE: [BlueZ,v1] profiles/scanparam: use configured scanparams when available

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
While we are preparing for reviewing the patches, we found the following
issue/warning.

Test Result:
checkpatch Failed

Outputs:
WARNING:BLOCK_COMMENT_STYLE: Block comments use a trailing */ on a separate line
#34: FILE: profiles/scanparam/scan.c:78:
+ * parameters */

- total: 0 errors, 1 warnings, 30 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.

Your patch has style problems, please review.

NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPLIT_STRING SSCANF_TO_KSTRTO

NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.



---
Regards,
Linux Bluetooth