2021-03-30 06:20:52

by Manish Mandlik

Subject: [bluez PATCH v1] test: Fix AdvMonitor RSSI filter properties

Update the creation of Advertisement Monitor object as per the
decoupled RSSIThresholdsAndTimers strucure.
More info: doc/advertisement-monitor-api.txt

Reviewed-by: [email protected]
Reviewed-by: [email protected]
Reviewed-by: [email protected]
Signed-off-by: Manish Mandlik <[email protected]>
---

test/example-adv-monitor | 15 ++++++++-------
1 file changed, 8 insertions(+), 7 deletions(-)

diff --git a/test/example-adv-monitor b/test/example-adv-monitor
index 6fe8a3058..a405fc7b0 100644
--- a/test/example-adv-monitor
+++ b/test/example-adv-monitor
@@ -61,8 +61,10 @@ class AdvMonitor(dbus.service.Object):
def get_properties(self):
properties = dict()
properties['Type'] = dbus.String(self.monitor_type)
- properties['RSSIThresholdsAndTimers'] = dbus.Struct(self.rssi,
- signature='nqnq')
+ properties['RSSIHighThreshold'] = dbus.Int16(self.rssi_h_thresh)
+ properties['RSSIHighTimeout'] = dbus.UInt16(self.rssi_h_timeout)
+ properties['RSSILowThreshold'] = dbus.Int16(self.rssi_l_thresh)
+ properties['RSSILowTimeout'] = dbus.UInt16(self.rssi_l_timeout)
properties['Patterns'] = dbus.Array(self.patterns, signature='(yyay)')
return {ADV_MONITOR_IFACE: properties}

@@ -72,11 +74,10 @@ class AdvMonitor(dbus.service.Object):


def _set_rssi(self, rssi):
- h_thresh = dbus.Int16(rssi[self.RSSI_H_THRESH])
- h_timeout = dbus.UInt16(rssi[self.RSSI_H_TIMEOUT])
- l_thresh = dbus.Int16(rssi[self.RSSI_L_THRESH])
- l_timeout = dbus.UInt16(rssi[self.RSSI_L_TIMEOUT])
- self.rssi = (h_thresh, h_timeout, l_thresh, l_timeout)
+ self.rssi_h_thresh = rssi[self.RSSI_H_THRESH]
+ self.rssi_h_timeout = rssi[self.RSSI_H_TIMEOUT]
+ self.rssi_l_thresh = rssi[self.RSSI_L_THRESH]
+ self.rssi_l_timeout = rssi[self.RSSI_L_TIMEOUT]


def _set_patterns(self, patterns):
--
2.31.0.291.g576ba9dcdaf-goog

2021-03-30 06:45:55

by bluez.test.bot

Subject: RE: [bluez,v1] test: Fix AdvMonitor RSSI filter properties

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=457825

---Test result---

##############################
Test: CheckPatch - PASS

##############################
Test: CheckGitLint - PASS

##############################
Test: CheckBuild: Setup ELL - PASS

##############################
Test: CheckBuild: Setup - PASS

##############################
Test: CheckBuild - PASS

##############################
Test: MakeCheck - PASS

##############################
Test: CheckBuild w/external ell - PASS



---
Regards,
Linux Bluetooth

2021-03-30 19:28:08

by Luiz Augusto von Dentz

Subject: Re: [bluez,v1] test: Fix AdvMonitor RSSI filter properties

Hi Manish,

On Mon, Mar 29, 2021 at 11:45 PM <[email protected]> wrote:
>
> This is automated email and please do not reply to this email!
>
> Dear submitter,
>
> Thank you for submitting the patches to the linux bluetooth mailing list.
> This is a CI test results with your patch series:
> PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=457825
>
> ---Test result---
>
> ##############################
> Test: CheckPatch - PASS
>
> ##############################
> Test: CheckGitLint - PASS
>
> ##############################
> Test: CheckBuild: Setup ELL - PASS
>
> ##############################
> Test: CheckBuild: Setup - PASS
>
> ##############################
> Test: CheckBuild - PASS
>
> ##############################
> Test: MakeCheck - PASS
>
> ##############################
> Test: CheckBuild w/external ell - PASS
>
>
>
> ---
> Regards,
> Linux Bluetooth

Applied, thanks.

--
Luiz Augusto von Dentz