2022-02-24 18:35:30

by Fabrice Fontaine

[permalink] [raw]
Subject: [PATCH BlueZ] src/shared/util.h: include sys/types.h

Include sys/types.h to avoid the following build failure on musl raised
since commit fb57ad9b9d107856e5f1c8135da04ffa2f7a11ac:

In file included from src/shared/queue.c:15:
./src/shared/util.h:106:1: error: unknown type name 'ssize_t'; did you mean 'size_t'?
106 | ssize_t util_getrandom(void *buf, size_t buflen, unsigned int flags);
| ^~~~~~~
| size_t

Fixes:
- http://autobuild.buildroot.org/results/83eaeb3863040645409f5787fdbdde79385c5257
---
src/shared/util.h | 1 +
1 file changed, 1 insertion(+)

diff --git a/src/shared/util.h b/src/shared/util.h
index c01eccf8a..554481e1e 100644
--- a/src/shared/util.h
+++ b/src/shared/util.h
@@ -14,6 +14,7 @@
#include <alloca.h>
#include <byteswap.h>
#include <string.h>
+#include <sys/types.h>

#define ARRAY_SIZE(arr) (sizeof(arr) / sizeof((arr)[0]))
#define BIT(n) (1 << (n))
--
2.34.1


2022-02-24 19:04:35

by bluez.test.bot

[permalink] [raw]
Subject: RE: [BlueZ] src/shared/util.h: include sys/types.h

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=617667

---Test result---

Test Summary:
CheckPatch FAIL 1.36 seconds
GitLint FAIL 1.00 seconds
Prep - Setup ELL PASS 39.01 seconds
Build - Prep PASS 0.72 seconds
Build - Configure PASS 7.96 seconds
Build - Make PASS 1299.98 seconds
Make Check PASS 10.86 seconds
Make Check w/Valgrind PASS 404.14 seconds
Make Distcheck PASS 209.80 seconds
Build w/ext ELL - Configure PASS 8.07 seconds
Build w/ext ELL - Make PASS 1299.42 seconds
Incremental Build with patchesPASS 0.00 seconds

Details
##############################
Test: CheckPatch - FAIL
Desc: Run checkpatch.pl script with rule in .checkpatch.conf
Output:
[BlueZ] src/shared/util.h: include sys/types.h
WARNING:UNKNOWN_COMMIT_ID: Unknown commit id 'fb57ad9b9d107856e5f1c8135da04ffa2f7a11ac', maybe rebased or not pulled?
#80:
since commit fb57ad9b9d107856e5f1c8135da04ffa2f7a11ac:

WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#84:
106 | ssize_t util_getrandom(void *buf, size_t buflen, unsigned int flags);

/github/workspace/src/12759083.patch total: 0 errors, 2 warnings, 7 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.

/github/workspace/src/12759083.patch has style problems, please review.

NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO

NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.


##############################
Test: GitLint - FAIL
Desc: Run gitlint with rule in .gitlint
Output:
[BlueZ] src/shared/util.h: include sys/types.h
7: B1 Line exceeds max length (85>80): "./src/shared/util.h:106:1: error: unknown type name 'ssize_t'; did you mean 'size_t'?"
13: B1 Line exceeds max length (82>80): " - http://autobuild.buildroot.org/results/83eaeb3863040645409f5787fdbdde79385c5257"




---
Regards,
Linux Bluetooth