2022-05-30 20:16:30

by Hakan Jansson

[permalink] [raw]
Subject: [PATCH v3 0/2] Bluetooth: hci_bcm: Autobaud mode support

Some devices (e.g. CYW5557x) require autobaud mode to enable FW loading.
Autobaud mode can also be required on some boards where the controller
device is using a non-standard baud rate when first powered on.

Only a limited subset of HCI commands are supported in autobaud mode.

These patches add a DT property, "brcm,requires-autobaud-mode", to control
autobaud mode selection.

Changes v2 -> v3:
- Rename DT property and modify description in binding document

Changes v1 -> v2:
- Modify description in binding document

Hakan Jansson (2):
dt-bindings: net: broadcom-bluetooth: Add property for autobaud mode
Bluetooth: hci_bcm: Add support for FW loading in autobaud mode

.../bindings/net/broadcom-bluetooth.yaml | 7 +++++
drivers/bluetooth/btbcm.c | 31 ++++++++++++++-----
drivers/bluetooth/btbcm.h | 8 ++---
drivers/bluetooth/hci_bcm.c | 16 ++++++++--
4 files changed, 47 insertions(+), 15 deletions(-)


base-commit: 677fb7525331375ba2f90f4bc94a80b9b6e697a3
--
2.25.1



2022-05-31 12:33:05

by Hakan Jansson

[permalink] [raw]
Subject: [PATCH v3 1/2] dt-bindings: net: broadcom-bluetooth: Add property for autobaud mode

Add property, "brcm,requires-autobaud-mode", to enable autobaud mode
selection.

Some devices (e.g. CYW5557x) require autobaud mode to enable FW loading.
Autobaud mode can also be required on some boards where the controller
device is using a non-standard baud rate when first powered on.

Signed-off-by: Hakan Jansson <[email protected]>
---
V2 -> V3:
- Rename DT property and modify description
https://lore.kernel.org/linux-devicetree/[email protected]/

V1 -> V2:
- Modify property description

.../devicetree/bindings/net/broadcom-bluetooth.yaml | 7 +++++++
1 file changed, 7 insertions(+)

diff --git a/Documentation/devicetree/bindings/net/broadcom-bluetooth.yaml b/Documentation/devicetree/bindings/net/broadcom-bluetooth.yaml
index 5aac094fd217..0a58d0fbcbc4 100644
--- a/Documentation/devicetree/bindings/net/broadcom-bluetooth.yaml
+++ b/Documentation/devicetree/bindings/net/broadcom-bluetooth.yaml
@@ -92,6 +92,13 @@ properties:
pcm-sync-mode: slave, master
pcm-clock-mode: slave, master

+ brcm,requires-autobaud-mode:
+ type: boolean
+ description:
+ Set this property if autobaud mode is required. Autobaud mode is required
+ if the device's initial baud rate in normal mode is not supported by the
+ host or if the device requires autobaud mode startup before loading FW.
+
interrupts:
items:
- description: Handle to the line HOST_WAKE used to wake
--
2.25.1


2022-06-01 05:19:15

by bluez.test.bot

[permalink] [raw]
Subject: RE: Bluetooth: hci_bcm: Autobaud mode support

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=646037

---Test result---

Test Summary:
CheckPatch PASS 2.94 seconds
GitLint FAIL 1.47 seconds
SubjectPrefix FAIL 0.65 seconds
BuildKernel PASS 35.43 seconds
BuildKernel32 PASS 31.25 seconds
Incremental Build with patchesPASS 48.75 seconds
TestRunner: Setup PASS 552.97 seconds
TestRunner: l2cap-tester PASS 18.88 seconds
TestRunner: bnep-tester PASS 6.90 seconds
TestRunner: mgmt-tester PASS 114.46 seconds
TestRunner: rfcomm-tester PASS 11.12 seconds
TestRunner: sco-tester PASS 11.08 seconds
TestRunner: smp-tester PASS 11.06 seconds
TestRunner: userchan-tester PASS 7.66 seconds

Details
##############################
Test: GitLint - FAIL - 1.47 seconds
Run gitlint with rule in .gitlint
[v3,1/2] dt-bindings: net: broadcom-bluetooth: Add property for autobaud mode
14: B1 Line exceeds max length (93>80): " https://lore.kernel.org/linux-devicetree/[email protected]/"

[v3,2/2] Bluetooth: hci_bcm: Add support for FW loading in autobaud mode
21: B1 Line exceeds max length (93>80): " https://lore.kernel.org/linux-devicetree/[email protected]/"


##############################
Test: SubjectPrefix - FAIL - 0.65 seconds
Check subject contains "Bluetooth" prefix
"Bluetooth: " is not specified in the subject



---
Regards,
Linux Bluetooth

2022-06-02 22:36:26

by patchwork-bot+bluetooth

[permalink] [raw]
Subject: Re: [PATCH v3 0/2] Bluetooth: hci_bcm: Autobaud mode support

Hello:

This series was applied to bluetooth/bluetooth-next.git (master)
by Marcel Holtmann <[email protected]>:

On Mon, 30 May 2022 17:02:16 +0200 you wrote:
> Some devices (e.g. CYW5557x) require autobaud mode to enable FW loading.
> Autobaud mode can also be required on some boards where the controller
> device is using a non-standard baud rate when first powered on.
>
> Only a limited subset of HCI commands are supported in autobaud mode.
>
> These patches add a DT property, "brcm,requires-autobaud-mode", to control
> autobaud mode selection.
>
> [...]

Here is the summary with links:
- [v3,1/2] dt-bindings: net: broadcom-bluetooth: Add property for autobaud mode
https://git.kernel.org/bluetooth/bluetooth-next/c/6d912cc3c21f
- [v3,2/2] Bluetooth: hci_bcm: Add support for FW loading in autobaud mode
https://git.kernel.org/bluetooth/bluetooth-next/c/3f125894bed7

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html