2022-08-25 20:47:35

by Christian Eggers

Subject: [PATCH] client: Add missing return statement in error path

Client will SEGFAULT if default_ctrl==NULL

Fixes: 936ad5ef7b56 ("client: Quit when done with command")
Signed-off-by: Christian Eggers <[email protected]>
---
client/main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/client/main.c b/client/main.c
index 88c7ad799888..754157b169c6 100644
--- a/client/main.c
+++ b/client/main.c
@@ -2546,7 +2546,7 @@ static void cmd_advertise(int argc, char *argv[])

if (!default_ctrl || !default_ctrl->ad_proxy) {
bt_shell_printf("LEAdvertisingManager not found\n");
- bt_shell_noninteractive_quit(EXIT_FAILURE);
+ return bt_shell_noninteractive_quit(EXIT_FAILURE);
}

if (enable == TRUE)
--
2.35.3

2022-08-25 21:36:31

by bluez.test.bot

Subject: RE: client: Add missing return statement in error path

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=671219

---Test result---

Test Summary:
CheckPatch FAIL 0.70 seconds
GitLint PASS 0.48 seconds
Prep - Setup ELL PASS 33.47 seconds
Build - Prep PASS 0.82 seconds
Build - Configure PASS 10.61 seconds
Build - Make PASS 1162.23 seconds
Make Check PASS 12.57 seconds
Make Check w/Valgrind PASS 354.24 seconds
Make Distcheck PASS 297.11 seconds
Build w/ext ELL - Configure PASS 10.59 seconds
Build w/ext ELL - Make PASS 104.71 seconds
Incremental Build w/ patches PASS 0.00 seconds
Scan Build PASS 646.48 seconds

Details
##############################
Test: CheckPatch - FAIL
Desc: Run checkpatch.pl script with rule in .checkpatch.conf
Output:
client: Add missing return statement in error path
WARNING:UNKNOWN_COMMIT_ID: Unknown commit id '936ad5ef7b56', maybe rebased or not pulled?
#108:
Fixes: 936ad5ef7b56 ("client: Quit when done with command")

/github/workspace/src/12955220.patch total: 0 errors, 1 warnings, 8 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.

/github/workspace/src/12955220.patch has style problems, please review.

NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO

NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.




---
Regards,
Linux Bluetooth

2022-08-29 20:16:26

by patchwork-bot+bluetooth

Subject: Re: [PATCH] client: Add missing return statement in error path

Hello:

This patch was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <[email protected]>:

On Thu, 25 Aug 2022 22:39:03 +0200 you wrote:
> Client will SEGFAULT if default_ctrl==NULL
>
> Fixes: 936ad5ef7b56 ("client: Quit when done with command")
> Signed-off-by: Christian Eggers <[email protected]>
> ---
> client/main.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)

Here is the summary with links:
- client: Add missing return statement in error path
https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=9b93d958845b

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html