2022-09-23 12:16:26

by Isak Westin

Subject: [PATCH BlueZ 1/2] mesh: Clear addr field if virt sub failed

If processing failed for a Config Model Subscription Virtual Address
Add/Delete/Overwrite message, the address field in the status reply
should be set to zero. See MshPRFv1.0.1 section 4.4.1.2.8.
---
mesh/cfgmod-server.c | 4 ++++
1 file changed, 4 insertions(+)

diff --git a/mesh/cfgmod-server.c b/mesh/cfgmod-server.c
index c1e1faa6a..9bc2f1c97 100644
--- a/mesh/cfgmod-server.c
+++ b/mesh/cfgmod-server.c
@@ -286,6 +286,10 @@ static uint16_t cfg_virt_sub_add_msg(struct mesh_node *node, const uint8_t *pkt,
label, true, addr, opcode))
msg[n] = MESH_STATUS_STORAGE_FAIL;

+ /* If processing failed, set addr field to zero in reply */
+ if (msg[n] != MESH_STATUS_SUCCESS)
+ addr = UNASSIGNED_ADDRESS;
+
l_put_le16(ele_addr, msg + n + 1);
l_put_le16(addr, msg + n + 3);

--
2.20.1

2022-09-23 14:11:35

by bluez.test.bot

Subject: RE: Mesh: Fixes to comply with mesh profile

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=679853

---Test result---

Test Summary:
CheckPatch PASS 2.24 seconds
GitLint PASS 1.67 seconds
Prep - Setup ELL PASS 36.89 seconds
Build - Prep PASS 0.81 seconds
Build - Configure PASS 8.60 seconds
Build - Make PASS 1240.83 seconds
Make Check PASS 12.09 seconds
Make Check w/Valgrind PASS 400.43 seconds
Make Distcheck PASS 252.41 seconds
Build w/ext ELL - Configure PASS 8.77 seconds
Build w/ext ELL - Make PASS 139.00 seconds
Incremental Build w/ patches PASS 314.75 seconds
Scan Build PASS 873.87 seconds



---
Regards,
Linux Bluetooth