2022-09-23 18:02:02

by Gix, Brian

Subject: [PATCH BlueZ v5 1/2] mesh: Improve PB-ADV timing for reliability

Because provisioning is not speed dependent, Timing on outbound PB-ADV
packets have been modified to be less likely missed by remote controlers
with looser timing capabilities.
---
mesh/pb-adv.c | 9 ++++++---
1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/mesh/pb-adv.c b/mesh/pb-adv.c
index 83f922aa8..180b16258 100644
--- a/mesh/pb-adv.c
+++ b/mesh/pb-adv.c
@@ -23,6 +23,8 @@
#include "mesh/provision.h"
#include "mesh/pb-adv.h"

+#include "mesh/util.h"
+

struct pb_adv_session {
mesh_prov_open_func_t open_cb;
@@ -158,7 +160,7 @@ static void send_adv_segs(struct pb_adv_session *session, const uint8_t *data,
l_debug("max_seg: %2.2x", max_seg);
l_debug("size: %2.2x, CRC: %2.2x", size, buf[9]);

- pb_adv_send(session, MESH_IO_TX_COUNT_UNLIMITED, 200,
+ pb_adv_send(session, MESH_IO_TX_COUNT_UNLIMITED, 500,
buf, init_size + 10);

consumed = init_size;
@@ -174,7 +176,7 @@ static void send_adv_segs(struct pb_adv_session *session, const uint8_t *data,
buf[6] = (i << 2) | 0x02;
memcpy(buf + 7, data + consumed, seg_size);

- pb_adv_send(session, MESH_IO_TX_COUNT_UNLIMITED, 200,
+ pb_adv_send(session, MESH_IO_TX_COUNT_UNLIMITED, 500,
buf, seg_size + 7);

consumed += seg_size;
@@ -270,7 +272,8 @@ static void send_ack(struct pb_adv_session *session, uint8_t trans_num)
ack.trans_num = trans_num;
ack.opcode = PB_ADV_ACK;

- pb_adv_send(session, 1, 100, &ack, sizeof(ack));
+ pb_adv_send(session, MESH_IO_TX_COUNT_UNLIMITED, 500,
+ &ack, sizeof(ack));
}

static void send_close_ind(struct pb_adv_session *session, uint8_t reason)
--
2.37.3

2022-09-23 19:33:37

by bluez.test.bot

Subject: RE: Mesh demon switched to using kernel Mesh MGMT

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=679972

---Test result---

Test Summary:
CheckPatch PASS 3.72 seconds
GitLint PASS 1.59 seconds
Prep - Setup ELL PASS 32.34 seconds
Build - Prep PASS 0.80 seconds
Build - Configure PASS 10.16 seconds
Build - Make PASS 962.18 seconds
Make Check PASS 13.10 seconds
Make Check w/Valgrind PASS 346.94 seconds
Make Distcheck PASS 288.02 seconds
Build w/ext ELL - Configure PASS 10.29 seconds
Build w/ext ELL - Make PASS 101.50 seconds
Incremental Build w/ patches PASS 239.82 seconds
Scan Build PASS 663.36 seconds



---
Regards,
Linux Bluetooth