This adds GMCS UUIDs which will be used by Media Control Profile.
---
lib/uuid.h | 15 +++++++++++++++
1 file changed, 15 insertions(+)
diff --git a/lib/uuid.h b/lib/uuid.h
index f667a74b9..d5e5665e4 100644
--- a/lib/uuid.h
+++ b/lib/uuid.h
@@ -171,6 +171,21 @@ extern "C" {
#define VOL_CP_CHRC_UUID 0x2B7E
#define VOL_FLAG_CHRC_UUID 0x2B7F
+#define GMCS_UUID 0x1849
+#define MEDIA_PLAYER_NAME_CHRC_UUID 0x2b93
+#define MEDIA_TRACK_CHNGD_CHRC_UUID 0x2b96
+#define MEDIA_TRACK_TITLE_CHRC_UUID 0x2b97
+#define MEDIA_TRACK_DURATION_CHRC_UUID 0x2b98
+#define MEDIA_TRACK_POSTION_CHRC_UUID 0x2b99
+#define MEDIA_PLAYBACK_SPEED_CHRC_UUID 0x2b9a
+#define MEDIA_SEEKING_SPEED_CHRC_UUID 0x2b9b
+#define MEDIA_PLAYING_ORDER_CHRC_UUID 0x2ba1
+#define MEDIA_PLAY_ORDER_SUPPRTD_CHRC_UUID 0x2ba2
+#define MEDIA_STATE_CHRC_UUID 0x2ba3
+#define MEDIA_CP_CHRC_UUID 0x2ba4
+#define MEDIA_CP_OP_SUPPORTED_CHRC_UUID 0x2ba5
+#define MEDIA_CONTENT_CONTROL_ID_CHRC_UUID 0x2bba
+
typedef struct {
enum {
BT_UUID_UNSPEC = 0,
--
2.25.1
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=685849
---Test result---
Test Summary:
CheckPatch FAIL 8.07 seconds
GitLint PASS 4.22 seconds
Prep - Setup ELL PASS 27.73 seconds
Build - Prep PASS 0.83 seconds
Build - Configure PASS 8.79 seconds
Build - Make FAIL 88.77 seconds
Make Check FAIL 65.37 seconds
Make Check w/Valgrind FAIL 72.25 seconds
Make Distcheck FAIL 11.44 seconds
Build w/ext ELL - Configure PASS 9.08 seconds
Build w/ext ELL - Make FAIL 31.02 seconds
Incremental Build w/ patches FAIL 242.99 seconds
Scan Build FAIL 634.26 seconds
Details
##############################
Test: CheckPatch - FAIL
Desc: Run checkpatch.pl script with rule in .checkpatch.conf
Output:
[BlueZ,v2,2/4] shared/mcp: Add initial code for handling MCP
WARNING:PREFER_DEFINED_ATTRIBUTE_MACRO: Prefer __packed over __attribute__((packed))
#1533: FILE: src/shared/mcp.h:14:
+#define __packed __attribute__((packed))
/github/workspace/src/13008875.patch total: 0 errors, 1 warnings, 1552 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
/github/workspace/src/13008875.patch has style problems, please review.
NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
##############################
Test: Build - Make - FAIL
Desc: Build the BlueZ source tree
Output:
tools/mgmt-tester.c: In function ‘main’:
tools/mgmt-tester.c:12514:5: note: variable tracking size limit exceeded with ‘-fvar-tracking-assignments’, retrying without
12514 | int main(int argc, char *argv[])
| ^~~~
profiles/audio/mcp.c:140:6: error: no previous declaration for ‘cb_track_changed’ [-Werror=missing-declarations]
140 | void cb_track_changed(struct bt_mcp *mcp)
| ^~~~~~~~~~~~~~~~
profiles/audio/mcp.c:148:6: error: no previous declaration for ‘cb_track_title’ [-Werror=missing-declarations]
148 | void cb_track_title(struct bt_mcp *mcp, const uint8_t *value,
| ^~~~~~~~~~~~~~
profiles/audio/mcp.c:166:6: error: no previous declaration for ‘cb_track_duration’ [-Werror=missing-declarations]
166 | void cb_track_duration(struct bt_mcp *mcp, int32_t duration)
| ^~~~~~~~~~~~~~~~~
profiles/audio/mcp.c: In function ‘cb_track_duration’:
profiles/audio/mcp.c:172:10: error: pointer targets in passing argument 1 of ‘sprintf’ differ in signedness [-Werror=pointer-sign]
172 | sprintf(buf, "%d", duration);
| ^~~
| |
| unsigned char *
In file included from /usr/include/features.h:461,
from /usr/include/ctype.h:25,
from profiles/audio/mcp.c:16:
/usr/include/x86_64-linux-gnu/bits/stdio2.h:34:1: note: expected ‘char * restrict’ but argument is of type ‘unsigned char *’
34 | __NTH (sprintf (char *__restrict __s, const char *__restrict __fmt, ...))
| ^~~~~
profiles/audio/mcp.c: At top level:
profiles/audio/mcp.c:177:6: error: no previous declaration for ‘cb_track_position’ [-Werror=missing-declarations]
177 | void cb_track_position(struct bt_mcp *mcp, int32_t duration)
| ^~~~~~~~~~~~~~~~~
profiles/audio/mcp.c:185:6: error: no previous declaration for ‘cb_media_state’ [-Werror=missing-declarations]
185 | void cb_media_state(struct bt_mcp *mcp, uint8_t status)
| ^~~~~~~~~~~~~~
cc1: all warnings being treated as errors
make[1]: *** [Makefile:10202: profiles/audio/bluetoothd-mcp.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:4465: all] Error 2
##############################
Test: Make Check - FAIL
Desc: Run 'make check'
Output:
monitor/att.c:1939:13: error: no previous declaration for ‘play_order_str’ [-Werror=missing-declarations]
1939 | const char *play_order_str(uint8_t order)
| ^~~~~~~~~~~~~~
monitor/att.c:2047:13: error: no previous declaration for ‘media_state_str’ [-Werror=missing-declarations]
2047 | const char *media_state_str(uint8_t state)
| ^~~~~~~~~~~~~~~
monitor/att.c:2116:13: error: no previous declaration for ‘cp_opcode_str’ [-Werror=missing-declarations]
2116 | const char *cp_opcode_str(uint8_t opcode)
| ^~~~~~~~~~~~~
cc1: all warnings being treated as errors
make[1]: *** [Makefile:7518: monitor/att.o] Error 1
make: *** [Makefile:11650: check] Error 2
##############################
Test: Make Check w/Valgrind - FAIL
Desc: Run 'make check' with Valgrind
Output:
tools/mgmt-tester.c: In function ‘main’:
tools/mgmt-tester.c:12514:5: note: variable tracking size limit exceeded with ‘-fvar-tracking-assignments’, retrying without
12514 | int main(int argc, char *argv[])
| ^~~~
profiles/audio/mcp.c:140:6: error: no previous declaration for ‘cb_track_changed’ [-Werror=missing-declarations]
140 | void cb_track_changed(struct bt_mcp *mcp)
| ^~~~~~~~~~~~~~~~
profiles/audio/mcp.c:148:6: error: no previous declaration for ‘cb_track_title’ [-Werror=missing-declarations]
148 | void cb_track_title(struct bt_mcp *mcp, const uint8_t *value,
| ^~~~~~~~~~~~~~
profiles/audio/mcp.c:166:6: error: no previous declaration for ‘cb_track_duration’ [-Werror=missing-declarations]
166 | void cb_track_duration(struct bt_mcp *mcp, int32_t duration)
| ^~~~~~~~~~~~~~~~~
profiles/audio/mcp.c: In function ‘cb_track_duration’:
profiles/audio/mcp.c:172:10: error: pointer targets in passing argument 1 of ‘sprintf’ differ in signedness [-Werror=pointer-sign]
172 | sprintf(buf, "%d", duration);
| ^~~
| |
| unsigned char *
In file included from /usr/include/features.h:461,
from /usr/include/ctype.h:25,
from profiles/audio/mcp.c:16:
/usr/include/x86_64-linux-gnu/bits/stdio2.h:34:1: note: expected ‘char * restrict’ but argument is of type ‘unsigned char *’
34 | __NTH (sprintf (char *__restrict __s, const char *__restrict __fmt, ...))
| ^~~~~
profiles/audio/mcp.c: At top level:
profiles/audio/mcp.c:177:6: error: no previous declaration for ‘cb_track_position’ [-Werror=missing-declarations]
177 | void cb_track_position(struct bt_mcp *mcp, int32_t duration)
| ^~~~~~~~~~~~~~~~~
profiles/audio/mcp.c:185:6: error: no previous declaration for ‘cb_media_state’ [-Werror=missing-declarations]
185 | void cb_media_state(struct bt_mcp *mcp, uint8_t status)
| ^~~~~~~~~~~~~~
cc1: all warnings being treated as errors
make[1]: *** [Makefile:10202: profiles/audio/bluetoothd-mcp.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:4465: all] Error 2
##############################
Test: Make Distcheck - FAIL
Desc: Run distcheck to check the distribution
Output:
make[2]: *** No rule to make target 'shared/mcs.h', needed by 'distdir-am'. Stop.
make[1]: *** [Makefile:11483: distdir] Error 2
make: *** [Makefile:11559: dist] Error 2
##############################
Test: Build w/ext ELL - Make - FAIL
Desc: Build BlueZ source with '--enable-external-ell' configuration
Output:
profiles/audio/mcp.c:140:6: error: no previous declaration for ‘cb_track_changed’ [-Werror=missing-declarations]
140 | void cb_track_changed(struct bt_mcp *mcp)
| ^~~~~~~~~~~~~~~~
profiles/audio/mcp.c:148:6: error: no previous declaration for ‘cb_track_title’ [-Werror=missing-declarations]
148 | void cb_track_title(struct bt_mcp *mcp, const uint8_t *value,
| ^~~~~~~~~~~~~~
profiles/audio/mcp.c:166:6: error: no previous declaration for ‘cb_track_duration’ [-Werror=missing-declarations]
166 | void cb_track_duration(struct bt_mcp *mcp, int32_t duration)
| ^~~~~~~~~~~~~~~~~
profiles/audio/mcp.c: In function ‘cb_track_duration’:
profiles/audio/mcp.c:172:10: error: pointer targets in passing argument 1 of ‘sprintf’ differ in signedness [-Werror=pointer-sign]
172 | sprintf(buf, "%d", duration);
| ^~~
| |
| unsigned char *
In file included from /usr/include/features.h:461,
from /usr/include/ctype.h:25,
from profiles/audio/mcp.c:16:
/usr/include/x86_64-linux-gnu/bits/stdio2.h:34:1: note: expected ‘char * restrict’ but argument is of type ‘unsigned char *’
34 | __NTH (sprintf (char *__restrict __s, const char *__restrict __fmt, ...))
| ^~~~~
profiles/audio/mcp.c: At top level:
profiles/audio/mcp.c:177:6: error: no previous declaration for ‘cb_track_position’ [-Werror=missing-declarations]
177 | void cb_track_position(struct bt_mcp *mcp, int32_t duration)
| ^~~~~~~~~~~~~~~~~
profiles/audio/mcp.c:185:6: error: no previous declaration for ‘cb_media_state’ [-Werror=missing-declarations]
185 | void cb_media_state(struct bt_mcp *mcp, uint8_t status)
| ^~~~~~~~~~~~~~
cc1: all warnings being treated as errors
make[1]: *** [Makefile:10202: profiles/audio/bluetoothd-mcp.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:4465: all] Error 2
##############################
Test: Incremental Build w/ patches - FAIL
Desc: Incremental build per patch in the series
Output:
profiles/audio/mcp.c:140:6: error: no previous declaration for ‘cb_track_changed’ [-Werror=missing-declarations]
140 | void cb_track_changed(struct bt_mcp *mcp)
| ^~~~~~~~~~~~~~~~
profiles/audio/mcp.c:148:6: error: no previous declaration for ‘cb_track_title’ [-Werror=missing-declarations]
148 | void cb_track_title(struct bt_mcp *mcp, const uint8_t *value,
| ^~~~~~~~~~~~~~
profiles/audio/mcp.c:166:6: error: no previous declaration for ‘cb_track_duration’ [-Werror=missing-declarations]
166 | void cb_track_duration(struct bt_mcp *mcp, int32_t duration)
| ^~~~~~~~~~~~~~~~~
profiles/audio/mcp.c: In function ‘cb_track_duration’:
profiles/audio/mcp.c:172:10: error: pointer targets in passing argument 1 of ‘sprintf’ differ in signedness [-Werror=pointer-sign]
172 | sprintf(buf, "%d", duration);
| ^~~
| |
| unsigned char *
In file included from /usr/include/features.h:461,
from /usr/include/ctype.h:25,
from profiles/audio/mcp.c:16:
/usr/include/x86_64-linux-gnu/bits/stdio2.h:34:1: note: expected ‘char * restrict’ but argument is of type ‘unsigned char *’
34 | __NTH (sprintf (char *__restrict __s, const char *__restrict __fmt, ...))
| ^~~~~
profiles/audio/mcp.c: At top level:
profiles/audio/mcp.c:177:6: error: no previous declaration for ‘cb_track_position’ [-Werror=missing-declarations]
177 | void cb_track_position(struct bt_mcp *mcp, int32_t duration)
| ^~~~~~~~~~~~~~~~~
profiles/audio/mcp.c:185:6: error: no previous declaration for ‘cb_media_state’ [-Werror=missing-declarations]
185 | void cb_media_state(struct bt_mcp *mcp, uint8_t status)
| ^~~~~~~~~~~~~~
cc1: all warnings being treated as errors
make[1]: *** [Makefile:10202: profiles/audio/bluetoothd-mcp.o] Error 1
make[1]: *** Waiting for unfinished jobs....
make: *** [Makefile:4465: all] Error 2
##############################
Test: Scan Build - FAIL
Desc: Run Scan Build with patches
Output:
client/player.c:1756:25: warning: Dereference of null pointer
iov_append(&cfg->caps, preset->data.iov_base, preset->data.iov_len);
^~~~~~~~~~~~~~~~~~~~~
1 warning generated.
src/shared/ad.c:369:19: warning: Use of zero-allocated memory
buf[(*pos)++] = ad_type;
^
1 warning generated.
src/shared/gatt-client.c:387:21: warning: Use of memory after it is freed
gatt_db_unregister(op->client->db, op->db_id);
^~~~~~~~~~
src/shared/gatt-client.c:600:2: warning: Use of memory after it is freed
discovery_op_complete(op, false, att_ecode);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/gatt-client.c:900:2: warning: Use of memory after it is freed
discovery_op_complete(op, success, att_ecode);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/gatt-client.c:1009:2: warning: Use of memory after it is freed
discovery_op_complete(op, success, att_ecode);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/gatt-client.c:1185:2: warning: Use of memory after it is freed
discovery_op_complete(op, success, att_ecode);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/gatt-client.c:1250:2: warning: Use of memory after it is freed
discovery_op_complete(op, success, att_ecode);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/gatt-client.c:1521:6: warning: Use of memory after it is freed
if (read_db_hash(op)) {
^~~~~~~~~~~~~~~~
src/shared/gatt-client.c:1526:2: warning: Use of memory after it is freed
discover_all(op);
^~~~~~~~~~~~~~~~
src/shared/gatt-client.c:2028:6: warning: Use of memory after it is freed
if (read_db_hash(op)) {
^~~~~~~~~~~~~~~~
src/shared/gatt-client.c:2036:8: warning: Use of memory after it is freed
discovery_op_ref(op),
^~~~~~~~~~~~~~~~~~~~
src/shared/gatt-client.c:3119:2: warning: Use of memory after it is freed
complete_write_long_op(req, success, 0, false);
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
src/shared/gatt-client.c:3141:2: warning: Use of memory after it is freed
request_unref(req);
^~~~~~~~~~~~~~~~~~
12 warnings generated.
monitor/l2cap.c:1616:4: warning: Value stored to 'data' is never read
data += len;
^ ~~~
monitor/l2cap.c:1617:4: warning: Value stored to 'size' is never read
size -= len;
^ ~~~
2 warnings generated.
monitor/att.c:1939:13: error: no previous declaration for ‘play_order_str’ [-Werror=missing-declarations]
1939 | const char *play_order_str(uint8_t order)
| ^~~~~~~~~~~~~~
monitor/att.c:2047:13: error: no previous declaration for ‘media_state_str’ [-Werror=missing-declarations]
2047 | const char *media_state_str(uint8_t state)
| ^~~~~~~~~~~~~~~
monitor/att.c:2116:13: error: no previous declaration for ‘cp_opcode_str’ [-Werror=missing-declarations]
2116 | const char *cp_opcode_str(uint8_t opcode)
| ^~~~~~~~~~~~~
cc1: all warnings being treated as errors
make[1]: *** [Makefile:7518: monitor/att.o] Error 1
make: *** [Makefile:4465: all] Error 2
---
Regards,
Linux Bluetooth