From: "Steven Rostedt (Google)" <[email protected]>
A new "shutdown" timer state is being added to the generic timer code. One
of the functions to change the timer into the state is called
"timer_shutdown()". This means that there can not be other functions called
"timer_shutdown()" as the timer code owns the "timer_*" name space.
Rename timer_shutdown() to spear_timer_shutdown() to avoid this conflict.
Signed-off-by: Steven Rostedt (Google) <[email protected]>
Signed-off-by: Thomas Gleixner <[email protected]>
Tested-by: Guenter Roeck <[email protected]>
Reviewed-by: Guenter Roeck <[email protected]>
Acked-by: Arnd Bergmann <[email protected]>
Acked-by: Viresh Kumar <[email protected]>
Link: https://lkml.kernel.org/r/[email protected]
Link: https://lore.kernel.org/all/[email protected]/
Link: https://lore.kernel.org/r/[email protected]
---
arch/arm/mach-spear/time.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/arch/arm/mach-spear/time.c b/arch/arm/mach-spear/time.c
index e979e2197f8e..5371c824786d 100644
--- a/arch/arm/mach-spear/time.c
+++ b/arch/arm/mach-spear/time.c
@@ -90,7 +90,7 @@ static void __init spear_clocksource_init(void)
200, 16, clocksource_mmio_readw_up);
}
-static inline void timer_shutdown(struct clock_event_device *evt)
+static inline void spear_timer_shutdown(struct clock_event_device *evt)
{
u16 val = readw(gpt_base + CR(CLKEVT));
@@ -101,7 +101,7 @@ static inline void timer_shutdown(struct clock_event_device *evt)
static int spear_shutdown(struct clock_event_device *evt)
{
- timer_shutdown(evt);
+ spear_timer_shutdown(evt);
return 0;
}
@@ -111,7 +111,7 @@ static int spear_set_oneshot(struct clock_event_device *evt)
u16 val;
/* stop the timer */
- timer_shutdown(evt);
+ spear_timer_shutdown(evt);
val = readw(gpt_base + CR(CLKEVT));
val |= CTRL_ONE_SHOT;
@@ -126,7 +126,7 @@ static int spear_set_periodic(struct clock_event_device *evt)
u16 val;
/* stop the timer */
- timer_shutdown(evt);
+ spear_timer_shutdown(evt);
period = clk_get_rate(gpt_clk) / HZ;
period >>= CTRL_PRESCALER16;
--
2.35.1
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=695686
---Test result---
Test Summary:
CheckPatch FAIL 20.38 seconds
GitLint FAIL 14.40 seconds
SubjectPrefix FAIL 11.71 seconds
BuildKernel PASS 36.84 seconds
BuildKernel32 PASS 32.69 seconds
Incremental Build with patchesPASS 263.63 seconds
TestRunner: Setup PASS 532.30 seconds
TestRunner: l2cap-tester PASS 18.21 seconds
TestRunner: iso-tester PASS 17.37 seconds
TestRunner: bnep-tester PASS 6.79 seconds
TestRunner: mgmt-tester PASS 109.81 seconds
TestRunner: rfcomm-tester PASS 10.69 seconds
TestRunner: sco-tester PASS 10.13 seconds
TestRunner: ioctl-tester PASS 11.43 seconds
TestRunner: mesh-tester PASS 8.18 seconds
TestRunner: smp-tester PASS 10.13 seconds
TestRunner: userchan-tester PASS 7.00 seconds
Details
##############################
Test: CheckPatch - FAIL - 20.38 seconds
Run checkpatch.pl script with rule in .checkpatch.conf
[10/15] timers: Silently ignore timers with a NULL function\WARNING:TYPO_SPELLING: 'pathes' may be misspelled - perhaps 'paths'?
#84:
In preparation for that replace the warnings in the relevant code pathes
^^^^^^
total: 0 errors, 1 warnings, 123 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
/github/workspace/src/13044156.patch has style problems, please review.
NOTE: Ignored message types: UNKNOWN_COMMIT_ID
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
[12/15] timers: Add shutdown mechanism to the internal functions\WARNING:TYPO_SPELLING: 'aquisition' may be misspelled - perhaps 'acquisition'?
#133: FILE: kernel/time/timer.c:1322:
+ * aquisition. By taking the lock it is ensured that such a newly
^^^^^^^^^^
total: 0 errors, 1 warnings, 137 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
/github/workspace/src/13044158.patch has style problems, please review.
NOTE: Ignored message types: UNKNOWN_COMMIT_ID
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
##############################
Test: GitLint - FAIL - 14.40 seconds
Run gitlint with rule in .gitlint
[02/15] clocksource/drivers/arm_arch_timer: Do not use timer namespace for timer_shutdown() function
1: T1 Title exceeds max length (100>80): "[02/15] clocksource/drivers/arm_arch_timer: Do not use timer namespace for timer_shutdown() function"
[03/15] clocksource/drivers/sp804: Do not use timer namespace for timer_shutdown() function
1: T1 Title exceeds max length (91>80): "[03/15] clocksource/drivers/sp804: Do not use timer namespace for timer_shutdown() function"
[14/15] timers: Update the documentation to reflect on the new timer_shutdown() API
1: T1 Title exceeds max length (83>80): "[14/15] timers: Update the documentation to reflect on the new timer_shutdown() API"
13: B3 Line contains hard tab characters (\t): " del_timer_sync() returns the number of removal attempts ]"
[15/15] Bluetooth: hci_qca: Fix the teardown problem for real
21: B3 Line contains hard tab characters (\t): " deep in the work queue core code."
##############################
Test: SubjectPrefix - FAIL - 11.71 seconds
Check subject contains "Bluetooth" prefix
"Bluetooth: " is not specified in the subject
"Bluetooth: " is not specified in the subject
"Bluetooth: " is not specified in the subject
"Bluetooth: " is not specified in the subject
"Bluetooth: " is not specified in the subject
"Bluetooth: " is not specified in the subject
"Bluetooth: " is not specified in the subject
"Bluetooth: " is not specified in the subject
"Bluetooth: " is not specified in the subject
"Bluetooth: " is not specified in the subject
"Bluetooth: " is not specified in the subject
"Bluetooth: " is not specified in the subject
"Bluetooth: " is not specified in the subject
"Bluetooth: " is not specified in the subject
---
Regards,
Linux Bluetooth
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=695686
---Test result---
Test Summary:
CheckPatch FAIL 12.25 seconds
GitLint FAIL 5.41 seconds
SubjectPrefix FAIL 2.00 seconds
BuildKernel PASS 35.22 seconds
BuildKernel32 PASS 31.94 seconds
TestRunnerSetup PASS 447.37 seconds
TestRunner_l2cap-tester PASS 16.46 seconds
TestRunner_iso-tester PASS 16.53 seconds
TestRunner_bnep-tester PASS 5.75 seconds
TestRunner_mgmt-tester PASS 109.56 seconds
TestRunner_rfcomm-tester PASS 9.82 seconds
TestRunner_sco-tester PASS 9.20 seconds
TestRunner_ioctl-tester PASS 10.61 seconds
TestRunner_mesh-tester PASS 7.33 seconds
TestRunner_smp-tester PASS 9.08 seconds
TestRunner_userchan-tester PASS 6.15 seconds
IncrementalBuild PASS 243.22 seconds
Details
##############################
Test: CheckPatch - FAIL
Desc: Run checkpatch.pl script
Output:
[10/15] timers: Silently ignore timers with a NULL function
WARNING: 'pathes' may be misspelled - perhaps 'paths'?
#84:
In preparation for that replace the warnings in the relevant code pathes
^^^^^^
total: 0 errors, 1 warnings, 123 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
/github/workspace/src/src/13044156.patch has style problems, please review.
NOTE: Ignored message types: UNKNOWN_COMMIT_ID
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
[12/15] timers: Add shutdown mechanism to the internal functions
WARNING: 'aquisition' may be misspelled - perhaps 'acquisition'?
#133: FILE: kernel/time/timer.c:1322:
+ * aquisition. By taking the lock it is ensured that such a newly
^^^^^^^^^^
total: 0 errors, 1 warnings, 137 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
/github/workspace/src/src/13044158.patch has style problems, please review.
NOTE: Ignored message types: UNKNOWN_COMMIT_ID
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
##############################
Test: GitLint - FAIL
Desc: Run gitlint
Output:
[02/15] clocksource/drivers/arm_arch_timer: Do not use timer namespace for timer_shutdown() function
1: T1 Title exceeds max length (100>80): "[02/15] clocksource/drivers/arm_arch_timer: Do not use timer namespace for timer_shutdown() function"
[03/15] clocksource/drivers/sp804: Do not use timer namespace for timer_shutdown() function
1: T1 Title exceeds max length (91>80): "[03/15] clocksource/drivers/sp804: Do not use timer namespace for timer_shutdown() function"
[14/15] timers: Update the documentation to reflect on the new timer_shutdown() API
1: T1 Title exceeds max length (83>80): "[14/15] timers: Update the documentation to reflect on the new timer_shutdown() API"
13: B3 Line contains hard tab characters (\t): " del_timer_sync() returns the number of removal attempts ]"
[15/15] Bluetooth: hci_qca: Fix the teardown problem for real
21: B3 Line contains hard tab characters (\t): " deep in the work queue core code."
##############################
Test: SubjectPrefix - FAIL
Desc: Check subject contains "Bluetooth" prefix
Output:
"Bluetooth: " prefix is not specified in the subject
"Bluetooth: " prefix is not specified in the subject
"Bluetooth: " prefix is not specified in the subject
"Bluetooth: " prefix is not specified in the subject
"Bluetooth: " prefix is not specified in the subject
"Bluetooth: " prefix is not specified in the subject
"Bluetooth: " prefix is not specified in the subject
"Bluetooth: " prefix is not specified in the subject
"Bluetooth: " prefix is not specified in the subject
"Bluetooth: " prefix is not specified in the subject
"Bluetooth: " prefix is not specified in the subject
"Bluetooth: " prefix is not specified in the subject
"Bluetooth: " prefix is not specified in the subject
"Bluetooth: " prefix is not specified in the subject
---
Regards,
Linux Bluetooth
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=695686
---Test result---
Test Summary:
CheckPatch FAIL 12.07 seconds
GitLint FAIL 5.39 seconds
SubjectPrefix FAIL 2.07 seconds
BuildKernel PASS 34.17 seconds
BuildKernel32 PASS 30.44 seconds
TestRunnerSetup PASS 418.16 seconds
TestRunner_l2cap-tester PASS 15.72 seconds
TestRunner_iso-tester PASS 15.12 seconds
TestRunner_bnep-tester PASS 5.35 seconds
TestRunner_mgmt-tester PASS 108.50 seconds
TestRunner_rfcomm-tester PASS 9.19 seconds
TestRunner_sco-tester PASS 8.64 seconds
TestRunner_ioctl-tester PASS 9.85 seconds
TestRunner_mesh-tester PASS 6.71 seconds
TestRunner_smp-tester PASS 8.43 seconds
TestRunner_userchan-tester PASS 5.60 seconds
IncrementalBuild PASS 224.04 seconds
Details
##############################
Test: CheckPatch - FAIL
Desc: Run checkpatch.pl script
Output:
[10/15] timers: Silently ignore timers with a NULL function
WARNING: 'pathes' may be misspelled - perhaps 'paths'?
#84:
In preparation for that replace the warnings in the relevant code pathes
^^^^^^
total: 0 errors, 1 warnings, 123 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
/github/workspace/src/src/13044156.patch has style problems, please review.
NOTE: Ignored message types: UNKNOWN_COMMIT_ID
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
[12/15] timers: Add shutdown mechanism to the internal functions
WARNING: 'aquisition' may be misspelled - perhaps 'acquisition'?
#133: FILE: kernel/time/timer.c:1322:
+ * aquisition. By taking the lock it is ensured that such a newly
^^^^^^^^^^
total: 0 errors, 1 warnings, 137 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
/github/workspace/src/src/13044158.patch has style problems, please review.
NOTE: Ignored message types: UNKNOWN_COMMIT_ID
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
##############################
Test: GitLint - FAIL
Desc: Run gitlint
Output:
[02/15] clocksource/drivers/arm_arch_timer: Do not use timer namespace for timer_shutdown() function
1: T1 Title exceeds max length (100>80): "[02/15] clocksource/drivers/arm_arch_timer: Do not use timer namespace for timer_shutdown() function"
[03/15] clocksource/drivers/sp804: Do not use timer namespace for timer_shutdown() function
1: T1 Title exceeds max length (91>80): "[03/15] clocksource/drivers/sp804: Do not use timer namespace for timer_shutdown() function"
[14/15] timers: Update the documentation to reflect on the new timer_shutdown() API
1: T1 Title exceeds max length (83>80): "[14/15] timers: Update the documentation to reflect on the new timer_shutdown() API"
13: B3 Line contains hard tab characters (\t): " del_timer_sync() returns the number of removal attempts ]"
[15/15] Bluetooth: hci_qca: Fix the teardown problem for real
21: B3 Line contains hard tab characters (\t): " deep in the work queue core code."
##############################
Test: SubjectPrefix - FAIL
Desc: Check subject contains "Bluetooth" prefix
Output:
"Bluetooth: " prefix is not specified in the subject
"Bluetooth: " prefix is not specified in the subject
"Bluetooth: " prefix is not specified in the subject
"Bluetooth: " prefix is not specified in the subject
"Bluetooth: " prefix is not specified in the subject
"Bluetooth: " prefix is not specified in the subject
"Bluetooth: " prefix is not specified in the subject
"Bluetooth: " prefix is not specified in the subject
"Bluetooth: " prefix is not specified in the subject
"Bluetooth: " prefix is not specified in the subject
"Bluetooth: " prefix is not specified in the subject
"Bluetooth: " prefix is not specified in the subject
"Bluetooth: " prefix is not specified in the subject
"Bluetooth: " prefix is not specified in the subject
---
Regards,
Linux Bluetooth