Subject: [PATCH RESEND] bluetooth: btbcm: Fix logic error in forming the board name.

From: Sasha Finkelstein <[email protected]>

This patch fixes an incorrect loop exit condition in code that replaces
'/' symbols in the board name. There might also be a memory corruption
issue here, but it is unlikely to be a real problem.

Cc: <[email protected]>
Signed-off-by: Sasha Finkelstein <[email protected]>
---
drivers/bluetooth/btbcm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/bluetooth/btbcm.c b/drivers/bluetooth/btbcm.c
index 3006e2a0f37e..43e98a598bd9 100644
--- a/drivers/bluetooth/btbcm.c
+++ b/drivers/bluetooth/btbcm.c
@@ -511,7 +511,7 @@ static const char *btbcm_get_board_name(struct device *dev)
len = strlen(tmp) + 1;
board_type = devm_kzalloc(dev, len, GFP_KERNEL);
strscpy(board_type, tmp, len);
- for (i = 0; i < board_type[i]; i++) {
+ for (i = 0; i < len; i++) {
if (board_type[i] == '/')
board_type[i] = '-';
}

---
base-commit: fe15c26ee26efa11741a7b632e9f23b01aca4cc6
change-id: 20230224-btbcm-wtf-ff32fed3e930

Best regards,
--
Sasha Finkelstein <[email protected]>



2023-03-10 11:02:06

by bluez.test.bot

[permalink] [raw]
Subject: RE: [RESEND] bluetooth: btbcm: Fix logic error in forming the board name.

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=728567

---Test result---

Test Summary:
CheckPatch PASS 0.74 seconds
GitLint FAIL 0.63 seconds
SubjectPrefix FAIL 0.39 seconds
BuildKernel PASS 31.97 seconds
CheckAllWarning PASS 34.72 seconds
CheckSparse PASS 39.10 seconds
CheckSmatch PASS 106.14 seconds
BuildKernel32 PASS 30.78 seconds
TestRunnerSetup PASS 438.26 seconds
TestRunner_l2cap-tester PASS 16.56 seconds
TestRunner_iso-tester PASS 17.61 seconds
TestRunner_bnep-tester PASS 5.83 seconds
TestRunner_mgmt-tester PASS 113.20 seconds
TestRunner_rfcomm-tester PASS 9.21 seconds
TestRunner_sco-tester PASS 8.42 seconds
TestRunner_ioctl-tester PASS 9.89 seconds
TestRunner_mesh-tester PASS 7.27 seconds
TestRunner_smp-tester PASS 8.23 seconds
TestRunner_userchan-tester PASS 6.05 seconds
IncrementalBuild PASS 28.75 seconds

Details
##############################
Test: GitLint - FAIL
Desc: Run gitlint
Output:
[RESEND] bluetooth: btbcm: Fix logic error in forming the board name.

WARNING: I3 - ignore-body-lines: gitlint will be switching from using Python regex 'match' (match beginning) to 'search' (match anywhere) semantics. Please review your ignore-body-lines.regex option accordingly. To remove this warning, set general.regex-style-search=True. More details: https://jorisroovers.github.io/gitlint/configuration/#regex-style-search
1: T3 Title has trailing punctuation (.): "[RESEND] bluetooth: btbcm: Fix logic error in forming the board name."
##############################
Test: SubjectPrefix - FAIL
Desc: Check subject contains "Bluetooth" prefix
Output:
"Bluetooth: " prefix is not specified in the subject


---
Regards,
Linux Bluetooth

2023-03-14 23:10:30

by patchwork-bot+bluetooth

[permalink] [raw]
Subject: Re: [PATCH RESEND] bluetooth: btbcm: Fix logic error in forming the board name.

Hello:

This patch was applied to bluetooth/bluetooth-next.git (master)
by Luiz Augusto von Dentz <[email protected]>:

On Fri, 10 Mar 2023 11:28:42 +0100 you wrote:
> From: Sasha Finkelstein <[email protected]>
>
> This patch fixes an incorrect loop exit condition in code that replaces
> '/' symbols in the board name. There might also be a memory corruption
> issue here, but it is unlikely to be a real problem.
>
> Cc: <[email protected]>
> Signed-off-by: Sasha Finkelstein <[email protected]>
>
> [...]

Here is the summary with links:
- [RESEND] bluetooth: btbcm: Fix logic error in forming the board name.
https://git.kernel.org/bluetooth/bluetooth-next/c/3629e1ce7721

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html