2023-03-10 15:26:25

by Raul Cheleguini

[permalink] [raw]
Subject: [PATCH] Bluetooth: Improve support for Actions Semi ATS2851 based devices

Add two more quirks to resume the device initialization and basic
operation as the device seems not to support "Read Transmit Power"
and "Set Extended Scan Parameters".

< HCI Command: LE Read Transmit Power (0x08|0x004b) plen 0
> HCI Event: Command Status (0x0f) plen 4
LE Read Transmit Power (0x08|0x004b) ncmd 1
Status: Unknown HCI Command (0x01)

< HCI Command: LE Set Extended Scan Parameters (0x08|0x0041) plen 8
Own address type: Random (0x01)
Filter policy: Accept all advertisement (0x00)
PHYs: 0x01
Entry 0: LE 1M
Type: Active (0x01)
Interval: 11.250 msec (0x0012)
Window: 11.250 msec (0x0012)
> HCI Event: Command Status (0x0f) plen 4
LE Set Extended Scan Parameters (0x08|0x0041) ncmd 1
Status: Unknown HCI Command (0x01)

Signed-off-by: Raul Cheleguini <[email protected]>
---
drivers/bluetooth/btusb.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
index 0c94cd7f4af3..7382b021f3df 100644
--- a/drivers/bluetooth/btusb.c
+++ b/drivers/bluetooth/btusb.c
@@ -4104,6 +4104,8 @@ static int btusb_probe(struct usb_interface *intf,
if (id->driver_info & BTUSB_ACTIONS_SEMI) {
/* Support is advertised, but not implemented */
set_bit(HCI_QUIRK_BROKEN_ERR_DATA_REPORTING, &hdev->quirks);
+ set_bit(HCI_QUIRK_BROKEN_READ_TRANSMIT_POWER, &hdev->quirks);
+ set_bit(HCI_QUIRK_BROKEN_EXT_SCAN, &hdev->quirks);
}

if (!reset)
--
2.40.0.rc1.284.g88254d51c5-goog



2023-03-10 16:05:42

by bluez.test.bot

[permalink] [raw]
Subject: RE: Bluetooth: Improve support for Actions Semi ATS2851 based devices

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=728739

---Test result---

Test Summary:
CheckPatch PASS 0.77 seconds
GitLint PASS 0.38 seconds
SubjectPrefix PASS 0.13 seconds
BuildKernel PASS 38.06 seconds
CheckAllWarning PASS 41.85 seconds
CheckSparse PASS 47.12 seconds
CheckSmatch PASS 127.42 seconds
BuildKernel32 PASS 36.93 seconds
TestRunnerSetup PASS 530.68 seconds
TestRunner_l2cap-tester PASS 18.78 seconds
TestRunner_iso-tester PASS 21.25 seconds
TestRunner_bnep-tester PASS 6.89 seconds
TestRunner_mgmt-tester PASS 128.22 seconds
TestRunner_rfcomm-tester PASS 10.63 seconds
TestRunner_sco-tester PASS 9.82 seconds
TestRunner_ioctl-tester PASS 11.58 seconds
TestRunner_mesh-tester PASS 8.66 seconds
TestRunner_smp-tester PASS 9.69 seconds
TestRunner_userchan-tester PASS 7.21 seconds
IncrementalBuild PASS 34.36 seconds



---
Regards,
Linux Bluetooth

2023-03-14 23:10:28

by patchwork-bot+bluetooth

[permalink] [raw]
Subject: Re: [PATCH] Bluetooth: Improve support for Actions Semi ATS2851 based devices

Hello:

This patch was applied to bluetooth/bluetooth-next.git (master)
by Luiz Augusto von Dentz <[email protected]>:

On Fri, 10 Mar 2023 15:14:10 +0000 you wrote:
> Add two more quirks to resume the device initialization and basic
> operation as the device seems not to support "Read Transmit Power"
> and "Set Extended Scan Parameters".
>
> < HCI Command: LE Read Transmit Power (0x08|0x004b) plen 0
> > HCI Event: Command Status (0x0f) plen 4
> LE Read Transmit Power (0x08|0x004b) ncmd 1
> Status: Unknown HCI Command (0x01)
>
> [...]

Here is the summary with links:
- Bluetooth: Improve support for Actions Semi ATS2851 based devices
https://git.kernel.org/bluetooth/bluetooth-next/c/2dc354d004ed

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html