This patch shall enable the LE States quirks by default on all
Intel controller from Solar products on wards.
Signed-off-by: Chethan T N <[email protected]>
---
drivers/bluetooth/btintel.c | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/bluetooth/btintel.c b/drivers/bluetooth/btintel.c
index af774688f1c0..7a6dc05553f1 100644
--- a/drivers/bluetooth/btintel.c
+++ b/drivers/bluetooth/btintel.c
@@ -2684,9 +2684,8 @@ static int btintel_setup_combined(struct hci_dev *hdev)
*/
set_bit(HCI_QUIRK_WIDEBAND_SPEECH_SUPPORTED, &hdev->quirks);
- /* Valid LE States quirk for GfP */
- if (INTEL_HW_VARIANT(ver_tlv.cnvi_bt) == 0x18)
- set_bit(HCI_QUIRK_VALID_LE_STATES, &hdev->quirks);
+ /* Apply LE States quirk from solar onwards */
+ set_bit(HCI_QUIRK_VALID_LE_STATES, &hdev->quirks);
/* Setup MSFT Extension support */
btintel_set_msft_opcode(hdev,
--
2.25.1
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=731691
---Test result---
Test Summary:
CheckPatch PASS 0.68 seconds
GitLint PASS 0.34 seconds
SubjectPrefix PASS 0.12 seconds
BuildKernel PASS 31.69 seconds
CheckAllWarning PASS 34.44 seconds
CheckSparse PASS 39.17 seconds
CheckSmatch PASS 107.40 seconds
BuildKernel32 PASS 30.98 seconds
TestRunnerSetup PASS 426.98 seconds
TestRunner_l2cap-tester PASS 17.22 seconds
TestRunner_iso-tester PASS 17.53 seconds
TestRunner_bnep-tester PASS 5.71 seconds
TestRunner_mgmt-tester PASS 113.56 seconds
TestRunner_rfcomm-tester PASS 9.17 seconds
TestRunner_sco-tester PASS 8.44 seconds
TestRunner_ioctl-tester PASS 9.95 seconds
TestRunner_mesh-tester PASS 7.23 seconds
TestRunner_smp-tester PASS 8.25 seconds
TestRunner_userchan-tester PASS 6.07 seconds
IncrementalBuild PASS 28.88 seconds
---
Regards,
Linux Bluetooth
Dear Chethan,
Thank you for your patch. There is a small typo in the summary/title:
s/form/from/
Am 20.03.23 um 07:18 schrieb Chethan T N:
> This patch shall enable the LE States quirks by default on all
s/shall enable/enables/
> Intel controller from Solar products on wards.
onwards
Where is it documented, to enable that quirk for all?
> Signed-off-by: Chethan T N <[email protected]>
> ---
> drivers/bluetooth/btintel.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/bluetooth/btintel.c b/drivers/bluetooth/btintel.c
> index af774688f1c0..7a6dc05553f1 100644
> --- a/drivers/bluetooth/btintel.c
> +++ b/drivers/bluetooth/btintel.c
> @@ -2684,9 +2684,8 @@ static int btintel_setup_combined(struct hci_dev *hdev)
> */
> set_bit(HCI_QUIRK_WIDEBAND_SPEECH_SUPPORTED, &hdev->quirks);
>
> - /* Valid LE States quirk for GfP */
> - if (INTEL_HW_VARIANT(ver_tlv.cnvi_bt) == 0x18)
> - set_bit(HCI_QUIRK_VALID_LE_STATES, &hdev->quirks);
> + /* Apply LE States quirk from solar onwards */
> + set_bit(HCI_QUIRK_VALID_LE_STATES, &hdev->quirks);
From the diff it is unclear, if Solar is the first “device”. So I’d be
nice if you elaborated in the commit message.
>
> /* Setup MSFT Extension support */
> btintel_set_msft_opcode(hdev,
Kind regards,
Paul
Thanks for the feedback, will send the updated patch.
> -----Original Message-----
> From: Paul Menzel <[email protected]>
> Sent: Monday, March 20, 2023 6:40 PM
> To: Tumkur Narayan, Chethan <[email protected]>
> Cc: Srivatsa, Ravishankar <[email protected]>; K, Kiran
> <[email protected]>; [email protected]
> Subject: Re: [PATCH] Bluetooth: btintel: Fix: Add LE States quirk form Solar
> onwards
>
> Dear Chethan,
>
>
> Thank you for your patch. There is a small typo in the summary/title:
> s/form/from/
>
> Am 20.03.23 um 07:18 schrieb Chethan T N:
> > This patch shall enable the LE States quirks by default on all
>
> s/shall enable/enables/
>
> > Intel controller from Solar products on wards.
>
> onwards
>
> Where is it documented, to enable that quirk for all?
>
> > Signed-off-by: Chethan T N <[email protected]>
> > ---
> > drivers/bluetooth/btintel.c | 5 ++---
> > 1 file changed, 2 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/bluetooth/btintel.c b/drivers/bluetooth/btintel.c
> > index af774688f1c0..7a6dc05553f1 100644
> > --- a/drivers/bluetooth/btintel.c
> > +++ b/drivers/bluetooth/btintel.c
> > @@ -2684,9 +2684,8 @@ static int btintel_setup_combined(struct hci_dev
> *hdev)
> > */
> > set_bit(HCI_QUIRK_WIDEBAND_SPEECH_SUPPORTED,
> &hdev->quirks);
> >
> > - /* Valid LE States quirk for GfP */
> > - if (INTEL_HW_VARIANT(ver_tlv.cnvi_bt) == 0x18)
> > - set_bit(HCI_QUIRK_VALID_LE_STATES, &hdev-
> >quirks);
> > + /* Apply LE States quirk from solar onwards */
> > + set_bit(HCI_QUIRK_VALID_LE_STATES, &hdev->quirks);
>
> From the diff it is unclear, if Solar is the first “device”. So I’d be nice if you
> elaborated in the commit message.
>
> >
> > /* Setup MSFT Extension support */
> > btintel_set_msft_opcode(hdev,
>
>
> Kind regards,
>
> Paul
Hi Paul,
> -----Original Message-----
> From: Tumkur Narayan, Chethan
> Sent: Tuesday, March 21, 2023 8:59 AM
> To: Paul Menzel <[email protected]>
> Cc: Srivatsa, Ravishankar <[email protected]>; K, Kiran
> <[email protected]>; [email protected]
> Subject: RE: [PATCH] Bluetooth: btintel: Fix: Add LE States quirk form Solar
> onwards
>
> Thanks for the feedback, will send the updated patch.
>
> > -----Original Message-----
> > From: Paul Menzel <[email protected]>
> > Sent: Monday, March 20, 2023 6:40 PM
> > To: Tumkur Narayan, Chethan <[email protected]>
> > Cc: Srivatsa, Ravishankar <[email protected]>; K, Kiran
> > <[email protected]>; [email protected]
> > Subject: Re: [PATCH] Bluetooth: btintel: Fix: Add LE States quirk form
> > Solar onwards
> >
> > Dear Chethan,
> >
> >
> > Thank you for your patch. There is a small typo in the summary/title:
> > s/form/from/
> >
> > Am 20.03.23 um 07:18 schrieb Chethan T N:
> > > This patch shall enable the LE States quirks by default on all
> >
> > s/shall enable/enables/
ACK.
> >
> > > Intel controller from Solar products on wards.
> >
> > onwards
ACK.
> >
> > Where is it documented, to enable that quirk for all?
Based controller support the quick shall be added. Currently the quick was only applied for GarfieldPeak(GfP) however it is supported on all Intel controller.
> >
> > > Signed-off-by: Chethan T N <[email protected]>
> > > ---
> > > drivers/bluetooth/btintel.c | 5 ++---
> > > 1 file changed, 2 insertions(+), 3 deletions(-)
> > >
> > > diff --git a/drivers/bluetooth/btintel.c
> > > b/drivers/bluetooth/btintel.c index af774688f1c0..7a6dc05553f1
> > > 100644
> > > --- a/drivers/bluetooth/btintel.c
> > > +++ b/drivers/bluetooth/btintel.c
> > > @@ -2684,9 +2684,8 @@ static int btintel_setup_combined(struct
> > > hci_dev
> > *hdev)
> > > */
> > > set_bit(HCI_QUIRK_WIDEBAND_SPEECH_SUPPORTED,
> > &hdev->quirks);
> > >
> > > - /* Valid LE States quirk for GfP */
> > > - if (INTEL_HW_VARIANT(ver_tlv.cnvi_bt) == 0x18)
> > > - set_bit(HCI_QUIRK_VALID_LE_STATES, &hdev-
> > >quirks);
> > > + /* Apply LE States quirk from solar onwards */
> > > + set_bit(HCI_QUIRK_VALID_LE_STATES, &hdev->quirks);
> >
> > From the diff it is unclear, if Solar is the first “device”. So I’d
> > be nice if you elaborated in the commit message.
> >
> > >
> > > /* Setup MSFT Extension support */
> > > btintel_set_msft_opcode(hdev,
> >
> >
> > Kind regards,
> >
> > Paul
Thanks
Chethan
Hello:
This patch was applied to bluetooth/bluetooth-next.git (master)
by Luiz Augusto von Dentz <[email protected]>:
On Mon, 20 Mar 2023 11:48:13 +0530 you wrote:
> This patch shall enable the LE States quirks by default on all
> Intel controller from Solar products on wards.
>
> Signed-off-by: Chethan T N <[email protected]>
> ---
> drivers/bluetooth/btintel.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
Here is the summary with links:
- Bluetooth: btintel: Fix: Add LE States quirk form Solar onwards
https://git.kernel.org/bluetooth/bluetooth-next/c/5b23f8375a36
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html