2023-04-20 10:05:38

by Guiting Shen

Subject: [PATCH BlueZ v5] obexd: AuthorizePush: Support to return folder name for file storage

The obex agent usually returns the full path by getting the default
folder and filename from the Filename property of the transfer object
which is not convenient.

The patch helps that the obex agent can return the folder name suffixed
with '/' or new full path or even null which will use the default name
if new_name is NULL and the default folder if the new_folder is NULL in
opp_chkput().
---
doc/obex-agent-api.txt | 9 +++++----
obexd/src/manager.c | 7 +++++--
2 files changed, 10 insertions(+), 6 deletions(-)

diff --git a/doc/obex-agent-api.txt b/doc/obex-agent-api.txt
index 3923da6df..7c720927d 100644
--- a/doc/obex-agent-api.txt
+++ b/doc/obex-agent-api.txt
@@ -46,10 +46,11 @@ Methods void Release()
This method gets called when the service daemon
needs to accept/reject a Bluetooth object push request.

- Returns the full path (including the filename) where
- the object shall be stored. The tranfer object will
- contain a Filename property that contains the default
- location and name that can be returned.
+ Returns the full path (including the filename) or the
+ folder name suffixed with '/' where the object shall
+ be stored. The transfer object will contain a Filename
+ property that contains the default location and name
+ that can be returned.

Possible errors: org.bluez.obex.Error.Rejected
org.bluez.obex.Error.Canceled
diff --git a/obexd/src/manager.c b/obexd/src/manager.c
index 849928603..2bb985b96 100644
--- a/obexd/src/manager.c
+++ b/obexd/src/manager.c
@@ -651,7 +651,10 @@ static void agent_reply(DBusPendingCall *call, void *user_data)
agent->new_name = g_strdup(name);
agent->new_folder = NULL;
} else {
- agent->new_name = g_strdup(slash + 1);
+ if (strlen(slash) == 1)
+ agent->new_name = NULL;
+ else
+ agent->new_name = g_strdup(slash + 1);
agent->new_folder = g_strndup(name, slash - name);
}
}
@@ -722,7 +725,7 @@ int manager_request_authorization(struct obex_transfer *transfer,

dbus_pending_call_unref(call);

- if (!agent || !agent->new_name || agent->auth_reject)
+ if (!agent || agent->auth_reject)
return -EPERM;

*new_folder = agent->new_folder;
--
2.34.1

2023-04-20 11:23:28

by bluez.test.bot

Subject: RE: [BlueZ,v5] obexd: AuthorizePush: Support to return folder name for file storage

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=741650

---Test result---

Test Summary:
CheckPatch PASS 0.40 seconds
GitLint PASS 0.28 seconds
BuildEll PASS 26.38 seconds
BluezMake PASS 757.47 seconds
MakeCheck PASS 10.92 seconds
MakeDistcheck PASS 149.95 seconds
CheckValgrind PASS 240.66 seconds
CheckSmatch PASS 324.94 seconds
bluezmakeextell PASS 96.89 seconds
IncrementalBuild PASS 611.16 seconds
ScanBuild PASS 981.95 seconds



---
Regards,
Linux Bluetooth

2023-04-20 23:23:27

by patchwork-bot+bluetooth

Subject: Re: [PATCH BlueZ v5] obexd: AuthorizePush: Support to return folder name for file storage

Hello:

This patch was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <[email protected]>:

On Thu, 20 Apr 2023 17:55:57 +0800 you wrote:
> The obex agent usually returns the full path by getting the default
> folder and filename from the Filename property of the transfer object
> which is not convenient.
>
> The patch helps that the obex agent can return the folder name suffixed
> with '/' or new full path or even null which will use the default name
> if new_name is NULL and the default folder if the new_folder is NULL in
> opp_chkput().
>
> [...]

Here is the summary with links:
- [BlueZ,v5] obexd: AuthorizePush: Support to return folder name for file storage
https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=d36160459404

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html