LinuxLists.cc - [PATCH 1/1] Bluetooth: btrtl: Add missing MODULE

2023-05-04 21:33:14

Subject: [PATCH 1/1] Bluetooth: btrtl: Add missing MODULE_FIRMWARE declarations.

Add missing MODULE_FIRMWARE declarations for firmware referenced in
btrtl.c.

Signed-off-by: Dan Gora <[email protected]>
---
drivers/bluetooth/btrtl.c | 18 ++++++++++++++++--
1 file changed, 16 insertions(+), 2 deletions(-)

diff --git a/drivers/bluetooth/btrtl.c b/drivers/bluetooth/btrtl.c
index 2915c82d719d..d978e7cea873 100644
--- a/drivers/bluetooth/btrtl.c
+++ b/drivers/bluetooth/btrtl.c
@@ -1367,14 +1367,30 @@ MODULE_FIRMWARE("rtl_bt/rtl8723cs_vf_fw.bin");
MODULE_FIRMWARE("rtl_bt/rtl8723cs_vf_config.bin");
MODULE_FIRMWARE("rtl_bt/rtl8723cs_xx_fw.bin");
MODULE_FIRMWARE("rtl_bt/rtl8723cs_xx_config.bin");
+MODULE_FIRMWARE("rtl_bt/rtl8723d_fw.bin");
+MODULE_FIRMWARE("rtl_bt/rtl8723d_config.bin");
MODULE_FIRMWARE("rtl_bt/rtl8723ds_fw.bin");
MODULE_FIRMWARE("rtl_bt/rtl8723ds_config.bin");
MODULE_FIRMWARE("rtl_bt/rtl8761a_fw.bin");
MODULE_FIRMWARE("rtl_bt/rtl8761a_config.bin");
+MODULE_FIRMWARE("rtl_bt/rtl8761b_fw.bin");
+MODULE_FIRMWARE("rtl_bt/rtl8761b_config.bin");
+MODULE_FIRMWARE("rtl_bt/rtl8761bu_fw.bin");
+MODULE_FIRMWARE("rtl_bt/rtl8761bu_config.bin");
MODULE_FIRMWARE("rtl_bt/rtl8821a_fw.bin");
MODULE_FIRMWARE("rtl_bt/rtl8821a_config.bin");
+MODULE_FIRMWARE("rtl_bt/rtl8821c_fw.bin");
+MODULE_FIRMWARE("rtl_bt/rtl8821c_config.bin");
+MODULE_FIRMWARE("rtl_bt/rtl8821cs_fw.bin");
+MODULE_FIRMWARE("rtl_bt/rtl8821cs_config.bin");
MODULE_FIRMWARE("rtl_bt/rtl8822b_fw.bin");
MODULE_FIRMWARE("rtl_bt/rtl8822b_config.bin");
+MODULE_FIRMWARE("rtl_bt/rtl8822cs_fw.bin");
+MODULE_FIRMWARE("rtl_bt/rtl8822cs_config.bin");
+MODULE_FIRMWARE("rtl_bt/rtl8822cu_fw.bin");
+MODULE_FIRMWARE("rtl_bt/rtl8822cu_config.bin");
+MODULE_FIRMWARE("rtl_bt/rtl8851bu_fw.bin");
+MODULE_FIRMWARE("rtl_bt/rtl8851bu_config.bin");
MODULE_FIRMWARE("rtl_bt/rtl8852au_fw.bin");
MODULE_FIRMWARE("rtl_bt/rtl8852au_config.bin");
MODULE_FIRMWARE("rtl_bt/rtl8852bs_fw.bin");
@@ -1383,5 +1399,3 @@ MODULE_FIRMWARE("rtl_bt/rtl8852bu_fw.bin");
MODULE_FIRMWARE("rtl_bt/rtl8852bu_config.bin");
MODULE_FIRMWARE("rtl_bt/rtl8852cu_fw.bin");
MODULE_FIRMWARE("rtl_bt/rtl8852cu_config.bin");
-MODULE_FIRMWARE("rtl_bt/rtl8851bu_fw.bin");
-MODULE_FIRMWARE("rtl_bt/rtl8851bu_config.bin");
--
2.35.1.102.g2b9c120970

2023-05-04 22:02:30

by bluez.test.bot

[permalink] [raw]

Subject: RE: [1/1] Bluetooth: btrtl: Add missing MODULE_FIRMWARE declarations.

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=745113

---Test result---

Test Summary:
CheckPatch PASS 0.62 seconds
GitLint FAIL 0.54 seconds
SubjectPrefix PASS 0.10 seconds
BuildKernel PASS 32.49 seconds
CheckAllWarning PASS 35.43 seconds
CheckSparse PASS 40.11 seconds
CheckSmatch PASS 108.90 seconds
BuildKernel32 PASS 31.32 seconds
TestRunnerSetup PASS 445.68 seconds
TestRunner_l2cap-tester PASS 17.26 seconds
TestRunner_iso-tester PASS 21.37 seconds
TestRunner_bnep-tester PASS 5.61 seconds
TestRunner_mgmt-tester PASS 117.27 seconds
TestRunner_rfcomm-tester PASS 9.05 seconds
TestRunner_sco-tester PASS 8.30 seconds
TestRunner_ioctl-tester PASS 9.74 seconds
TestRunner_mesh-tester PASS 7.15 seconds
TestRunner_smp-tester PASS 8.16 seconds
TestRunner_userchan-tester PASS 5.91 seconds
IncrementalBuild PASS 29.61 seconds

Details
##############################
Test: GitLint - FAIL
Desc: Run gitlint
Output:
[1/1] Bluetooth: btrtl: Add missing MODULE_FIRMWARE declarations.

WARNING: I3 - ignore-body-lines: gitlint will be switching from using Python regex 'match' (match beginning) to 'search' (match anywhere) semantics. Please review your ignore-body-lines.regex option accordingly. To remove this warning, set general.regex-style-search=True. More details: https://jorisroovers.github.io/gitlint/configuration/#regex-style-search
1: T3 Title has trailing punctuation (.): "[1/1] Bluetooth: btrtl: Add missing MODULE_FIRMWARE declarations."

---
Regards,
Linux Bluetooth

2023-05-09 19:58:28

by Dan Gora

[permalink] [raw]

Subject: [PATCH v2 1/1] Bluetooth: btusb: Add device 6655:8771 to device tables

This device is an Inspire branded BT 5.1 USB dongle with a
Realtek RTL8761BU chip using the "Best Buy China" vendor ID.

The device table is as follows:

T: Bus=01 Lev=01 Prnt=02 Port=09 Cnt=01 Dev#= 7 Spd=12 MxCh= 0
D: Ver= 1.10 Cls=e0(wlcon) Sub=01 Prot=01 MxPS=64 #Cfgs= 1
P: Vendor=6655 ProdID=8771 Rev=02.00
S: Manufacturer=Realtek
S: Product=Bluetooth Radio
S: SerialNumber=00E04C239987
C: #Ifs= 2 Cfg#= 1 Atr=e0 MxPwr=500mA
I: If#= 0 Alt= 0 #EPs= 3 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
E: Ad=02(O) Atr=02(Bulk) MxPS= 64 Ivl=0ms
E: Ad=81(I) Atr=03(Int.) MxPS= 16 Ivl=1ms
E: Ad=82(I) Atr=02(Bulk) MxPS= 64 Ivl=0ms
I: If#= 1 Alt= 0 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
E: Ad=03(O) Atr=01(Isoc) MxPS= 0 Ivl=1ms
E: Ad=83(I) Atr=01(Isoc) MxPS= 0 Ivl=1ms

Signed-off-by: Dan Gora <[email protected]>
---
drivers/bluetooth/btusb.c | 2 ++
1 file changed, 2 insertions(+)

diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
index 2a8e2bb038f5..0b0a02cf0d4a 100644
--- a/drivers/bluetooth/btusb.c
+++ b/drivers/bluetooth/btusb.c
@@ -655,6 +655,8 @@ static const struct usb_device_id blacklist_table[] = {
BTUSB_WIDEBAND_SPEECH },
{ USB_DEVICE(0x0bda, 0x8771), .driver_info = BTUSB_REALTEK |
BTUSB_WIDEBAND_SPEECH },
+ { USB_DEVICE(0x6655, 0x8771), .driver_info = BTUSB_REALTEK |
+ BTUSB_WIDEBAND_SPEECH },
{ USB_DEVICE(0x7392, 0xc611), .driver_info = BTUSB_REALTEK |
BTUSB_WIDEBAND_SPEECH },
{ USB_DEVICE(0x2b89, 0x8761), .driver_info = BTUSB_REALTEK |
--
2.35.1.102.g2b9c120970

2023-05-09 19:59:19

by Dan Gora

[permalink] [raw]

Subject: [PATCH v2 1/1] Bluetooth: btrtl: Add missing MODULE_FIRMWARE declarations

2023-05-09 20:44:03

by bluez.test.bot

[permalink] [raw]

Subject: RE: [v2,1/1] Bluetooth: btusb: Add device 6655:8771 to device tables

2023-05-09 20:46:28

by bluez.test.bot

[permalink] [raw]

Subject: RE: [v2,1/1] Bluetooth: btrtl: Add missing MODULE_FIRMWARE declarations

2023-05-12 20:42:26

by patchwork-bot+bluetooth

[permalink] [raw]

Subject: Re: [PATCH v2 1/1] Bluetooth: btrtl: Add missing MODULE_FIRMWARE declarations

Hello:

This patch was applied to bluetooth/bluetooth-next.git (master)
by Luiz Augusto von Dentz <[email protected]>:

On Tue, 9 May 2023 12:51:19 -0700 you wrote:
> Add missing MODULE_FIRMWARE declarations for firmware referenced in
> btrtl.c.
>
> Signed-off-by: Dan Gora <[email protected]>
> ---
> drivers/bluetooth/btrtl.c | 18 ++++++++++++++++--
> 1 file changed, 16 insertions(+), 2 deletions(-)

Here is the summary with links:
- [v2,1/1] Bluetooth: btrtl: Add missing MODULE_FIRMWARE declarations
https://git.kernel.org/bluetooth/bluetooth-next/c/5a0830d69a77

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

2023-05-12 20:42:29

by patchwork-bot+bluetooth

[permalink] [raw]

Subject: Re: [PATCH v2 1/1] Bluetooth: btusb: Add device 6655:8771 to device tables

Hello:

This patch was applied to bluetooth/bluetooth-next.git (master)
by Luiz Augusto von Dentz <[email protected]>:

On Tue, 9 May 2023 12:45:24 -0700 you wrote:
> This device is an Inspire branded BT 5.1 USB dongle with a
> Realtek RTL8761BU chip using the "Best Buy China" vendor ID.
>
> The device table is as follows:
>
> T: Bus=01 Lev=01 Prnt=02 Port=09 Cnt=01 Dev#= 7 Spd=12 MxCh= 0
> D: Ver= 1.10 Cls=e0(wlcon) Sub=01 Prot=01 MxPS=64 #Cfgs= 1
> P: Vendor=6655 ProdID=8771 Rev=02.00
> S: Manufacturer=Realtek
> S: Product=Bluetooth Radio
> S: SerialNumber=00E04C239987
> C: #Ifs= 2 Cfg#= 1 Atr=e0 MxPwr=500mA
> I: If#= 0 Alt= 0 #EPs= 3 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
> E: Ad=02(O) Atr=02(Bulk) MxPS= 64 Ivl=0ms
> E: Ad=81(I) Atr=03(Int.) MxPS= 16 Ivl=1ms
> E: Ad=82(I) Atr=02(Bulk) MxPS= 64 Ivl=0ms
> I: If#= 1 Alt= 0 #EPs= 2 Cls=e0(wlcon) Sub=01 Prot=01 Driver=btusb
> E: Ad=03(O) Atr=01(Isoc) MxPS= 0 Ivl=1ms
> E: Ad=83(I) Atr=01(Isoc) MxPS= 0 Ivl=1ms
>
> [...]

Here is the summary with links:
- [v2,1/1] Bluetooth: btusb: Add device 6655:8771 to device tables
https://git.kernel.org/bluetooth/bluetooth-next/c/376b10586124

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html

2023-05-12 20:42:57

by patchwork-bot+bluetooth

[permalink] [raw]

Subject: Re: [PATCH 1/1] Bluetooth: btrtl: Add missing MODULE_FIRMWARE declarations.

Hello:

This patch was applied to bluetooth/bluetooth-next.git (master)
by Luiz Augusto von Dentz <[email protected]>:

On Thu, 4 May 2023 14:28:44 -0700 you wrote:
> Add missing MODULE_FIRMWARE declarations for firmware referenced in
> btrtl.c.
>
> Signed-off-by: Dan Gora <[email protected]>
> ---
> drivers/bluetooth/btrtl.c | 18 ++++++++++++++++--
> 1 file changed, 16 insertions(+), 2 deletions(-)

Here is the summary with links:
- [1/1] Bluetooth: btrtl: Add missing MODULE_FIRMWARE declarations.
https://git.kernel.org/bluetooth/bluetooth-next/c/5a0830d69a77

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html