2019-03-05 21:04:32

by Matthias Kaehlcke

Subject: [PATCH] Bluetooth: hci_qca: Remove redundant initializations to zero

The qca_data structure is allocated with kzalloc() and hence
zero-initialized. Remove a bunch of unnecessary explicit
initializations of struct members to zero.

Signed-off-by: Matthias Kaehlcke <[email protected]>
---
drivers/bluetooth/hci_qca.c | 19 -------------------
1 file changed, 19 deletions(-)

diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c
index 237aea34b69f1..8dccbb934e384 100644
--- a/drivers/bluetooth/hci_qca.c
+++ b/drivers/bluetooth/hci_qca.c
@@ -480,26 +480,7 @@ static int qca_open(struct hci_uart *hu)
qca->tx_ibs_state = HCI_IBS_TX_ASLEEP;
qca->rx_ibs_state = HCI_IBS_RX_ASLEEP;

- /* clocks actually on, but we start votes off */
- qca->tx_vote = false;
- qca->rx_vote = false;
- qca->flags = 0;
-
- qca->ibs_sent_wacks = 0;
- qca->ibs_sent_slps = 0;
- qca->ibs_sent_wakes = 0;
- qca->ibs_recv_wacks = 0;
- qca->ibs_recv_slps = 0;
- qca->ibs_recv_wakes = 0;
qca->vote_last_jif = jiffies;
- qca->vote_on_ms = 0;
- qca->vote_off_ms = 0;
- qca->votes_on = 0;
- qca->votes_off = 0;
- qca->tx_votes_on = 0;
- qca->tx_votes_off = 0;
- qca->rx_votes_on = 0;
- qca->rx_votes_off = 0;

hu->priv = qca;

--
2.21.0.352.gf09ad66450-goog

2019-03-06 05:44:40

by Balakrishna Godavarthi

Subject: Re: [PATCH] Bluetooth: hci_qca: Remove redundant initializations to zero

On 2019-03-06 02:34, Matthias Kaehlcke wrote:
> The qca_data structure is allocated with kzalloc() and hence
> zero-initialized. Remove a bunch of unnecessary explicit
> initializations of struct members to zero.
>
> Signed-off-by: Matthias Kaehlcke <[email protected]>
> ---
> drivers/bluetooth/hci_qca.c | 19 -------------------
> 1 file changed, 19 deletions(-)
>
> diff --git a/drivers/bluetooth/hci_qca.c b/drivers/bluetooth/hci_qca.c
> index 237aea34b69f1..8dccbb934e384 100644
> --- a/drivers/bluetooth/hci_qca.c
> +++ b/drivers/bluetooth/hci_qca.c
> @@ -480,26 +480,7 @@ static int qca_open(struct hci_uart *hu)
> qca->tx_ibs_state = HCI_IBS_TX_ASLEEP;
> qca->rx_ibs_state = HCI_IBS_RX_ASLEEP;
>
> - /* clocks actually on, but we start votes off */
> - qca->tx_vote = false;
> - qca->rx_vote = false;
> - qca->flags = 0;
> -
> - qca->ibs_sent_wacks = 0;
> - qca->ibs_sent_slps = 0;
> - qca->ibs_sent_wakes = 0;
> - qca->ibs_recv_wacks = 0;
> - qca->ibs_recv_slps = 0;
> - qca->ibs_recv_wakes = 0;
> qca->vote_last_jif = jiffies;
> - qca->vote_on_ms = 0;
> - qca->vote_off_ms = 0;
> - qca->votes_on = 0;
> - qca->votes_off = 0;
> - qca->tx_votes_on = 0;
> - qca->tx_votes_off = 0;
> - qca->rx_votes_on = 0;
> - qca->rx_votes_off = 0;
>
> hu->priv = qca;

Reviewed-by: Balakrishna Godavarthi <[email protected]>

--
Regards
Balakrishna.