2023-09-28 17:47:49

by Iulia Tanasescu

Subject: [PATCH BlueZ 1/1] iso-tester: Test bcast receiver with PA sync, no BIS

This tests that a broadcast receiver is able to successfully sync to the
PA transmitted by a source, without performing BIS sync also:

ISO Broadcaster Receiver Defer No BIS - Success

---
tools/iso-tester.c | 41 +++++++++++++++++++++++++++++++++++------
1 file changed, 35 insertions(+), 6 deletions(-)

diff --git a/tools/iso-tester.c b/tools/iso-tester.c
index 410da2c93..6d24c4c8c 100644
--- a/tools/iso-tester.c
+++ b/tools/iso-tester.c
@@ -411,6 +411,7 @@ struct iso_client_data {
uint8_t pkt_status;
const uint8_t *base;
size_t base_len;
+ bool bcast_defer_accept;
};

static void mgmt_debug(const char *str, void *user_data)
@@ -1141,6 +1142,16 @@ static const struct iso_client_data bcast_16_2_1_recv_defer = {
.recv = &send_16_2_1,
.bcast = true,
.server = true,
+ .bcast_defer_accept = true,
+};
+
+static const struct iso_client_data bcast_16_2_1_recv_defer_no_bis = {
+ .qos = QOS_IN_16_2_1,
+ .expect_err = 0,
+ .defer = true,
+ .bcast = true,
+ .server = true,
+ .bcast_defer_accept = false,
};

static const struct iso_client_data bcast_ac_12 = {
@@ -2257,8 +2268,11 @@ static int listen_iso_sock(struct test_data *data)

bacpy(&addr->iso_bc->bc_bdaddr, (void *) dst);
addr->iso_bc->bc_bdaddr_type = BDADDR_LE_PUBLIC;
- addr->iso_bc->bc_num_bis = 1;
- addr->iso_bc->bc_bis[0] = 1;
+
+ if (!isodata->defer || isodata->bcast_defer_accept) {
+ addr->iso_bc->bc_num_bis = 1;
+ addr->iso_bc->bc_bis[0] = 1;
+ }

err = bind(sk, (struct sockaddr *) addr, sizeof(*addr) +
sizeof(*addr->iso_bc));
@@ -2420,9 +2434,21 @@ static gboolean iso_accept_cb(GIOChannel *io, GIOCondition cond,
return false;
}

- if (isodata->bcast && data->step > 1) {
- data->step--;
- goto connect;
+ if (isodata->bcast) {
+ if (data->step > 1)
+ data->step--;
+ else
+ data->step++;
+
+ iso_connect(io, cond, user_data);
+
+ if (!data->step)
+ return false;
+
+ if (!isodata->bcast_defer_accept) {
+ tester_test_passed();
+ return false;
+ }
}

if (!iso_defer_accept(data, io)) {
@@ -2444,7 +2470,6 @@ static gboolean iso_accept_cb(GIOChannel *io, GIOCondition cond,
}
}

-connect:
return iso_connect(io, cond, user_data);
}

@@ -3031,6 +3056,10 @@ int main(int argc, char *argv[])
&bcast_16_2_1_recv_defer,
setup_powered,
test_bcast_recv);
+ test_iso("ISO Broadcaster Receiver Defer No BIS - Success",
+ &bcast_16_2_1_recv_defer_no_bis,
+ setup_powered,
+ test_bcast_recv);

test_iso("ISO Broadcaster AC 12 - Success", &bcast_ac_12, setup_powered,
test_bcast);
--
2.39.2

2023-09-28 20:44:44

by bluez.test.bot

Subject: RE: iso-tester: Test bcast receiver with PA sync, no BIS

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=788549

---Test result---

Test Summary:
CheckPatch PASS 0.56 seconds
GitLint PASS 0.37 seconds
BuildEll PASS 28.84 seconds
BluezMake PASS 1018.78 seconds
MakeCheck PASS 12.87 seconds
MakeDistcheck PASS 163.72 seconds
CheckValgrind PASS 268.04 seconds
CheckSmatch PASS 357.48 seconds
bluezmakeextell PASS 109.25 seconds
IncrementalBuild PASS 856.21 seconds
ScanBuild PASS 1107.41 seconds



---
Regards,
Linux Bluetooth