2023-10-01 13:06:06

by Pauli Virtanen

Subject: [PATCH BlueZ 1/2] bap: use documented MediaEndpoint property names consistently

Use the documented name "MaximumLatency" for the MediaEndpoint QoS
Max_Transport_Latency field, in SelectProperties input parameters and
expected client MediaEndpoint properties.

Use the name "Locations" for SelectProperties supported locations input
parameter, to match the MediaEndpoint property name which indicates the
same thing.
---
profiles/audio/media.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/profiles/audio/media.c b/profiles/audio/media.c
index 8345487d7..85ece47c4 100644
--- a/profiles/audio/media.c
+++ b/profiles/audio/media.c
@@ -965,7 +965,7 @@ static int pac_select(struct bt_bap_pac *lpac, struct bt_bap_pac *rpac,

loc = bt_bap_pac_get_locations(rpac);
if (loc)
- g_dbus_dict_append_entry(&dict, "Location", DBUS_TYPE_UINT32,
+ g_dbus_dict_append_entry(&dict, "Locations", DBUS_TYPE_UINT32,
&loc);

if (metadata) {
@@ -983,8 +983,8 @@ static int pac_select(struct bt_bap_pac *lpac, struct bt_bap_pac *rpac,
g_dbus_dict_append_entry(&dict, "PHY", DBUS_TYPE_BYTE,
&qos->phy);

- g_dbus_dict_append_entry(&dict, "Latency", DBUS_TYPE_UINT16,
- &qos->latency);
+ g_dbus_dict_append_entry(&dict, "MaximumLatency",
+ DBUS_TYPE_UINT16, &qos->latency);

g_dbus_dict_append_entry(&dict, "MinimumDelay",
DBUS_TYPE_UINT32, &qos->pd_min);
@@ -2749,7 +2749,7 @@ static void app_register_endpoint(void *data, void *user_data)
dbus_message_iter_get_basic(&iter, &qos.phy);
}

- if (g_dbus_proxy_get_property(proxy, "Latency", &iter)) {
+ if (g_dbus_proxy_get_property(proxy, "MaximumLatency", &iter)) {
if (dbus_message_iter_get_arg_type(&iter) != DBUS_TYPE_UINT16)
goto fail;

--
2.41.0

2023-10-01 19:11:48

by bluez.test.bot

Subject: RE: [BlueZ,1/2] bap: use documented MediaEndpoint property names consistently

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=789114

---Test result---

Test Summary:
CheckPatch PASS 0.78 seconds
GitLint PASS 0.53 seconds
BuildEll PASS 32.11 seconds
BluezMake PASS 1135.00 seconds
MakeCheck PASS 12.92 seconds
MakeDistcheck PASS 189.54 seconds
CheckValgrind PASS 292.81 seconds
CheckSmatch PASS 404.20 seconds
bluezmakeextell PASS 123.05 seconds
IncrementalBuild PASS 1948.78 seconds
ScanBuild PASS 1355.02 seconds



---
Regards,
Linux Bluetooth