2023-11-28 15:33:28

by Luiz Augusto von Dentz

Subject: [PATCH BlueZ v1] isotest: Fix high-reliability QoS presets

From: Luiz Augusto von Dentz <[email protected]>

This changes the high-reliability QoS presets to be conformant to
BAP[1] specification:

Table 5.2: QoS configuration support setting requirements for the
Unicast Client and Unicast Server

[1] https://www.bluetooth.com/specifications/bap-1-0-1/

Fixes: https://github.com/bluez/bluez/issues/665
---
tools/isotest.c | 32 ++++++++++++++++----------------
1 file changed, 16 insertions(+), 16 deletions(-)

diff --git a/tools/isotest.c b/tools/isotest.c
index 2c682bc899fc..771d24b6d2a6 100644
--- a/tools/isotest.c
+++ b/tools/isotest.c
@@ -1073,22 +1073,22 @@ static struct qos_preset {
QOS_PRESET("48_5_1", false, 7500, 15, 117, 0x02, 5),
QOS_PRESET("44_6_1", false, 10000, 20, 155, 0x02, 5),
/* QoS Configuration settings for high reliability audio data */
- QOS_PRESET("8_1_2", true, 7500, 45, 26, 0x02, 41),
- QOS_PRESET("8_2_2", true, 10000, 60, 30, 0x02, 53),
- QOS_PRESET("16_1_2", true, 7500, 45, 30, 0x02, 41),
- QOS_PRESET("16_2_2", true, 10000, 60, 40, 0x02, 47),
- QOS_PRESET("24_1_2", true, 7500, 45, 45, 0x02, 35),
- QOS_PRESET("24_2_2", true, 10000, 60, 60, 0x02, 41),
- QOS_PRESET("32_1_2", true, 7500, 45, 60, 0x02, 29),
- QOS_PRESET("32_2_1", true, 10000, 60, 80, 0x02, 35),
- QOS_PRESET("44_1_2", false, 8163, 54, 98, 0x02, 23),
- QOS_PRESET("44_2_2", false, 10884, 71, 130, 0x02, 23),
- QOS_PRESET("48_1_2", false, 7500, 45, 75, 0x02, 23),
- QOS_PRESET("48_2_2", false, 10000, 60, 100, 0x02, 23),
- QOS_PRESET("48_3_2", false, 7500, 45, 90, 0x02, 23),
- QOS_PRESET("48_4_2", false, 10000, 60, 120, 0x02, 23),
- QOS_PRESET("48_5_2", false, 7500, 45, 117, 0x02, 23),
- QOS_PRESET("44_6_2", false, 10000, 60, 155, 0x02, 23),
+ QOS_PRESET("8_1_2", true, 7500, 75, 26, 0x02, 13),
+ QOS_PRESET("8_2_2", true, 10000, 95, 30, 0x02, 13),
+ QOS_PRESET("16_1_2", true, 7500, 75, 30, 0x02, 13),
+ QOS_PRESET("16_2_2", true, 10000, 95, 40, 0x02, 13),
+ QOS_PRESET("24_1_2", true, 7500, 75, 45, 0x02, 13),
+ QOS_PRESET("24_2_2", true, 10000, 95, 60, 0x02, 13),
+ QOS_PRESET("32_1_2", true, 7500, 75, 60, 0x02, 13),
+ QOS_PRESET("32_2_2", true, 10000, 95, 80, 0x02, 13),
+ QOS_PRESET("44_1_2", false, 8163, 80, 97, 0x02, 13),
+ QOS_PRESET("44_2_2", false, 10884, 85, 130, 0x02, 13),
+ QOS_PRESET("48_1_2", false, 7500, 75, 75, 0x02, 13),
+ QOS_PRESET("48_2_2", false, 10000, 95, 100, 0x02, 13),
+ QOS_PRESET("48_3_2", false, 7500, 75, 90, 0x02, 13),
+ QOS_PRESET("48_4_2", false, 10000, 100, 120, 0x02, 13),
+ QOS_PRESET("48_5_2", false, 7500, 75, 117, 0x02, 13),
+ QOS_PRESET("44_6_2", false, 10000, 100, 155, 0x02, 13),
/* QoS configuration support setting requirements for the UGG and UGT */
QOS_PRESET("16_1_gs", true, 7500, 15, 30, 0x02, 1),
QOS_PRESET("16_2_gs", true, 10000, 20, 40, 0x02, 1),
--
2.43.0

2023-11-28 17:04:40

by bluez.test.bot

Subject: RE: [BlueZ,v1] isotest: Fix high-reliability QoS presets

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=804917

---Test result---

Test Summary:
CheckPatch PASS 0.30 seconds
GitLint PASS 0.38 seconds
BuildEll PASS 23.88 seconds
BluezMake PASS 541.78 seconds
MakeCheck PASS 10.65 seconds
MakeDistcheck PASS 148.23 seconds
CheckValgrind PASS 208.38 seconds
CheckSmatch PASS 312.62 seconds
bluezmakeextell PASS 95.40 seconds
IncrementalBuild PASS 497.86 seconds
ScanBuild PASS 884.68 seconds



---
Regards,
Linux Bluetooth

2023-11-28 17:40:39

by patchwork-bot+bluetooth

Subject: Re: [PATCH BlueZ v1] isotest: Fix high-reliability QoS presets

Hello:

This patch was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <[email protected]>:

On Tue, 28 Nov 2023 10:33:03 -0500 you wrote:
> From: Luiz Augusto von Dentz <[email protected]>
>
> This changes the high-reliability QoS presets to be conformant to
> BAP[1] specification:
>
> Table 5.2: QoS configuration support setting requirements for the
> Unicast Client and Unicast Server
>
> [...]

Here is the summary with links:
- [BlueZ,v1] isotest: Fix high-reliability QoS presets
https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=ee04d309651c

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html