2023-12-05 02:42:03

by 15013537245

[permalink] [raw]
Subject: [PATCH] Bluetooth: hci_sync: fix BR/EDR wakeup bug

From: Clancy Shang <[email protected]>

when Bluetooth set the event mask and enter suspend, the controller
has hci mode change event comming,it cause controller can not enter
sleep mode. so it should to set the hci mode change event mask before
enter suspend

Signed-off-by: Clancy Shang <[email protected]>
---
net/bluetooth/hci_sync.c | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/net/bluetooth/hci_sync.c b/net/bluetooth/hci_sync.c
index a15ab0b874a9..a26a58cb2c38 100644
--- a/net/bluetooth/hci_sync.c
+++ b/net/bluetooth/hci_sync.c
@@ -3800,12 +3800,14 @@ static int hci_set_event_mask_sync(struct hci_dev *hdev)
if (lmp_bredr_capable(hdev)) {
events[4] |= 0x01; /* Flow Specification Complete */

- /* Don't set Disconnect Complete when suspended as that
- * would wakeup the host when disconnecting due to
- * suspend.
+ /* Don't set Disconnect Complete and mode change when
+ * suspended as that would wakeup the host when disconnecting
+ * due to suspend.
*/
- if (hdev->suspended)
+ if (hdev->suspended) {
events[0] &= 0xef;
+ events[2] &= 0xf7;
+ }
} else {
/* Use a different default for LE-only devices */
memset(events, 0, sizeof(events));
--
2.25.1



2023-12-05 03:33:32

by bluez.test.bot

[permalink] [raw]
Subject: RE: Bluetooth: hci_sync: fix BR/EDR wakeup bug

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=806868

---Test result---

Test Summary:
CheckPatch FAIL 0.91 seconds
GitLint PASS 0.34 seconds
SubjectPrefix PASS 0.13 seconds
BuildKernel PASS 27.54 seconds
CheckAllWarning PASS 29.97 seconds
CheckSparse PASS 35.47 seconds
CheckSmatch PASS 98.17 seconds
BuildKernel32 PASS 26.70 seconds
TestRunnerSetup PASS 413.42 seconds
TestRunner_l2cap-tester PASS 22.97 seconds
TestRunner_iso-tester PASS 44.84 seconds
TestRunner_bnep-tester PASS 7.02 seconds
TestRunner_mgmt-tester PASS 165.45 seconds
TestRunner_rfcomm-tester PASS 10.99 seconds
TestRunner_sco-tester PASS 14.56 seconds
TestRunner_ioctl-tester PASS 12.14 seconds
TestRunner_mesh-tester PASS 8.82 seconds
TestRunner_smp-tester PASS 9.89 seconds
TestRunner_userchan-tester PASS 7.45 seconds
IncrementalBuild PASS 25.74 seconds

Details
##############################
Test: CheckPatch - FAIL
Desc: Run checkpatch.pl script
Output:
Bluetooth: hci_sync: fix BR/EDR wakeup bug
WARNING: 'comming' may be misspelled - perhaps 'coming'?
#51:
has hci mode change event comming,it cause controller can not enter
^^^^^^^

total: 0 errors, 1 warnings, 0 checks, 18 lines checked

NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.

/github/workspace/src/src/13479332.patch has style problems, please review.

NOTE: Ignored message types: UNKNOWN_COMMIT_ID

NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.




---
Regards,
Linux Bluetooth