From: Clancy Shang <[email protected]>
when Bluetooth set the event mask and enter suspend, the controller
has hci mode change event comming,it cause controller can not enter
sleep mode. so it should to set the hci mode change event mask before
enter suspend
Signed-off-by: Clancy Shang <[email protected]>
---
net/bluetooth/hci_sync.c | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/net/bluetooth/hci_sync.c b/net/bluetooth/hci_sync.c
index a15ab0b874a9..a26a58cb2c38 100644
--- a/net/bluetooth/hci_sync.c
+++ b/net/bluetooth/hci_sync.c
@@ -3800,12 +3800,14 @@ static int hci_set_event_mask_sync(struct hci_dev *hdev)
if (lmp_bredr_capable(hdev)) {
events[4] |= 0x01; /* Flow Specification Complete */
- /* Don't set Disconnect Complete when suspended as that
- * would wakeup the host when disconnecting due to
- * suspend.
+ /* Don't set Disconnect Complete and mode change when
+ * suspended as that would wakeup the host when disconnecting
+ * due to suspend.
*/
- if (hdev->suspended)
+ if (hdev->suspended) {
events[0] &= 0xef;
+ events[2] &= 0xf7;
+ }
} else {
/* Use a different default for LE-only devices */
memset(events, 0, sizeof(events));
--
2.25.1
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=809975
---Test result---
Test Summary:
CheckPatch FAIL 0.96 seconds
GitLint PASS 0.33 seconds
SubjectPrefix PASS 0.13 seconds
BuildKernel PASS 28.56 seconds
CheckAllWarning PASS 29.75 seconds
CheckSparse PASS 34.91 seconds
CheckSmatch PASS 98.52 seconds
BuildKernel32 PASS 26.37 seconds
TestRunnerSetup PASS 413.84 seconds
TestRunner_l2cap-tester PASS 22.71 seconds
TestRunner_iso-tester PASS 48.05 seconds
TestRunner_bnep-tester PASS 6.95 seconds
TestRunner_mgmt-tester PASS 160.64 seconds
TestRunner_rfcomm-tester PASS 10.93 seconds
TestRunner_sco-tester PASS 14.39 seconds
TestRunner_ioctl-tester PASS 11.79 seconds
TestRunner_mesh-tester PASS 9.62 seconds
TestRunner_smp-tester PASS 9.78 seconds
TestRunner_userchan-tester PASS 7.24 seconds
IncrementalBuild PASS 25.36 seconds
Details
##############################
Test: CheckPatch - FAIL
Desc: Run checkpatch.pl script
Output:
Bluetooth: hci_sync: fix BR/EDR wakeup bug
WARNING: 'comming' may be misspelled - perhaps 'coming'?
#51:
has hci mode change event comming,it cause controller can not enter
^^^^^^^
total: 0 errors, 1 warnings, 0 checks, 18 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
/github/workspace/src/src/13492648.patch has style problems, please review.
NOTE: Ignored message types: UNKNOWN_COMMIT_ID
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
---
Regards,
Linux Bluetooth
Hello:
This patch was applied to bluetooth/bluetooth-next.git (master)
by Luiz Augusto von Dentz <[email protected]>:
On Mon, 18 Dec 2023 18:24:17 +0800 you wrote:
> From: clancy shang <[email protected]>
>
> when Bluetooth set the event mask and enter suspend, the controller
> has hci mode change event coming, it cause controller can not enter
> sleep mode. so it should to set the hci mode change event mask before
> enter suspend.
>
> [...]
Here is the summary with links:
- Bluetooth: hci_sync: fix BR/EDR wakeup bug
https://git.kernel.org/bluetooth/bluetooth-next/c/1e961bd261a6
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html