From: Luiz Augusto von Dentz <[email protected]>
While waiting for hci_dev_lock the hci_conn object may be cleanup
causing the following trace:
BUG: KASAN: slab-use-after-free in hci_connect_le_scan_cleanup+0x29/0x350
Read of size 8 at addr ffff888001a50a30 by task kworker/u3:1/111
CPU: 0 PID: 111 Comm: kworker/u3:1 Not tainted
6.8.0-rc2-00701-g8179b15ab3fd-dirty #6418
Hardware name: QEMU Standard PC (Q35 + ICH9, 2009), BIOS 1.16.2-1.fc38
04/01/2014
Workqueue: hci0 hci_cmd_sync_work
Call Trace:
<TASK>
dump_stack_lvl+0x21/0x70
print_report+0xce/0x620
? preempt_count_sub+0x13/0xc0
? __virt_addr_valid+0x15f/0x310
? hci_connect_le_scan_cleanup+0x29/0x350
kasan_report+0xdf/0x110
? hci_connect_le_scan_cleanup+0x29/0x350
hci_connect_le_scan_cleanup+0x29/0x350
create_le_conn_complete+0x25c/0x2c0
Signed-off-by: Luiz Augusto von Dentz <[email protected]>
---
net/bluetooth/hci_sync.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/net/bluetooth/hci_sync.c b/net/bluetooth/hci_sync.c
index 7306020ccda3..669099cf9b1a 100644
--- a/net/bluetooth/hci_sync.c
+++ b/net/bluetooth/hci_sync.c
@@ -6708,6 +6708,9 @@ static void create_le_conn_complete(struct hci_dev *hdev, void *data, int err)
hci_dev_lock(hdev);
+ if (!hci_conn_valid(hdev, conn))
+ goto done;
+
if (!err) {
hci_connect_le_scan_cleanup(conn, 0x00);
goto done;
--
2.43.0
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=827947
---Test result---
Test Summary:
CheckPatch PASS 0.65 seconds
GitLint PASS 0.32 seconds
SubjectPrefix PASS 0.12 seconds
BuildKernel PASS 27.92 seconds
CheckAllWarning PASS 30.94 seconds
CheckSparse PASS 36.81 seconds
CheckSmatch PASS 98.06 seconds
BuildKernel32 PASS 27.36 seconds
TestRunnerSetup PASS 499.61 seconds
TestRunner_l2cap-tester PASS 18.24 seconds
TestRunner_iso-tester PASS 34.49 seconds
TestRunner_bnep-tester PASS 4.87 seconds
TestRunner_mgmt-tester FAIL 172.03 seconds
TestRunner_rfcomm-tester PASS 7.49 seconds
TestRunner_sco-tester PASS 15.01 seconds
TestRunner_ioctl-tester PASS 7.84 seconds
TestRunner_mesh-tester PASS 6.03 seconds
TestRunner_smp-tester PASS 9.00 seconds
TestRunner_userchan-tester PASS 5.06 seconds
IncrementalBuild PASS 26.14 seconds
Details
##############################
Test: TestRunner_mgmt-tester - FAIL
Desc: Run mgmt-tester with test-runner
Output:
Total: 492, Passed: 488 (99.2%), Failed: 3, Not Run: 1
Failed Test Cases
LL Privacy - Add Device 5 (2 Devices to RL) Failed 0.117 seconds
LL Privacy - Add Device 6 (RL is full) Failed 0.143 seconds
LL Privacy - Remove Device 1 (Remove from AL) Timed out 2.207 seconds
---
Regards,
Linux Bluetooth
Hello:
This patch was applied to bluetooth/bluetooth-next.git (master)
by Luiz Augusto von Dentz <[email protected]>:
On Tue, 20 Feb 2024 13:13:19 -0500 you wrote:
> From: Luiz Augusto von Dentz <[email protected]>
>
> While waiting for hci_dev_lock the hci_conn object may be cleanup
> causing the following trace:
>
> BUG: KASAN: slab-use-after-free in hci_connect_le_scan_cleanup+0x29/0x350
> Read of size 8 at addr ffff888001a50a30 by task kworker/u3:1/111
>
> [...]
Here is the summary with links:
- [v1] Bluetooth: hci_sync: Fix UAF on create_le_conn_complete
https://git.kernel.org/bluetooth/bluetooth-next/c/25956d989c60
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html