From: Luiz Augusto von Dentz <[email protected]>
Although their name matches unicast and broadcast are not actually the
same when it comes to RTN and Max Latency, so this splits their settings
into 2 presets tables and fix the values for broadcast.
---
client/player.c | 115 +++++++++++++++++++++++++++++++++++++++++++++---
1 file changed, 110 insertions(+), 5 deletions(-)
diff --git a/client/player.c b/client/player.c
index a40bf66e3967..cb771447bf4b 100644
--- a/client/player.c
+++ b/client/player.c
@@ -1403,7 +1403,7 @@ static struct codec_preset sbc_presets[] = {
.target_latency = 0x03, \
}
-static struct codec_preset lc3_presets[] = {
+static struct codec_preset lc3_ucast_presets[] = {
/* Table 4.43: QoS configuration support setting requirements */
LC3_PRESET("8_1_1",
LC3_PRESET_8KHZ(LC3_CONFIG_DURATION_7_5, 26u),
@@ -1565,6 +1565,111 @@ static struct codec_preset lc3_presets[] = {
LC3_10_UNFRAMED(2 * 120u, 1u, 20u, 10000u)),
};
+static struct codec_preset lc3_bcast_presets[] = {
+ /* Table 6.4: Broadcast Audio Stream configuration support requirements
+ * for the Broadcast Source and Broadcast Sink
+ */
+ LC3_PRESET("8_1_1",
+ LC3_PRESET_8KHZ(LC3_CONFIG_DURATION_7_5, 26u),
+ LC3_7_5_UNFRAMED(26u, 2u, 8u, 40000u)),
+ LC3_PRESET("8_2_1",
+ LC3_PRESET_8KHZ(LC3_CONFIG_DURATION_10, 30u),
+ LC3_10_UNFRAMED(30u, 2u, 10u, 40000u)),
+ LC3_PRESET("16_1_1",
+ LC3_PRESET_16KHZ(LC3_CONFIG_DURATION_7_5, 30u),
+ LC3_7_5_UNFRAMED(30u, 2u, 8u, 40000u)),
+ LC3_PRESET("16_2_1",
+ LC3_PRESET_16KHZ(LC3_CONFIG_DURATION_10, 40u),
+ LC3_10_UNFRAMED(40u, 2u, 10u, 40000u)),
+ LC3_PRESET("24_1_1",
+ LC3_PRESET_24KHZ(LC3_CONFIG_DURATION_7_5, 45u),
+ LC3_7_5_UNFRAMED(45u, 2u, 8u, 40000u)),
+ LC3_PRESET("24_2_1",
+ LC3_PRESET_24KHZ(LC3_CONFIG_DURATION_10, 60u),
+ LC3_10_UNFRAMED(60u, 2u, 10u, 40000u)),
+ LC3_PRESET("32_1_1",
+ LC3_PRESET_32KHZ(LC3_CONFIG_DURATION_7_5, 60u),
+ LC3_7_5_UNFRAMED(60u, 2u, 8u, 40000u)),
+ LC3_PRESET("32_2_1",
+ LC3_PRESET_32KHZ(LC3_CONFIG_DURATION_10, 80u),
+ LC3_10_UNFRAMED(80u, 2u, 10u, 40000u)),
+ LC3_PRESET("44_1_1",
+ LC3_PRESET_44KHZ(LC3_CONFIG_DURATION_7_5, 98u),
+ QOS_FRAMED_2M(8163u, 98u, 4u, 24u, 40000u)),
+ LC3_PRESET("44_2_1",
+ LC3_PRESET_44KHZ(LC3_CONFIG_DURATION_10, 130u),
+ QOS_FRAMED_2M(10884u, 130u, 4u, 31u, 40000u)),
+ LC3_PRESET("48_1_1",
+ LC3_PRESET_48KHZ(LC3_CONFIG_DURATION_7_5, 75u),
+ LC3_7_5_UNFRAMED(75u, 4u, 15u, 40000u)),
+ LC3_PRESET("48_2_1",
+ LC3_PRESET_48KHZ(LC3_CONFIG_DURATION_10, 100u),
+ LC3_10_UNFRAMED(100u, 4u, 20u, 40000u)),
+ LC3_PRESET("48_3_1",
+ LC3_PRESET_48KHZ(LC3_CONFIG_DURATION_7_5, 90u),
+ LC3_7_5_UNFRAMED(90u, 4u, 15u, 40000u)),
+ LC3_PRESET("48_4_1",
+ LC3_PRESET_48KHZ(LC3_CONFIG_DURATION_10, 120u),
+ LC3_10_UNFRAMED(120u, 4u, 20u, 40000u)),
+ LC3_PRESET("48_5_1",
+ LC3_PRESET_48KHZ(LC3_CONFIG_DURATION_7_5, 117u),
+ LC3_7_5_UNFRAMED(117u, 4u, 15u, 40000u)),
+ LC3_PRESET("48_6_1",
+ LC3_PRESET_48KHZ(LC3_CONFIG_DURATION_10, 155u),
+ LC3_10_UNFRAMED(155u, 4u, 20u, 40000u)),
+ /* Broadcast Audio Stream configuration settings for high-reliability
+ * audio data.
+ */
+ LC3_PRESET_HR("8_1_2",
+ LC3_PRESET_8KHZ(LC3_CONFIG_DURATION_7_5, 26u),
+ LC3_7_5_UNFRAMED(26u, 4u, 45u, 40000u)),
+ LC3_PRESET_HR("8_2_2",
+ LC3_PRESET_8KHZ(LC3_CONFIG_DURATION_10, 30u),
+ LC3_10_UNFRAMED(30u, 4u, 60u, 40000u)),
+ LC3_PRESET_HR("16_1_2",
+ LC3_PRESET_16KHZ(LC3_CONFIG_DURATION_7_5, 30u),
+ LC3_7_5_UNFRAMED(30u, 4u, 45u, 40000u)),
+ LC3_PRESET_HR("16_2_2",
+ LC3_PRESET_16KHZ(LC3_CONFIG_DURATION_10, 40u),
+ LC3_10_UNFRAMED(40u, 4u, 60u, 40000u)),
+ LC3_PRESET_HR("24_1_2",
+ LC3_PRESET_24KHZ(LC3_CONFIG_DURATION_7_5, 45u),
+ LC3_7_5_UNFRAMED(45u, 4u, 45u, 40000u)),
+ LC3_PRESET_HR("24_2_2",
+ LC3_PRESET_24KHZ(LC3_CONFIG_DURATION_10, 60u),
+ LC3_10_UNFRAMED(60u, 4u, 60u, 40000u)),
+ LC3_PRESET_HR("32_1_2",
+ LC3_PRESET_32KHZ(LC3_CONFIG_DURATION_7_5, 60u),
+ LC3_7_5_UNFRAMED(60u, 4u, 45u, 40000u)),
+ LC3_PRESET_HR("32_2_2",
+ LC3_PRESET_32KHZ(LC3_CONFIG_DURATION_10, 80u),
+ LC3_10_UNFRAMED(80u, 4u, 60u, 40000u)),
+ LC3_PRESET_HR("44_1_2",
+ LC3_PRESET_44KHZ(LC3_CONFIG_DURATION_7_5, 98u),
+ QOS_FRAMED_2M(8163u, 4u, 13u, 54u, 40000u)),
+ LC3_PRESET_HR("44_2_2",
+ LC3_PRESET_44KHZ(LC3_CONFIG_DURATION_10, 130u),
+ QOS_FRAMED_2M(10884u, 130u, 4u, 60u, 40000u)),
+ LC3_PRESET_HR("48_1_2",
+ LC3_PRESET_48KHZ(LC3_CONFIG_DURATION_7_5, 75u),
+ LC3_7_5_UNFRAMED(75u, 4u, 50u, 40000u)),
+ LC3_PRESET_HR("48_2_2",
+ LC3_PRESET_48KHZ(LC3_CONFIG_DURATION_10, 100u),
+ LC3_10_UNFRAMED(100u, 4u, 65u, 40000u)),
+ LC3_PRESET_HR("48_3_2",
+ LC3_PRESET_48KHZ(LC3_CONFIG_DURATION_7_5, 90u),
+ LC3_7_5_UNFRAMED(90u, 4u, 50u, 40000u)),
+ LC3_PRESET_HR("48_4_2",
+ LC3_PRESET_48KHZ(LC3_CONFIG_DURATION_10, 120u),
+ LC3_10_UNFRAMED(120u, 4u, 65u, 40000u)),
+ LC3_PRESET_HR("48_5_2",
+ LC3_PRESET_48KHZ(LC3_CONFIG_DURATION_7_5, 117u),
+ LC3_7_5_UNFRAMED(117u, 4u, 50u, 40000u)),
+ LC3_PRESET_HR("48_6_2",
+ LC3_PRESET_48KHZ(LC3_CONFIG_DURATION_10, 155u),
+ LC3_10_UNFRAMED(155u, 4u, 65u, 40000u)),
+};
+
static void print_ltv(const char *str, void *user_data)
{
const char *label = user_data;
@@ -1615,10 +1720,10 @@ static struct preset {
} presets[] = {
PRESET(A2DP_SOURCE_UUID, A2DP_CODEC_SBC, sbc_presets, 6),
PRESET(A2DP_SINK_UUID, A2DP_CODEC_SBC, sbc_presets, 6),
- PRESET(PAC_SINK_UUID, LC3_ID, lc3_presets, 3),
- PRESET(PAC_SOURCE_UUID, LC3_ID, lc3_presets, 3),
- PRESET(BCAA_SERVICE_UUID, LC3_ID, lc3_presets, 3),
- PRESET(BAA_SERVICE_UUID, LC3_ID, lc3_presets, 3),
+ PRESET(PAC_SINK_UUID, LC3_ID, lc3_ucast_presets, 3),
+ PRESET(PAC_SOURCE_UUID, LC3_ID, lc3_ucast_presets, 3),
+ PRESET(BCAA_SERVICE_UUID, LC3_ID, lc3_bcast_presets, 3),
+ PRESET(BAA_SERVICE_UUID, LC3_ID, lc3_bcast_presets, 3),
};
static void parse_vendor_codec(const char *codec, uint16_t *vid, uint16_t *cid)
--
2.43.0
From: Luiz Augusto von Dentz <[email protected]>
This adds defines for broadcast settings as they don't really match
unicast when it comes to RTN and Latency.
---
src/shared/bap-defs.h | 97 +++++++++++
src/shared/bap.h | 84 +---------
src/shared/lc3.h | 372 +++++++++++++++++++++++++++++++++++++++++-
3 files changed, 469 insertions(+), 84 deletions(-)
create mode 100644 src/shared/bap-defs.h
diff --git a/src/shared/bap-defs.h b/src/shared/bap-defs.h
new file mode 100644
index 000000000000..2467e816ffa9
--- /dev/null
+++ b/src/shared/bap-defs.h
@@ -0,0 +1,97 @@
+/* SPDX-License-Identifier: LGPL-2.1-or-later */
+/*
+ *
+ * BlueZ - Bluetooth protocol stack for Linux
+ *
+ * Copyright (C) 2022 Intel Corporation. All rights reserved.
+ * Copyright 2023-2024 NXP
+ *
+ */
+
+#ifndef SRC_SHARED_BAP_DEFS_H_
+#define SRC_SHARED_BAP_DEFS_H_
+
+#ifndef __packed
+#define __packed __attribute__((packed))
+#endif
+
+#define BT_BAP_SINK 0x01
+#define BT_BAP_SOURCE 0x02
+#define BT_BAP_BCAST_SOURCE 0x03
+#define BT_BAP_BCAST_SINK 0x04
+
+#define BT_BAP_STREAM_TYPE_UCAST 0x01
+#define BT_BAP_STREAM_TYPE_BCAST 0x02
+
+#define BT_BAP_STREAM_STATE_IDLE 0x00
+#define BT_BAP_STREAM_STATE_CONFIG 0x01
+#define BT_BAP_STREAM_STATE_QOS 0x02
+#define BT_BAP_STREAM_STATE_ENABLING 0x03
+#define BT_BAP_STREAM_STATE_STREAMING 0x04
+#define BT_BAP_STREAM_STATE_DISABLING 0x05
+#define BT_BAP_STREAM_STATE_RELEASING 0x06
+
+#define BT_BAP_CONFIG_LATENCY_LOW 0x01
+#define BT_BAP_CONFIG_LATENCY_BALANCED 0x02
+#define BT_BAP_CONFIG_LATENCY_HIGH 0x03
+
+#define BT_BAP_CONFIG_PHY_1M 0x01
+#define BT_BAP_CONFIG_PHY_2M 0x02
+#define BT_BAP_CONFIG_PHY_CODEC 0x03
+
+struct bt_bap_codec {
+ uint8_t id;
+ uint16_t cid;
+ uint16_t vid;
+} __packed;
+
+struct bt_ltv {
+ uint8_t len;
+ uint8_t type;
+ uint8_t value[];
+} __packed;
+
+struct bt_bap_io_qos {
+ uint32_t interval; /* Frame interval */
+ uint16_t latency; /* Transport Latency */
+ uint16_t sdu; /* Maximum SDU Size */
+ uint8_t phy; /* PHY */
+ uint8_t rtn; /* Retransmission Effort */
+};
+
+struct bt_bap_ucast_qos {
+ uint8_t cig_id;
+ uint8_t cis_id;
+ uint8_t framing; /* Frame framing */
+ uint32_t delay; /* Presentation Delay */
+ uint8_t target_latency; /* Target Latency */
+ struct bt_bap_io_qos io_qos;
+};
+
+struct bt_bap_bcast_qos {
+ uint8_t big;
+ uint8_t bis;
+ uint8_t sync_factor;
+ uint8_t packing;
+ uint8_t framing;
+ uint8_t encryption;
+ struct iovec *bcode;
+ uint8_t options;
+ uint16_t skip;
+ uint16_t sync_timeout;
+ uint8_t sync_cte_type;
+ uint8_t mse;
+ uint16_t timeout;
+ uint8_t pa_sync;
+ struct bt_bap_io_qos io_qos;
+ uint32_t delay; /* Presentation Delay */
+};
+
+struct bt_bap_qos {
+ union {
+ struct bt_bap_ucast_qos ucast;
+ struct bt_bap_bcast_qos bcast;
+ };
+};
+
+#endif /* SRC_SHARED_BAP_DEFS_H_ */
diff --git a/src/shared/bap.h b/src/shared/bap.h
index b2826719f84f..9839e324905a 100644
--- a/src/shared/bap.h
+++ b/src/shared/bap.h
@@ -10,94 +10,12 @@
#include <stdbool.h>
#include <inttypes.h>
-
-#ifndef __packed
-#define __packed __attribute__((packed))
-#endif
-
-#define BT_BAP_SINK 0x01
-#define BT_BAP_SOURCE 0x02
-#define BT_BAP_BCAST_SOURCE 0x03
-#define BT_BAP_BCAST_SINK 0x04
-
-#define BT_BAP_STREAM_TYPE_UCAST 0x01
-#define BT_BAP_STREAM_TYPE_BCAST 0x02
-
-#define BT_BAP_STREAM_STATE_IDLE 0x00
-#define BT_BAP_STREAM_STATE_CONFIG 0x01
-#define BT_BAP_STREAM_STATE_QOS 0x02
-#define BT_BAP_STREAM_STATE_ENABLING 0x03
-#define BT_BAP_STREAM_STATE_STREAMING 0x04
-#define BT_BAP_STREAM_STATE_DISABLING 0x05
-#define BT_BAP_STREAM_STATE_RELEASING 0x06
-
-#define BT_BAP_CONFIG_LATENCY_LOW 0x01
-#define BT_BAP_CONFIG_LATENCY_BALANCED 0x02
-#define BT_BAP_CONFIG_LATENCY_HIGH 0x03
-
-#define BT_BAP_CONFIG_PHY_1M 0x01
-#define BT_BAP_CONFIG_PHY_2M 0x02
-#define BT_BAP_CONFIG_PHY_CODEC 0x03
+#include "src/shared/bap-defs.h"
struct bt_bap;
struct bt_bap_pac;
struct bt_bap_stream;
-struct bt_bap_codec {
- uint8_t id;
- uint16_t cid;
- uint16_t vid;
-} __packed;
-
-struct bt_ltv {
- uint8_t len;
- uint8_t type;
- uint8_t value[0];
-} __packed;
-
-struct bt_bap_io_qos {
- uint32_t interval; /* Frame interval */
- uint16_t latency; /* Transport Latency */
- uint16_t sdu; /* Maximum SDU Size */
- uint8_t phy; /* PHY */
- uint8_t rtn; /* Retransmission Effort */
-};
-
-struct bt_bap_ucast_qos {
- uint8_t cig_id;
- uint8_t cis_id;
- uint8_t framing; /* Frame framing */
- uint32_t delay; /* Presentation Delay */
- uint8_t target_latency; /* Target Latency */
- struct bt_bap_io_qos io_qos;
-};
-
-struct bt_bap_bcast_qos {
- uint8_t big;
- uint8_t bis;
- uint8_t sync_factor;
- uint8_t packing;
- uint8_t framing;
- uint8_t encryption;
- struct iovec *bcode;
- uint8_t options;
- uint16_t skip;
- uint16_t sync_timeout;
- uint8_t sync_cte_type;
- uint8_t mse;
- uint16_t timeout;
- uint8_t pa_sync;
- struct bt_bap_io_qos io_qos;
- uint32_t delay; /* Presentation Delay */
-};
-
-struct bt_bap_qos {
- union {
- struct bt_bap_ucast_qos ucast;
- struct bt_bap_bcast_qos bcast;
- };
-};
-
typedef void (*bt_bap_ready_func_t)(struct bt_bap *bap, void *user_data);
typedef void (*bt_bap_destroy_func_t)(void *user_data);
typedef void (*bt_bap_debug_func_t)(const char *str, void *user_data);
diff --git a/src/shared/lc3.h b/src/shared/lc3.h
index 1db46217b76e..dcaa50ad531f 100644
--- a/src/shared/lc3.h
+++ b/src/shared/lc3.h
@@ -8,6 +8,8 @@
*
*/
+#include "src/shared/bap-defs.h"
+
#define LC3_ID 0x06
#define LC3_BASE 0x01
@@ -280,6 +282,7 @@
{ \
.ucast.cig_id = 0x00, \
.ucast.cis_id = 0x00, \
+ .ucast.framing = _frame, \
.ucast.delay = _pd, \
.ucast.target_latency = _t_lat, \
.ucast.io_qos.interval = _interval, \
@@ -358,6 +361,14 @@
LC3_QOS_16_1_2_RTN)
#define LC3_QOS_16_1_2 LC3_QOS_16_1_2_AC(1)
+#define LC3_QOS_16_1_GS_LATENCY 15u
+#define LC3_QOS_16_1_GS_RTN 1u
+#define LC3_QOS_16_1_GS \
+ LC3_QOS_UCAST_7_5_UNFRAMED(60000u, BT_BAP_CONFIG_LATENCY_BALANCED, \
+ LC3_QOS_16_1_GS_LATENCY, \
+ LC3_CONFIG_FRAME_LEN_16_1, \
+ LC3_QOS_16_1_GS_RTN)
+
#define LC3_QOS_16_2_1_LATENCY 10u
#define LC3_QOS_16_2_1_RTN 2u
@@ -378,13 +389,22 @@
LC3_QOS_16_2_2_RTN)
#define LC3_QOS_16_2_2 LC3_QOS_16_2_2_AC(1)
+#define LC3_QOS_16_2_GS_LATENCY 20u
+#define LC3_QOS_16_2_GS_RTN 1u
+#define LC3_QOS_16_2_GS \
+ LC3_QOS_UCAST_10_UNFRAMED(60000u, BT_BAP_CONFIG_LATENCY_BALANCED, \
+ LC3_QOS_16_2_GS_LATENCY, \
+ LC3_CONFIG_FRAME_LEN_16_2, \
+ LC3_QOS_16_2_GS_RTN)
+
#define LC3_QOS_24_1_1_LATENCY 8u
#define LC3_QOS_24_1_1_RTN 2u
#define LC3_QOS_24_1_1_AC(_ac) \
LC3_QOS_UCAST_7_5_UNFRAMED(40000u, BT_BAP_CONFIG_LATENCY_BALANCED, \
LC3_QOS_24_1_1_LATENCY, \
- _ac * LC3_CONFIG_FRAME_LEN_24_1, 2u)
+ _ac * LC3_CONFIG_FRAME_LEN_24_1, \
+ LC3_QOS_24_1_1_RTN)
#define LC3_QOS_24_1_1 LC3_QOS_24_1_1_AC(1)
#define LC3_QOS_24_1_2_LATENCY 75u
@@ -437,6 +457,23 @@
LC3_QOS_32_1_2_RTN)
#define LC3_QOS_32_1_2 LC3_QOS_32_1_2_AC(1)
+#define LC3_QOS_32_1_GS_LATENCY 15u
+#define LC3_QOS_32_1_GS_RTN 1u
+#define LC3_QOS_32_1_GS \
+ LC3_QOS_UCAST_7_5_UNFRAMED(40000u, BT_BAP_CONFIG_LATENCY_BALANCED, \
+ LC3_QOS_32_1_GS_LATENCY, \
+ LC3_CONFIG_FRAME_LEN_32_1, \
+ LC3_QOS_32_1_GS_RTN)
+
+#define LC3_QOS_32_1_GR_LATENCY 15u
+#define LC3_QOS_32_1_GR_RTN 1u
+#define LC3_QOS_32_1_GR_AC(_ac) \
+ LC3_QOS_UCAST_7_5_UNFRAMED(10000u, BT_BAP_CONFIG_LATENCY_LOW, \
+ LC3_QOS_32_1_GS_LATENCY, \
+ _ac * LC3_CONFIG_FRAME_LEN_32_1, \
+ LC3_QOS_32_1_GS_RTN)
+#define LC3_QOS_32_1_GR LC3_QOS_32_1_GR_AC(1)
+
#define LC3_QOS_32_2_1_LATENCY 10u
#define LC3_QOS_32_2_1_RTN 2u
@@ -457,6 +494,23 @@
LC3_QOS_32_2_2_RTN)
#define LC3_QOS_32_2_2 LC3_QOS_32_2_2_AC(1)
+#define LC3_QOS_32_2_GS_LATENCY 20u
+#define LC3_QOS_32_2_GS_RTN 1u
+#define LC3_QOS_32_2_GS \
+ LC3_QOS_UCAST_10_UNFRAMED(60000u, BT_BAP_CONFIG_LATENCY_BALANCED, \
+ LC3_QOS_32_2_GS_LATENCY, \
+ LC3_CONFIG_FRAME_LEN_32_2, \
+ LC3_QOS_32_2_GS_RTN)
+
+#define LC3_QOS_32_2_GR_LATENCY 20u
+#define LC3_QOS_32_2_GR_RTN 1u
+#define LC3_QOS_32_2_GR_AC(_ac) \
+ LC3_QOS_UCAST_10_UNFRAMED(10000u, BT_BAP_CONFIG_LATENCY_LOW, \
+ LC3_QOS_32_2_GR_LATENCY, \
+ _ac * LC3_CONFIG_FRAME_LEN_32_2, \
+ LC3_QOS_32_2_GR_RTN)
+#define LC3_QOS_32_2_GR LC3_QOS_32_2_GR_AC(1)
+
#define LC3_QOS_44_1_INTERVAL 8163u
#define LC3_QOS_44_1_1_LATENCY 24u
#define LC3_QOS_44_1_1_RTN 5u
@@ -523,6 +577,25 @@
LC3_QOS_48_1_2_RTN)
#define LC3_QOS_48_1_2 LC3_QOS_48_1_2_AC(1)
+#define LC3_QOS_48_1_GS_LATENCY 15u
+#define LC3_QOS_48_1_GS_RTN 1u
+
+#define LC3_QOS_48_1_GS \
+ LC3_QOS_UCAST_7_5_UNFRAMED(60000u, BT_BAP_CONFIG_LATENCY_BALANCED, \
+ LC3_QOS_48_1_GS_LATENCY, \
+ LC3_CONFIG_FRAME_LEN_48_1, \
+ LC3_QOS_48_1_GS_RTN)
+
+#define LC3_QOS_48_1_GR_LATENCY 15u
+#define LC3_QOS_48_1_GR_RTN 1u
+
+#define LC3_QOS_48_1_GR_AC(_ac) \
+ LC3_QOS_UCAST_7_5_UNFRAMED(10000u, BT_BAP_CONFIG_LATENCY_LOW, \
+ LC3_QOS_48_1_GR_LATENCY, \
+ _ac * LC3_CONFIG_FRAME_LEN_48_1, \
+ LC3_QOS_48_1_GR_RTN)
+#define LC3_QOS_48_1_GR LC3_QOS_48_1_GR_AC(1)
+
#define LC3_QOS_48_2_1_LATENCY 20u
#define LC3_QOS_48_2_1_RTN 5u
@@ -543,6 +616,25 @@
LC3_QOS_48_2_2_RTN)
#define LC3_QOS_48_2_2 LC3_QOS_48_2_2_AC(1)
+#define LC3_QOS_48_2_GS_LATENCY 20u
+#define LC3_QOS_48_2_GS_RTN 1u
+
+#define LC3_QOS_48_2_GS \
+ LC3_QOS_UCAST_10_UNFRAMED(60000u, BT_BAP_CONFIG_LATENCY_BALANCED, \
+ LC3_QOS_48_2_GS_LATENCY, \
+ LC3_CONFIG_FRAME_LEN_48_2, \
+ LC3_QOS_48_2_GS_RTN)
+
+#define LC3_QOS_48_2_GR_LATENCY 20u
+#define LC3_QOS_48_2_GR_RTN 1u
+
+#define LC3_QOS_48_2_GR_AC(_ac) \
+ LC3_QOS_UCAST_10_UNFRAMED(10000u, BT_BAP_CONFIG_LATENCY_LOW, \
+ LC3_QOS_48_2_GR_LATENCY, \
+ _ac * LC3_CONFIG_FRAME_LEN_48_2, \
+ LC3_QOS_48_2_GR_RTN)
+#define LC3_QOS_48_2_GR LC3_QOS_48_2_GR_AC(1)
+
#define LC3_QOS_48_3_1_LATENCY 15u
#define LC3_QOS_48_3_1_RTN 5u
@@ -563,6 +655,16 @@
LC3_QOS_48_3_2_RTN)
#define LC3_QOS_48_3_2 LC3_QOS_48_3_2_AC(1)
+#define LC3_QOS_48_3_GR_LATENCY 15u
+#define LC3_QOS_48_3_GR_RTN 1u
+
+#define LC3_QOS_48_3_GR_AC(_ac) \
+ LC3_QOS_UCAST_7_5_UNFRAMED(10000u, BT_BAP_CONFIG_LATENCY_LOW, \
+ LC3_QOS_48_3_GR_LATENCY, \
+ _ac * LC3_CONFIG_FRAME_LEN_48_3, \
+ LC3_QOS_48_3_GR_RTN)
+#define LC3_QOS_48_3_GR LC3_QOS_48_3_GR_AC(1)
+
#define LC3_QOS_48_4_1_LATENCY 20u
#define LC3_QOS_48_4_1_RTN 5u
@@ -583,6 +685,16 @@
LC3_QOS_48_4_2_RTN)
#define LC3_QOS_48_4_2 LC3_QOS_48_4_2_AC(1)
+#define LC3_QOS_48_4_GR_LATENCY 20u
+#define LC3_QOS_48_4_GR_RTN 1u
+
+#define LC3_QOS_48_4_GR_AC(_ac) \
+ LC3_QOS_UCAST_10_UNFRAMED(10000u, BT_BAP_CONFIG_LATENCY_LOW, \
+ LC3_QOS_48_4_GR_LATENCY, \
+ _ac * LC3_CONFIG_FRAME_LEN_48_4, \
+ LC3_QOS_48_4_GR_RTN)
+#define LC3_QOS_48_4_GR LC3_QOS_48_4_GR_AC(1)
+
#define LC3_QOS_48_5_1_LATENCY 15u
#define LC3_QOS_48_5_1_RTN 5u
@@ -622,3 +734,261 @@
_ac * LC3_CONFIG_FRAME_LEN_48_6, \
LC3_QOS_48_6_2_RTN)
#define LC3_QOS_48_6_2 LC3_QOS_48_6_2_AC(1)
+
+#define LC3_QOS_BCAST(_frame, _pd, _interval, _lat, _sdu, _rtn) \
+{ \
+ .bcast.big = 0x00, \
+ .bcast.bis = 0x00, \
+ .bcast.framing = _frame, \
+ .bcast.delay = _pd, \
+ .bcast.io_qos.interval = _interval, \
+ .bcast.io_qos.latency = _lat, \
+ .bcast.io_qos.sdu = _sdu, \
+ .bcast.io_qos.phy = BT_BAP_CONFIG_PHY_2M, \
+ .bcast.io_qos.rtn = _rtn, \
+}
+
+#define LC3_QOS_BCAST_7_5_UNFRAMED(_pd, _lat, _sdu, _rtn) \
+ LC3_QOS_BCAST(LC3_QOS_UNFRAMED, _pd, 7500u, _lat, _sdu, _rtn)
+
+#define LC3_QOS_BCAST_10_UNFRAMED(_pd, _lat, _sdu, _rtn) \
+ LC3_QOS_BCAST(LC3_QOS_UNFRAMED, _pd, 10000u, _lat, _sdu, _rtn)
+
+#define LC3_QOS_BCAST_FRAMED(_pd, _interval, _lat, _sdu, _rtn) \
+ LC3_QOS_BCAST(LC3_QOS_FRAMED, _pd, _interval, _lat, _sdu, _rtn)
+
+#define LC3_QOS_8_1_1_B_AC(_ac) \
+ LC3_QOS_BCAST_7_5_UNFRAMED(40000u, LC3_QOS_8_1_1_LATENCY, \
+ _ac * LC3_CONFIG_FRAME_LEN_8_1, \
+ LC3_QOS_8_1_1_RTN)
+#define LC3_QOS_8_1_1_B LC3_QOS_8_1_1_B_AC(1)
+
+#define LC3_QOS_8_1_2_B_LATENCY 75u
+#define LC3_QOS_8_1_2_B_RTN 4u
+#define LC3_QOS_8_1_2_B_AC(_ac) \
+ LC3_QOS_BCAST_7_5_UNFRAMED(40000u, LC3_QOS_8_1_2_B_LATENCY, \
+ _ac * LC3_CONFIG_FRAME_LEN_8_1, \
+ LC3_QOS_8_1_2_B_RTN)
+#define LC3_QOS_48_1_2_B LC3_QOS_48_1_2_B_AC(1)
+
+#define LC3_QOS_8_2_1_B_AC(_ac) \
+ LC3_QOS_BCAST_10_UNFRAMED(40000u, LC3_QOS_8_2_1_LATENCY, \
+ _ac * LC3_CONFIG_FRAME_LEN_8_2, \
+ LC3_QOS_8_2_1_RTN)
+#define LC3_QOS_8_2_1_B LC3_QOS_8_2_1_B_AC(1)
+
+#define LC3_QOS_8_2_2_B_LATENCY 60u
+#define LC3_QOS_8_2_2_B_RTN 4u
+#define LC3_QOS_8_2_2_B_AC(_ac) \
+ LC3_QOS_BCAST_10_UNFRAMED(40000u, LC3_QOS_8_2_2_B_LATENCY, \
+ _ac * LC3_CONFIG_FRAME_LEN_8_2, \
+ LC3_QOS_8_2_2_B_RTN)
+#define LC3_QOS_8_2_2_B LC3_QOS_8_2_2_B_AC(1)
+
+#define LC3_QOS_16_1_1_B_AC(_ac) \
+ LC3_QOS_BCAST_7_5_UNFRAMED(40000u, LC3_QOS_16_1_1_LATENCY, \
+ _ac * LC3_CONFIG_FRAME_LEN_16_1, \
+ LC3_QOS_16_1_1_RTN)
+#define LC3_QOS_16_1_1_B LC3_QOS_16_1_1_B_AC(1)
+
+#define LC3_QOS_16_1_2_B_LATENCY 45u
+#define LC3_QOS_16_1_2_B_RTN 4u
+#define LC3_QOS_16_1_2_B_AC(_ac) \
+ LC3_QOS_BCAST_7_5_UNFRAMED(40000u, LC3_QOS_16_1_2_B_LATENCY, \
+ _ac * LC3_CONFIG_FRAME_LEN_16_1, \
+ LC3_QOS_16_1_2_B_RTN)
+#define LC3_QOS_16_1_2_B LC3_QOS_16_1_2_B_AC(1)
+
+#define LC3_QOS_16_2_1_B_AC(_ac) \
+ LC3_QOS_BCAST_10_UNFRAMED(40000u, LC3_QOS_16_2_1_LATENCY, \
+ _ac * LC3_CONFIG_FRAME_LEN_16_2, \
+ LC3_QOS_16_2_1_RTN)
+#define LC3_QOS_16_2_1_B LC3_QOS_16_2_1_B_AC(1)
+
+#define LC3_QOS_16_2_2_B_LATENCY 60u
+#define LC3_QOS_16_2_2_B_RTN 4u
+#define LC3_QOS_16_2_2_B_AC(_ac) \
+ LC3_QOS_BCAST_10_UNFRAMED(40000u, LC3_QOS_16_2_2_B_LATENCY, \
+ _ac * LC3_CONFIG_FRAME_LEN_16_2, \
+ LC3_QOS_16_2_2_B_RTN)
+#define LC3_QOS_16_2_2_B LC3_QOS_16_2_2_B_AC(1)
+
+#define LC3_QOS_24_1_1_B_AC(_ac) \
+ LC3_QOS_BCAST_7_5_UNFRAMED(40000u, LC3_QOS_24_1_1_LATENCY, \
+ _ac * LC3_CONFIG_FRAME_LEN_24_1, \
+ LC3_QOS_24_1_1_RTN)
+#define LC3_QOS_24_1_1_B LC3_QOS_24_1_1_B_AC(1)
+
+#define LC3_QOS_24_1_2_B_LATENCY 45u
+#define LC3_QOS_24_1_2_B_RTN 4u
+#define LC3_QOS_24_1_2_B_AC(_ac) \
+ LC3_QOS_BCAST_7_5_UNFRAMED(40000u, LC3_QOS_24_1_2_B_LATENCY, \
+ _ac * LC3_CONFIG_FRAME_LEN_24_1, \
+ LC3_QOS_24_1_2_B_RTN)
+#define LC3_QOS_24_1_2_B LC3_QOS_24_1_2_B_AC(1)
+
+#define LC3_QOS_24_2_1_B_AC(_ac) \
+ LC3_QOS_BCAST_10_UNFRAMED(40000u, LC3_QOS_24_2_1_LATENCY, \
+ _ac * LC3_CONFIG_FRAME_LEN_24_2, \
+ LC3_QOS_24_2_1_RTN)
+#define LC3_QOS_24_2_1_B LC3_QOS_24_2_1_B_AC(1)
+
+#define LC3_QOS_24_2_2_B_LATENCY 60u
+#define LC3_QOS_24_2_2_B_RTN 4u
+#define LC3_QOS_24_2_2_B_AC(_ac) \
+ LC3_QOS_BCAST_10_UNFRAMED(40000u, LC3_QOS_24_2_2_B_LATENCY, \
+ _ac * LC3_CONFIG_FRAME_LEN_24_2, \
+ LC3_QOS_24_2_2_B_RTN)
+#define LC3_QOS_24_2_2_B LC3_QOS_24_2_2_B_AC(1)
+
+#define LC3_QOS_32_1_1_B_AC(_ac) \
+ LC3_QOS_BCAST_7_5_UNFRAMED(40000u, LC3_QOS_32_1_1_LATENCY, \
+ LC3_CONFIG_FRAME_LEN_32_1, \
+ LC3_QOS_32_1_1_RTN)
+#define LC3_QOS_32_1_1_B LC3_QOS_32_1_1_B_AC(1)
+
+#define LC3_QOS_32_1_2_B_LATENCY 45u
+#define LC3_QOS_32_1_2_B_RTN 4u
+#define LC3_QOS_32_1_2_B_AC(_ac) \
+ LC3_QOS_BCAST_7_5_UNFRAMED(40000u, LC3_QOS_32_1_2_B_LATENCY, \
+ LC3_CONFIG_FRAME_LEN_32_1, \
+ LC3_QOS_32_1_2_B_RTN)
+#define LC3_QOS_32_1_2_B LC3_QOS_32_1_2_B_AC(1)
+
+#define LC3_QOS_32_2_1_B_AC(_ac) \
+ LC3_QOS_BCAST_10_UNFRAMED(40000u, LC3_QOS_32_2_1_LATENCY, \
+ _ac * LC3_CONFIG_FRAME_LEN_32_2, \
+ LC3_QOS_32_2_1_RTN)
+#define LC3_QOS_32_2_1_B LC3_QOS_32_2_1_B_AC(1)
+
+#define LC3_QOS_32_2_2_B_LATENCY 60u
+#define LC3_QOS_32_2_2_B_RTN 4u
+#define LC3_QOS_32_2_2_B_AC(_ac) \
+ LC3_QOS_BCAST_10_UNFRAMED(40000u, LC3_QOS_32_2_2_B_LATENCY, \
+ _ac * LC3_CONFIG_FRAME_LEN_32_2, \
+ LC3_QOS_32_2_2_B_RTN)
+#define LC3_QOS_32_2_2_B LC3_QOS_32_2_2_B_AC(1)
+
+#define LC3_QOS_44_1_1_B_RTN 4u
+#define LC3_QOS_44_1_1_B_AC(_ac) \
+ LC3_QOS_BCAST_FRAMED(40000u, LC3_QOS_44_1_INTERVAL, \
+ LC3_QOS_44_1_1_LATENCY, \
+ _ac * LC3_CONFIG_FRAME_LEN_44_1, \
+ LC3_QOS_44_1_1_B_RTN)
+#define LC3_QOS_44_1_1_B LC3_QOS_44_1_1_B_AC(1)
+
+#define LC3_QOS_44_1_2_B_LATENCY 54u
+#define LC3_QOS_44_1_2_B_RTN 4u
+#define LC3_QOS_44_1_2_B_AC(_ac) \
+ LC3_QOS_BCAST_FRAMED(40000u, LC3_QOS_44_1_INTERVAL, \
+ LC3_QOS_44_1_2_B_LATENCY, \
+ _ac * LC3_CONFIG_FRAME_LEN_44_1, \
+ LC3_QOS_44_1_2_B_RTN)
+#define LC3_QOS_44_1_2_B LC3_QOS_44_1_2_B_AC(1)
+
+#define LC3_QOS_44_2_1_B_RTN 4u
+#define LC3_QOS_44_2_1_B_AC(_ac) \
+ LC3_QOS_BCAST_FRAMED(40000u, LC3_QOS_44_2_INTERVAL, \
+ LC3_QOS_44_2_1_LATENCY, \
+ _ac * LC3_CONFIG_FRAME_LEN_44_2, \
+ LC3_QOS_44_2_1_B_RTN)
+#define LC3_QOS_44_2_1_B LC3_QOS_44_2_1_B_AC(1)
+
+#define LC3_QOS_44_2_2_B_LATENCY 60u
+#define LC3_QOS_44_2_2_B_RTN 4u
+#define LC3_QOS_44_2_2_B_AC(_ac) \
+ LC3_QOS_BCAST_FRAMED(40000u, LC3_QOS_44_2_INTERVAL, \
+ LC3_QOS_44_2_2_LATENCY, \
+ _ac * LC3_CONFIG_FRAME_LEN_44_2, \
+ LC3_QOS_44_2_2_RTN)
+#define LC3_QOS_44_2_2_B LC3_QOS_44_2_2_B_AC(1)
+
+#define LC3_QOS_48_1_1_B_RTN 4u
+#define LC3_QOS_48_1_1_B_AC(_ac) \
+ LC3_QOS_BCAST_7_5_UNFRAMED(40000u, LC3_QOS_48_1_1_LATENCY, \
+ _ac * LC3_CONFIG_FRAME_LEN_48_1,\
+ LC3_QOS_48_1_1_B_RTN)
+#define LC3_QOS_48_1_1_B LC3_QOS_48_1_1_B_AC(1)
+
+#define LC3_QOS_48_1_2_B_LATENCY 50u
+#define LC3_QOS_48_1_2_B_RTN 4u
+#define LC3_QOS_48_1_2_B_AC(_ac) \
+ LC3_QOS_BCAST_7_5_UNFRAMED(40000u, LC3_QOS_48_1_2_B_LATENCY, \
+ _ac * LC3_CONFIG_FRAME_LEN_48_1, \
+ LC3_QOS_48_1_2_B_RTN)
+#define LC3_QOS_48_1_2_B LC3_QOS_48_1_2_B_AC(1)
+
+#define LC3_QOS_48_2_1_B_RTN 4u
+#define LC3_QOS_48_2_1_B_AC(_ac) \
+ LC3_QOS_BCAST_10_UNFRAMED(40000u, LC3_QOS_48_2_1_LATENCY, \
+ _ac * LC3_CONFIG_FRAME_LEN_48_2, \
+ LC3_QOS_48_2_1_B_RTN)
+#define LC3_QOS_48_2_1_B LC3_QOS_48_2_1_B_AC(1)
+
+#define LC3_QOS_48_2_2_B_LATENCY 65u
+#define LC3_QOS_48_2_2_B_RTN 4u
+#define LC3_QOS_48_2_2_B_AC(_ac) \
+ LC3_QOS_BCAST_10_UNFRAMED(40000u, LC3_QOS_48_2_2_B_LATENCY, \
+ _ac * LC3_CONFIG_FRAME_LEN_48_2, \
+ LC3_QOS_48_2_2_B_RTN)
+#define LC3_QOS_48_2_2_B LC3_QOS_48_2_2_B_AC(1)
+
+#define LC3_QOS_48_3_1_B_RTN 4u
+#define LC3_QOS_48_3_1_B_AC(_ac) \
+ LC3_QOS_BCAST_7_5_UNFRAMED(40000u, LC3_QOS_48_3_1_LATENCY, \
+ _ac * LC3_CONFIG_FRAME_LEN_48_3, \
+ LC3_QOS_48_3_1_B_RTN)
+#define LC3_QOS_48_3_1_B LC3_QOS_48_3_1_B_AC(1)
+
+#define LC3_QOS_48_3_2_B_LATENCY 50u
+#define LC3_QOS_48_3_2_B_RTN 4u
+#define LC3_QOS_48_3_2_B_AC(_ac) \
+ LC3_QOS_BCAST_7_5_UNFRAMED(40000u, LC3_QOS_48_3_2_LATENCY, \
+ _ac * LC3_CONFIG_FRAME_LEN_48_3, \
+ LC3_QOS_48_3_2_RTN)
+#define LC3_QOS_48_3_2_B LC3_QOS_48_3_2_B_AC(1)
+
+#define LC3_QOS_48_4_1_B_RTN 4u
+#define LC3_QOS_48_4_1_B_AC(_ac) \
+ LC3_QOS_BCAST_10_UNFRAMED(40000u, LC3_QOS_48_4_1_LATENCY, \
+ _ac * LC3_CONFIG_FRAME_LEN_48_4, \
+ LC3_QOS_48_4_1_B_RTN)
+#define LC3_QOS_48_4_1_B LC3_QOS_48_4_1_B_AC(1)
+
+#define LC3_QOS_48_4_2_B_LATENCY 65u
+#define LC3_QOS_48_4_2_B_RTN 4u
+#define LC3_QOS_48_4_2_B_AC(_ac) \
+ LC3_QOS_BCAST_10_UNFRAMED(40000u, LC3_QOS_48_4_2_B_LATENCY, \
+ _ac * LC3_CONFIG_FRAME_LEN_48_4, \
+ LC3_QOS_48_4_2_B_RTN)
+#define LC3_QOS_48_4_2_B LC3_QOS_48_4_2_B_AC(1)
+
+#define LC3_QOS_48_5_1_B_RTN 4u
+#define LC3_QOS_48_5_1_B_AC(_ac) \
+ LC3_QOS_BCAST_7_5_UNFRAMED(40000u, LC3_QOS_48_5_1_LATENCY, \
+ _ac * LC3_CONFIG_FRAME_LEN_48_5, \
+ LC3_QOS_48_5_1_B_RTN)
+#define LC3_QOS_48_5_1_B LC3_QOS_48_5_1_B_AC(1)
+
+#define LC3_QOS_48_5_2_B_LATENCY 50u
+#define LC3_QOS_48_5_2_B_RTN 4u
+#define LC3_QOS_48_5_2_B_AC(_ac) \
+ LC3_QOS_BCAST_7_5_UNFRAMED(40000u, LC3_QOS_48_5_2_B_LATENCY, \
+ _ac * LC3_CONFIG_FRAME_LEN_48_5, \
+ LC3_QOS_48_5_2_B_RTN)
+#define LC3_QOS_48_5_2_B LC3_QOS_48_5_2_B_AC(1)
+
+#define LC3_QOS_48_6_1_B_RTN 5u
+#define LC3_QOS_48_6_1_B_AC(_ac) \
+ LC3_QOS_BCAST_10_UNFRAMED(40000u, LC3_QOS_48_6_1_LATENCY, \
+ _ac * LC3_CONFIG_FRAME_LEN_48_6, \
+ LC3_QOS_48_6_1_B_RTN)
+#define LC3_QOS_48_6_1_B LC3_QOS_48_6_1_B_AC(1)
+
+#define LC3_QOS_48_6_2_B_LATENCY 65u
+#define LC3_QOS_48_6_2_B_RTN 4u
+#define LC3_QOS_48_6_2_B_AC(_ac) \
+ LC3_QOS_BCAST_10_UNFRAMED(40000u, LC3_QOS_48_6_2_B_LATENCY, \
+ _ac * LC3_CONFIG_FRAME_LEN_48_6, \
+ LC3_QOS_48_6_2_B_RTN)
+#define LC3_QOS_48_6_2_B LC3_QOS_48_6_2_B_AC(1)
--
2.43.0
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=834997
---Test result---
Test Summary:
CheckPatch FAIL 2.53 seconds
GitLint PASS 1.20 seconds
BuildEll PASS 23.93 seconds
BluezMake PASS 1673.14 seconds
MakeCheck FAIL 11.20 seconds
MakeDistcheck FAIL 34.83 seconds
CheckValgrind FAIL 234.62 seconds
CheckSmatch PASS 343.96 seconds
bluezmakeextell PASS 117.64 seconds
IncrementalBuild PASS 6202.18 seconds
ScanBuild PASS 963.67 seconds
Details
##############################
Test: CheckPatch - FAIL
Desc: Run checkpatch.pl script
Output:
[BlueZ,v2,2/4] client/player: Use macros from lc3.h to define presets
WARNING:REPEATED_WORD: Possible repeated word: 'for'
#97:
This makes use of macros for for lc3.h to define preset configuration
/github/workspace/src/src/13591504.patch total: 0 errors, 1 warnings, 397 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
/github/workspace/src/src/13591504.patch has style problems, please review.
NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
[BlueZ,v2,3/4] shared/lc3: Add definition for broadcast configurations
WARNING:PREFER_DEFINED_ATTRIBUTE_MACRO: Prefer __packed over __attribute__((packed))
#126: FILE: src/shared/bap-defs.h:15:
+#define __packed __attribute__((packed))
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#532: FILE: src/shared/lc3.h:762:
+ _ac * LC3_CONFIG_FRAME_LEN_8_1, \
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#540: FILE: src/shared/lc3.h:770:
+ _ac * LC3_CONFIG_FRAME_LEN_8_1, \
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#546: FILE: src/shared/lc3.h:776:
+ _ac * LC3_CONFIG_FRAME_LEN_8_2, \
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#554: FILE: src/shared/lc3.h:784:
+ _ac * LC3_CONFIG_FRAME_LEN_8_2, \
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#560: FILE: src/shared/lc3.h:790:
+ _ac * LC3_CONFIG_FRAME_LEN_16_1, \
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#568: FILE: src/shared/lc3.h:798:
+ _ac * LC3_CONFIG_FRAME_LEN_16_1, \
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#574: FILE: src/shared/lc3.h:804:
+ _ac * LC3_CONFIG_FRAME_LEN_16_2, \
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#582: FILE: src/shared/lc3.h:812:
+ _ac * LC3_CONFIG_FRAME_LEN_16_2, \
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#588: FILE: src/shared/lc3.h:818:
+ _ac * LC3_CONFIG_FRAME_LEN_24_1, \
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#596: FILE: src/shared/lc3.h:826:
+ _ac * LC3_CONFIG_FRAME_LEN_24_1, \
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#602: FILE: src/shared/lc3.h:832:
+ _ac * LC3_CONFIG_FRAME_LEN_24_2, \
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#610: FILE: src/shared/lc3.h:840:
+ _ac * LC3_CONFIG_FRAME_LEN_24_2, \
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#630: FILE: src/shared/lc3.h:860:
+ _ac * LC3_CONFIG_FRAME_LEN_32_2, \
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#638: FILE: src/shared/lc3.h:868:
+ _ac * LC3_CONFIG_FRAME_LEN_32_2, \
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#646: FILE: src/shared/lc3.h:876:
+ _ac * LC3_CONFIG_FRAME_LEN_44_1, \
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#655: FILE: src/shared/lc3.h:885:
+ _ac * LC3_CONFIG_FRAME_LEN_44_1, \
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#663: FILE: src/shared/lc3.h:893:
+ _ac * LC3_CONFIG_FRAME_LEN_44_2, \
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#672: FILE: src/shared/lc3.h:902:
+ _ac * LC3_CONFIG_FRAME_LEN_44_2, \
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#679: FILE: src/shared/lc3.h:909:
+ _ac * LC3_CONFIG_FRAME_LEN_48_1,\
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#687: FILE: src/shared/lc3.h:917:
+ _ac * LC3_CONFIG_FRAME_LEN_48_1, \
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#694: FILE: src/shared/lc3.h:924:
+ _ac * LC3_CONFIG_FRAME_LEN_48_2, \
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#702: FILE: src/shared/lc3.h:932:
+ _ac * LC3_CONFIG_FRAME_LEN_48_2, \
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#709: FILE: src/shared/lc3.h:939:
+ _ac * LC3_CONFIG_FRAME_LEN_48_3, \
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#717: FILE: src/shared/lc3.h:947:
+ _ac * LC3_CONFIG_FRAME_LEN_48_3, \
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#724: FILE: src/shared/lc3.h:954:
+ _ac * LC3_CONFIG_FRAME_LEN_48_4, \
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#732: FILE: src/shared/lc3.h:962:
+ _ac * LC3_CONFIG_FRAME_LEN_48_4, \
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#739: FILE: src/shared/lc3.h:969:
+ _ac * LC3_CONFIG_FRAME_LEN_48_5, \
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#747: FILE: src/shared/lc3.h:977:
+ _ac * LC3_CONFIG_FRAME_LEN_48_5, \
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#754: FILE: src/shared/lc3.h:984:
+ _ac * LC3_CONFIG_FRAME_LEN_48_6, \
ERROR:POINTER_LOCATION: "foo * bar" should be "foo *bar"
#762: FILE: src/shared/lc3.h:992:
+ _ac * LC3_CONFIG_FRAME_LEN_48_6, \
/github/workspace/src/src/13591505.patch total: 30 errors, 1 warnings, 633 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
/github/workspace/src/src/13591505.patch has style problems, please review.
NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
[BlueZ,v2,4/4] client/player: Use QOS macros from lc3.h to define presets
WARNING:REPEATED_WORD: Possible repeated word: 'for'
#97:
This makes use of QOS macros for for lc3.h to define preset
/github/workspace/src/src/13591506.patch total: 0 errors, 1 warnings, 597 lines checked
NOTE: For some of the reported defects, checkpatch may be able to
mechanically convert to the typical style using --fix or --fix-inplace.
/github/workspace/src/src/13591506.patch has style problems, please review.
NOTE: Ignored message types: COMMIT_MESSAGE COMPLEX_MACRO CONST_STRUCT FILE_PATH_CHANGES MISSING_SIGN_OFF PREFER_PACKED SPDX_LICENSE_TAG SPLIT_STRING SSCANF_TO_KSTRTO
NOTE: If any of the errors are false positives, please report
them to the maintainer, see CHECKPATCH in MAINTAINERS.
##############################
Test: MakeCheck - FAIL
Desc: Run Bluez Make Check
Output:
./test-driver: line 107: 31947 Aborted (core dumped) "$@" > $log_file 2>&1
make[3]: *** [Makefile:11642: test-suite.log] Error 1
make[2]: *** [Makefile:11750: check-TESTS] Error 2
make[1]: *** [Makefile:12179: check-am] Error 2
make: *** [Makefile:12181: check] Error 2
##############################
Test: MakeDistcheck - FAIL
Desc: Run Bluez Make Distcheck
Output:
Package cups was not found in the pkg-config search path.
Perhaps you should add the directory containing `cups.pc'
to the PKG_CONFIG_PATH environment variable
No package 'cups' found
In file included from ../../src/shared/bap.c:30:
../../src/shared/bap.h:13:10: fatal error: src/shared/bap-defs.h: No such file or directory
13 | #include "src/shared/bap-defs.h"
| ^~~~~~~~~~~~~~~~~~~~~~~
compilation terminated.
make[2]: *** [Makefile:8570: src/shared/libshared_mainloop_la-bap.lo] Error 1
make[2]: *** Waiting for unfinished jobs....
make[1]: *** [Makefile:4646: all] Error 2
make: *** [Makefile:12102: distcheck] Error 1
##############################
Test: CheckValgrind - FAIL
Desc: Run Bluez Make Check with Valgrind
Output:
tools/mgmt-tester.c: In function ‘main’:
tools/mgmt-tester.c:12721:5: note: variable tracking size limit exceeded with ‘-fvar-tracking-assignments’, retrying without
12721 | int main(int argc, char *argv[])
| ^~~~
./test-driver: line 107: 62238 Aborted (core dumped) "$@" > $log_file 2>&1
make[3]: *** [Makefile:11642: test-suite.log] Error 1
make[2]: *** [Makefile:11750: check-TESTS] Error 2
make[1]: *** [Makefile:12179: check-am] Error 2
make: *** [Makefile:12181: check] Error 2
---
Regards,
Linux Bluetooth