2024-03-25 14:24:36

by Yun-hao Chung

Subject: [Bluez PATCH] Advertising: Emit features property update

From: Yun-Hao Chung <[email protected]>

Advertising manager has some properties that relies on kernel
information. Once we received the information from kernel, we should
emit property update.

Reviewed-by: apusaka <[email protected]>
---

src/advertising.c | 13 +++++++++++++
1 file changed, 13 insertions(+)

diff --git a/src/advertising.c b/src/advertising.c
index 0131fc1c7..7f55a20e3 100644
--- a/src/advertising.c
+++ b/src/advertising.c
@@ -1890,6 +1890,19 @@ static void read_adv_features_callback(uint8_t status, uint16_t length,
/* Reset existing instances */
if (feat->num_instances)
remove_advertising(manager, 0);
+
+ /* Emit property update */
+ g_dbus_emit_property_changed(btd_get_dbus_connection(),
+ adapter_get_path(manager->adapter),
+ LE_ADVERTISING_MGR_IFACE, "SupportedFeatures");
+
+ g_dbus_emit_property_changed(btd_get_dbus_connection(),
+ adapter_get_path(manager->adapter),
+ LE_ADVERTISING_MGR_IFACE, "SupportedIncludes");
+
+ g_dbus_emit_property_changed(btd_get_dbus_connection(),
+ adapter_get_path(manager->adapter),
+ LE_ADVERTISING_MGR_IFACE, "SupportedSecondaryChannels");
}

static void read_controller_cap_complete(uint8_t status, uint16_t length,
--
2.44.0.396.g6e790dbe36-goog

2024-03-25 15:27:49

by bluez.test.bot

Subject: RE: [Bluez] Advertising: Emit features property update

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=837824

---Test result---

Test Summary:
CheckPatch PASS 0.40 seconds
GitLint PASS 0.28 seconds
BuildEll PASS 23.75 seconds
BluezMake PASS 1595.64 seconds
MakeCheck PASS 17.50 seconds
MakeDistcheck PASS 172.32 seconds
CheckValgrind PASS 242.30 seconds
CheckSmatch PASS 342.79 seconds
bluezmakeextell PASS 116.93 seconds
IncrementalBuild PASS 1471.63 seconds
ScanBuild PASS 956.57 seconds



---
Regards,
Linux Bluetooth

2024-03-25 19:47:22

by patchwork-bot+bluetooth

Subject: Re: [Bluez PATCH] Advertising: Emit features property update

Hello:

This patch was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <[email protected]>:

On Mon, 25 Mar 2024 18:10:04 +0800 you wrote:
> From: Yun-Hao Chung <[email protected]>
>
> Advertising manager has some properties that relies on kernel
> information. Once we received the information from kernel, we should
> emit property update.
>
> Reviewed-by: apusaka <[email protected]>
>
> [...]

Here is the summary with links:
- [Bluez] Advertising: Emit features property update
https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=150bd6e81b35

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html