Subject: [PATCH BlueZ 0/1] Fix MediaEndpoint prop codec for bcast src endpoint

Fix MediaEndpoint prop codec returns 0 for bcast src endpoint

before:
gdbus introspect --system --dest org.bluez --object-path
/org/bluez/hci0/pac_bcast0
node /org/bluez/hci0/pac_bcast0 {
......
interface org.bluez.MediaEndpoint1 {
......
properties:
readonly s UUID = '00001851-0000-1000-8000-00805f9b34fb';
readonly y Codec = 0x00;
.......
};
.......
};

after:
gdbus introspect --system --dest org.bluez --object-path
/org/bluez/hci0/pac_bcast0
node /org/bluez/hci0/pac_bcast0 {
......
interface org.bluez.MediaEndpoint1 {
......
properties:
readonly s UUID = '00001851-0000-1000-8000-00805f9b34fb';
readonly y Codec = 0x06;
.......
};
.......
};

Silviu Florian Barbulescu (1):
bap: Fix MediaEndpoint prop codec returns 0 for bcast src endpoint

profiles/audio/bap.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)


base-commit: 41d6c4e1c92fc6e0757b0f71ca5062671ff55235
--
2.39.2



Subject: [PATCH BlueZ 1/1] bap: Fix MediaEndpoint prop codec for bcast src endpoint

Fix MediaEndpoint prop codec returns 0 for bcast src endpoint

---
profiles/audio/bap.c | 8 +++++++-
1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/profiles/audio/bap.c b/profiles/audio/bap.c
index 23cadde49..52a9f5e00 100644
--- a/profiles/audio/bap.c
+++ b/profiles/audio/bap.c
@@ -277,7 +277,13 @@ static gboolean get_codec(const GDBusPropertyTable *property,
struct bap_ep *ep = data;
uint8_t codec;

- bt_bap_pac_get_codec(ep->rpac, &codec, NULL, NULL);
+ /* For broadcast source, rpac is null so the codec
+ * is retrieved from the lpac
+ */
+ if (ep->rpac == NULL)
+ bt_bap_pac_get_codec(ep->lpac, &codec, NULL, NULL);
+ else
+ bt_bap_pac_get_codec(ep->rpac, &codec, NULL, NULL);

dbus_message_iter_append_basic(iter, DBUS_TYPE_BYTE, &codec);

--
2.39.2


2024-03-27 15:51:01

by bluez.test.bot

[permalink] [raw]
Subject: RE: Fix MediaEndpoint prop codec for bcast src endpoint

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=838891

---Test result---

Test Summary:
CheckPatch PASS 0.44 seconds
GitLint PASS 0.31 seconds
BuildEll PASS 24.43 seconds
BluezMake PASS 1777.98 seconds
MakeCheck PASS 13.74 seconds
MakeDistcheck PASS 188.68 seconds
CheckValgrind PASS 257.92 seconds
CheckSmatch PASS 357.36 seconds
bluezmakeextell PASS 122.02 seconds
IncrementalBuild PASS 1572.43 seconds
ScanBuild PASS 1017.14 seconds



---
Regards,
Linux Bluetooth

2024-03-28 14:41:38

by patchwork-bot+bluetooth

[permalink] [raw]
Subject: Re: [PATCH BlueZ 0/1] Fix MediaEndpoint prop codec for bcast src endpoint

Hello:

This patch was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <[email protected]>:

On Wed, 27 Mar 2024 15:49:46 +0200 you wrote:
> Fix MediaEndpoint prop codec returns 0 for bcast src endpoint
>
> before:
> gdbus introspect --system --dest org.bluez --object-path
> /org/bluez/hci0/pac_bcast0
> node /org/bluez/hci0/pac_bcast0 {
> ......
> interface org.bluez.MediaEndpoint1 {
> ......
> properties:
> readonly s UUID = '00001851-0000-1000-8000-00805f9b34fb';
> readonly y Codec = 0x00;
> .......
> };
> .......
> };
>
> [...]

Here is the summary with links:
- [BlueZ,1/1] bap: Fix MediaEndpoint prop codec for bcast src endpoint
https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=0ff7392af164

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html