From: Christoffer Sandberg <[email protected]>
For HW variants 0x17, 0x18 and 0x19 LE Coded PHY causes scan and
connection issues when enabled. This patch disables it through
the existing quirk.
Signed-off-by: Christoffer Sandberg <[email protected]>
Signed-off-by: Werner Sembach <[email protected]>
Cc: <[email protected]>
---
drivers/bluetooth/btintel.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/bluetooth/btintel.c b/drivers/bluetooth/btintel.c
index cdc5c08824a0a..9f9c4696d082a 100644
--- a/drivers/bluetooth/btintel.c
+++ b/drivers/bluetooth/btintel.c
@@ -2881,6 +2881,9 @@ static int btintel_setup_combined(struct hci_dev *hdev)
case 0x17:
case 0x18:
case 0x19:
+ /* 0x17, 0x18 and 0x19 have issues when LE Coded PHY is enabled */
+ set_bit(HCI_QUIRK_BROKEN_LE_CODED, &hdev->quirks);
+ fallthrough;
case 0x1b:
case 0x1c:
/* Display version information of TLV type */
--
2.34.1
This is automated email and please do not reply to this email!
Dear submitter,
Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=842438
---Test result---
Test Summary:
CheckPatch PASS 0.65 seconds
GitLint PASS 0.30 seconds
SubjectPrefix PASS 0.12 seconds
BuildKernel PASS 29.94 seconds
CheckAllWarning PASS 32.60 seconds
CheckSparse PASS 38.16 seconds
CheckSmatch FAIL 34.65 seconds
BuildKernel32 PASS 28.83 seconds
TestRunnerSetup PASS 516.94 seconds
TestRunner_l2cap-tester PASS 18.33 seconds
TestRunner_iso-tester PASS 28.62 seconds
TestRunner_bnep-tester PASS 4.65 seconds
TestRunner_mgmt-tester PASS 111.11 seconds
TestRunner_rfcomm-tester PASS 7.21 seconds
TestRunner_sco-tester PASS 14.95 seconds
TestRunner_ioctl-tester PASS 7.75 seconds
TestRunner_mesh-tester PASS 5.73 seconds
TestRunner_smp-tester PASS 6.73 seconds
TestRunner_userchan-tester PASS 4.84 seconds
IncrementalBuild PASS 28.23 seconds
Details
##############################
Test: CheckSmatch - FAIL
Desc: Run smatch tool with source
Output:
Segmentation fault (core dumped)
make[4]: *** [scripts/Makefile.build:244: net/bluetooth/hci_core.o] Error 139
make[4]: *** Deleting file 'net/bluetooth/hci_core.o'
make[3]: *** [scripts/Makefile.build:485: net/bluetooth] Error 2
make[2]: *** [scripts/Makefile.build:485: net] Error 2
make[2]: *** Waiting for unfinished jobs....
Segmentation fault (core dumped)
make[4]: *** [scripts/Makefile.build:244: drivers/bluetooth/bcm203x.o] Error 139
make[4]: *** Deleting file 'drivers/bluetooth/bcm203x.o'
make[4]: *** Waiting for unfinished jobs....
make[3]: *** [scripts/Makefile.build:485: drivers/bluetooth] Error 2
make[2]: *** [scripts/Makefile.build:485: drivers] Error 2
make[1]: *** [/github/workspace/src/src/Makefile:1919: .] Error 2
make: *** [Makefile:240: __sub-make] Error 2
---
Regards,
Linux Bluetooth
Hi Werner,
On Mon, Apr 8, 2024 at 8:35 AM Werner Sembach <[email protected]> wrote:
>
> From: Christoffer Sandberg <[email protected]>
>
> For HW variants 0x17, 0x18 and 0x19 LE Coded PHY causes scan and
> connection issues when enabled. This patch disables it through
> the existing quirk.
Perhaps the following could be a proper fix for that:
https://patchwork.kernel.org/project/bluetooth/patch/[email protected]/
If you manage to test it please reply and add Tested-by to its thread.
> Signed-off-by: Christoffer Sandberg <[email protected]>
> Signed-off-by: Werner Sembach <[email protected]>
> Cc: <[email protected]>
> ---
> drivers/bluetooth/btintel.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/drivers/bluetooth/btintel.c b/drivers/bluetooth/btintel.c
> index cdc5c08824a0a..9f9c4696d082a 100644
> --- a/drivers/bluetooth/btintel.c
> +++ b/drivers/bluetooth/btintel.c
> @@ -2881,6 +2881,9 @@ static int btintel_setup_combined(struct hci_dev *hdev)
> case 0x17:
> case 0x18:
> case 0x19:
> + /* 0x17, 0x18 and 0x19 have issues when LE Coded PHY is enabled */
> + set_bit(HCI_QUIRK_BROKEN_LE_CODED, &hdev->quirks);
> + fallthrough;
> case 0x1b:
> case 0x1c:
> /* Display version information of TLV type */
> --
> 2.34.1
>
--
Luiz Augusto von Dentz