2024-04-08 13:39:37

by bluez.test.bot

[permalink] [raw]
Subject: RE: [v5] Bluetooth: compute LE flow credits based on recvbuf space

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=842452

---Test result---

Test Summary:
CheckPatch PASS 1.01 seconds
GitLint PASS 0.22 seconds
SubjectPrefix PASS 0.07 seconds
BuildKernel PASS 30.65 seconds
CheckAllWarning PASS 34.59 seconds
CheckSparse PASS 39.10 seconds
CheckSmatch FAIL 35.16 seconds
BuildKernel32 PASS 29.28 seconds
TestRunnerSetup PASS 528.76 seconds
TestRunner_l2cap-tester FAIL 22.63 seconds
TestRunner_iso-tester PASS 30.74 seconds
TestRunner_bnep-tester PASS 4.67 seconds
TestRunner_mgmt-tester FAIL 110.12 seconds
TestRunner_rfcomm-tester PASS 7.26 seconds
TestRunner_sco-tester PASS 14.97 seconds
TestRunner_ioctl-tester PASS 7.62 seconds
TestRunner_mesh-tester PASS 5.77 seconds
TestRunner_smp-tester PASS 6.78 seconds
TestRunner_userchan-tester PASS 4.93 seconds
IncrementalBuild PASS 28.60 seconds

Details
##############################
Test: CheckSmatch - FAIL
Desc: Run smatch tool with source
Output:

Segmentation fault (core dumped)
make[4]: *** [scripts/Makefile.build:244: net/bluetooth/hci_core.o] Error 139
make[4]: *** Deleting file 'net/bluetooth/hci_core.o'
make[3]: *** [scripts/Makefile.build:485: net/bluetooth] Error 2
make[2]: *** [scripts/Makefile.build:485: net] Error 2
make[2]: *** Waiting for unfinished jobs....
Segmentation fault (core dumped)
make[4]: *** [scripts/Makefile.build:244: drivers/bluetooth/bcm203x.o] Error 139
make[4]: *** Deleting file 'drivers/bluetooth/bcm203x.o'
make[4]: *** Waiting for unfinished jobs....
make[3]: *** [scripts/Makefile.build:485: drivers/bluetooth] Error 2
make[2]: *** [scripts/Makefile.build:485: drivers] Error 2
make[1]: *** [/github/workspace/src/src/Makefile:1919: .] Error 2
make: *** [Makefile:240: __sub-make] Error 2
##############################
Test: TestRunner_l2cap-tester - FAIL
Desc: Run l2cap-tester with test-runner
Output:
Total: 55, Passed: 51 (92.7%), Failed: 4, Not Run: 0

Failed Test Cases
L2CAP LE Server - Success Failed 0.099 seconds
L2CAP Ext-Flowctl Server - Success Failed 0.103 seconds
L2CAP LE EATT Server - Success Failed 0.103 seconds
L2CAP LE EATT Server - Reject Failed 0.091 seconds
##############################
Test: TestRunner_mgmt-tester - FAIL
Desc: Run mgmt-tester with test-runner
Output:
Total: 492, Passed: 489 (99.4%), Failed: 1, Not Run: 2

Failed Test Cases
LL Privacy - Add Device 7 (AL is full) Failed 0.195 seconds


---
Regards,
Linux Bluetooth


2024-04-10 14:51:23

by Luiz Augusto von Dentz

[permalink] [raw]
Subject: Re: [v5] Bluetooth: compute LE flow credits based on recvbuf space

Hi Sebastian,

On Mon, Apr 8, 2024 at 10:05 AM <[email protected]> wrote:
>
> This is automated email and please do not reply to this email!
>
> Dear submitter,
>
> Thank you for submitting the patches to the linux bluetooth mailing list.
> This is a CI test results with your patch series:
> PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=842452
>
> ---Test result---
>
> Test Summary:
> CheckPatch PASS 1.01 seconds
> GitLint PASS 0.22 seconds
> SubjectPrefix PASS 0.07 seconds
> BuildKernel PASS 30.65 seconds
> CheckAllWarning PASS 34.59 seconds
> CheckSparse PASS 39.10 seconds
> CheckSmatch FAIL 35.16 seconds
> BuildKernel32 PASS 29.28 seconds
> TestRunnerSetup PASS 528.76 seconds
> TestRunner_l2cap-tester FAIL 22.63 seconds
> TestRunner_iso-tester PASS 30.74 seconds
> TestRunner_bnep-tester PASS 4.67 seconds
> TestRunner_mgmt-tester FAIL 110.12 seconds
> TestRunner_rfcomm-tester PASS 7.26 seconds
> TestRunner_sco-tester PASS 14.97 seconds
> TestRunner_ioctl-tester PASS 7.62 seconds
> TestRunner_mesh-tester PASS 5.77 seconds
> TestRunner_smp-tester PASS 6.78 seconds
> TestRunner_userchan-tester PASS 4.93 seconds
> IncrementalBuild PASS 28.60 seconds
>
> Details
> ##############################
> Test: CheckSmatch - FAIL
> Desc: Run smatch tool with source
> Output:
>
> Segmentation fault (core dumped)
> make[4]: *** [scripts/Makefile.build:244: net/bluetooth/hci_core.o] Error 139
> make[4]: *** Deleting file 'net/bluetooth/hci_core.o'
> make[3]: *** [scripts/Makefile.build:485: net/bluetooth] Error 2
> make[2]: *** [scripts/Makefile.build:485: net] Error 2
> make[2]: *** Waiting for unfinished jobs....
> Segmentation fault (core dumped)
> make[4]: *** [scripts/Makefile.build:244: drivers/bluetooth/bcm203x.o] Error 139
> make[4]: *** Deleting file 'drivers/bluetooth/bcm203x.o'
> make[4]: *** Waiting for unfinished jobs....
> make[3]: *** [scripts/Makefile.build:485: drivers/bluetooth] Error 2
> make[2]: *** [scripts/Makefile.build:485: drivers] Error 2
> make[1]: *** [/github/workspace/src/src/Makefile:1919: .] Error 2
> make: *** [Makefile:240: __sub-make] Error 2
> ##############################
> Test: TestRunner_l2cap-tester - FAIL
> Desc: Run l2cap-tester with test-runner
> Output:
> Total: 55, Passed: 51 (92.7%), Failed: 4, Not Run: 0
>
> Failed Test Cases
> L2CAP LE Server - Success Failed 0.099 seconds
> L2CAP Ext-Flowctl Server - Success Failed 0.103 seconds
> L2CAP LE EATT Server - Success Failed 0.103 seconds
> L2CAP LE EATT Server - Reject Failed 0.091 seconds

We need to fix these tests as soon as we apply these changes, afaik
you said they are expected to change because the credit changes, so we
need to update it with the new credit logic. Also it would be great to
add a test case that covers the broken behavior where we dropped
packets.

> ##############################
> Test: TestRunner_mgmt-tester - FAIL
> Desc: Run mgmt-tester with test-runner
> Output:
> Total: 492, Passed: 489 (99.4%), Failed: 1, Not Run: 2
>
> Failed Test Cases
> LL Privacy - Add Device 7 (AL is full) Failed 0.195 seconds
>
>
> ---
> Regards,
> Linux Bluetooth
>


--
Luiz Augusto von Dentz

2024-04-22 14:00:47

by Luiz Augusto von Dentz

[permalink] [raw]
Subject: Re: [v5] Bluetooth: compute LE flow credits based on recvbuf space

Hi Sebastian,

On Wed, Apr 10, 2024 at 10:40 AM Luiz Augusto von Dentz
<[email protected]> wrote:
>
> Hi Sebastian,
>
> On Mon, Apr 8, 2024 at 10:05 AM <[email protected]> wrote:
> >
> > This is automated email and please do not reply to this email!
> >
> > Dear submitter,
> >
> > Thank you for submitting the patches to the linux bluetooth mailing list.
> > This is a CI test results with your patch series:
> > PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=842452
> >
> > ---Test result---
> >
> > Test Summary:
> > CheckPatch PASS 1.01 seconds
> > GitLint PASS 0.22 seconds
> > SubjectPrefix PASS 0.07 seconds
> > BuildKernel PASS 30.65 seconds
> > CheckAllWarning PASS 34.59 seconds
> > CheckSparse PASS 39.10 seconds
> > CheckSmatch FAIL 35.16 seconds
> > BuildKernel32 PASS 29.28 seconds
> > TestRunnerSetup PASS 528.76 seconds
> > TestRunner_l2cap-tester FAIL 22.63 seconds
> > TestRunner_iso-tester PASS 30.74 seconds
> > TestRunner_bnep-tester PASS 4.67 seconds
> > TestRunner_mgmt-tester FAIL 110.12 seconds
> > TestRunner_rfcomm-tester PASS 7.26 seconds
> > TestRunner_sco-tester PASS 14.97 seconds
> > TestRunner_ioctl-tester PASS 7.62 seconds
> > TestRunner_mesh-tester PASS 5.77 seconds
> > TestRunner_smp-tester PASS 6.78 seconds
> > TestRunner_userchan-tester PASS 4.93 seconds
> > IncrementalBuild PASS 28.60 seconds
> >
> > Details
> > ##############################
> > Test: CheckSmatch - FAIL
> > Desc: Run smatch tool with source
> > Output:
> >
> > Segmentation fault (core dumped)
> > make[4]: *** [scripts/Makefile.build:244: net/bluetooth/hci_core.o] Error 139
> > make[4]: *** Deleting file 'net/bluetooth/hci_core.o'
> > make[3]: *** [scripts/Makefile.build:485: net/bluetooth] Error 2
> > make[2]: *** [scripts/Makefile.build:485: net] Error 2
> > make[2]: *** Waiting for unfinished jobs....
> > Segmentation fault (core dumped)
> > make[4]: *** [scripts/Makefile.build:244: drivers/bluetooth/bcm203x.o] Error 139
> > make[4]: *** Deleting file 'drivers/bluetooth/bcm203x.o'
> > make[4]: *** Waiting for unfinished jobs....
> > make[3]: *** [scripts/Makefile.build:485: drivers/bluetooth] Error 2
> > make[2]: *** [scripts/Makefile.build:485: drivers] Error 2
> > make[1]: *** [/github/workspace/src/src/Makefile:1919: .] Error 2
> > make: *** [Makefile:240: __sub-make] Error 2
> > ##############################
> > Test: TestRunner_l2cap-tester - FAIL
> > Desc: Run l2cap-tester with test-runner
> > Output:
> > Total: 55, Passed: 51 (92.7%), Failed: 4, Not Run: 0
> >
> > Failed Test Cases
> > L2CAP LE Server - Success Failed 0.099 seconds
> > L2CAP Ext-Flowctl Server - Success Failed 0.103 seconds
> > L2CAP LE EATT Server - Success Failed 0.103 seconds
> > L2CAP LE EATT Server - Reject Failed 0.091 seconds
>
> We need to fix these tests as soon as we apply these changes, afaik
> you said they are expected to change because the credit changes, so we
> need to update it with the new credit logic. Also it would be great to
> add a test case that covers the broken behavior where we dropped
> packets.

Do you need some more feedback regarding these changes? Looks like you
stop responding for some time, I do think this is very important to
have it fixed.

> > ##############################
> > Test: TestRunner_mgmt-tester - FAIL
> > Desc: Run mgmt-tester with test-runner
> > Output:
> > Total: 492, Passed: 489 (99.4%), Failed: 1, Not Run: 2
> >
> > Failed Test Cases
> > LL Privacy - Add Device 7 (AL is full) Failed 0.195 seconds
> >
> >
> > ---
> > Regards,
> > Linux Bluetooth
> >
>
>
> --
> Luiz Augusto von Dentz



--
Luiz Augusto von Dentz