2024-01-09 13:09:15

by quic_zijuhu

[permalink] [raw]
Subject: [PATCH v1] Bluetooth: Remove 3 repeated macro definitions

Macros HCI_REQ_DONE, HCI_REQ_PEND and HCI_REQ_CANCELED are repeatedly
defined twice with hci_request.h, so remove a copy of definition.

Signed-off-by: Zijun Hu <[email protected]>
---
net/bluetooth/hci_request.h | 4 ----
1 file changed, 4 deletions(-)

diff --git a/net/bluetooth/hci_request.h b/net/bluetooth/hci_request.h
index 0be75cf0efed..c91f2838f542 100644
--- a/net/bluetooth/hci_request.h
+++ b/net/bluetooth/hci_request.h
@@ -29,10 +29,6 @@
#define hci_req_sync_lock(hdev) mutex_lock(&hdev->req_lock)
#define hci_req_sync_unlock(hdev) mutex_unlock(&hdev->req_lock)

-#define HCI_REQ_DONE 0
-#define HCI_REQ_PEND 1
-#define HCI_REQ_CANCELED 2
-
struct hci_request {
struct hci_dev *hdev;
struct sk_buff_head cmd_q;
--
2.7.4



2024-01-09 14:03:17

by bluez.test.bot

[permalink] [raw]
Subject: RE: [v1] Bluetooth: Remove 3 repeated macro definitions

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=815398

---Test result---

Test Summary:
CheckPatch PASS 0.61 seconds
GitLint PASS 0.32 seconds
SubjectPrefix PASS 0.13 seconds
BuildKernel PASS 27.51 seconds
CheckAllWarning PASS 30.20 seconds
CheckSparse PASS 35.92 seconds
CheckSmatch PASS 98.60 seconds
BuildKernel32 PASS 26.85 seconds
TestRunnerSetup PASS 432.81 seconds
TestRunner_l2cap-tester PASS 22.86 seconds
TestRunner_iso-tester PASS 49.00 seconds
TestRunner_bnep-tester PASS 6.83 seconds
TestRunner_mgmt-tester PASS 161.93 seconds
TestRunner_rfcomm-tester PASS 10.84 seconds
TestRunner_sco-tester PASS 14.50 seconds
TestRunner_ioctl-tester PASS 11.95 seconds
TestRunner_mesh-tester PASS 8.67 seconds
TestRunner_smp-tester PASS 9.78 seconds
TestRunner_userchan-tester PASS 7.20 seconds
IncrementalBuild PASS 26.02 seconds



---
Regards,
Linux Bluetooth

2024-04-22 14:52:19

by quic_zijuhu

[permalink] [raw]
Subject: [PATCH v1 RESEND] Bluetooth: Remove 3 repeated macro definitions

Macros HCI_REQ_DONE, HCI_REQ_PEND and HCI_REQ_CANCELED are repeatedly
defined twice with hci_request.h, so remove a copy of definition.

Signed-off-by: Zijun Hu <[email protected]>
---
net/bluetooth/hci_request.h | 4 ----
1 file changed, 4 deletions(-)

diff --git a/net/bluetooth/hci_request.h b/net/bluetooth/hci_request.h
index 0be75cf0efed..c91f2838f542 100644
--- a/net/bluetooth/hci_request.h
+++ b/net/bluetooth/hci_request.h
@@ -24,20 +24,16 @@

#define HCI_REQ_DONE 0
#define HCI_REQ_PEND 1
#define HCI_REQ_CANCELED 2

#define hci_req_sync_lock(hdev) mutex_lock(&hdev->req_lock)
#define hci_req_sync_unlock(hdev) mutex_unlock(&hdev->req_lock)

-#define HCI_REQ_DONE 0
-#define HCI_REQ_PEND 1
-#define HCI_REQ_CANCELED 2
-
struct hci_request {
struct hci_dev *hdev;
struct sk_buff_head cmd_q;

/* If something goes wrong when building the HCI request, the error
* value is stored in this field.
*/
int err;
--
2.7.4


2024-04-22 15:43:35

by bluez.test.bot

[permalink] [raw]
Subject: RE: [v1,RESEND] Bluetooth: Remove 3 repeated macro definitions

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=846708

---Test result---

Test Summary:
CheckPatch PASS 0.62 seconds
GitLint PASS 0.30 seconds
SubjectPrefix PASS 0.12 seconds
BuildKernel PASS 30.73 seconds
CheckAllWarning PASS 32.96 seconds
CheckSparse PASS 38.75 seconds
CheckSmatch FAIL 36.48 seconds
BuildKernel32 PASS 29.29 seconds
TestRunnerSetup PASS 529.07 seconds
TestRunner_l2cap-tester PASS 18.29 seconds
TestRunner_iso-tester PASS 31.04 seconds
TestRunner_bnep-tester PASS 4.69 seconds
TestRunner_mgmt-tester PASS 108.50 seconds
TestRunner_rfcomm-tester PASS 7.23 seconds
TestRunner_sco-tester PASS 14.93 seconds
TestRunner_ioctl-tester PASS 7.63 seconds
TestRunner_mesh-tester PASS 5.76 seconds
TestRunner_smp-tester PASS 6.75 seconds
TestRunner_userchan-tester PASS 4.87 seconds
IncrementalBuild PASS 28.11 seconds

Details
##############################
Test: CheckSmatch - FAIL
Desc: Run smatch tool with source
Output:

Segmentation fault (core dumped)
make[4]: *** [scripts/Makefile.build:244: net/bluetooth/hci_core.o] Error 139
make[4]: *** Deleting file 'net/bluetooth/hci_core.o'
make[3]: *** [scripts/Makefile.build:485: net/bluetooth] Error 2
make[2]: *** [scripts/Makefile.build:485: net] Error 2
make[2]: *** Waiting for unfinished jobs....
Segmentation fault (core dumped)
make[4]: *** [scripts/Makefile.build:244: drivers/bluetooth/bcm203x.o] Error 139
make[4]: *** Deleting file 'drivers/bluetooth/bcm203x.o'
make[4]: *** Waiting for unfinished jobs....
Segmentation fault (core dumped)
make[4]: *** [scripts/Makefile.build:244: drivers/bluetooth/bpa10x.o] Error 139
make[4]: *** Deleting file 'drivers/bluetooth/bpa10x.o'
make[3]: *** [scripts/Makefile.build:485: drivers/bluetooth] Error 2
make[2]: *** [scripts/Makefile.build:485: drivers] Error 2
make[1]: *** [/github/workspace/src/src/Makefile:1919: .] Error 2
make: *** [Makefile:240: __sub-make] Error 2


---
Regards,
Linux Bluetooth