2024-06-13 17:03:37

by Luiz Augusto von Dentz

[permalink] [raw]
Subject: [PATCH BlueZ v1] device: Fix marking device as temporary

From: Luiz Augusto von Dentz <[email protected]>

If bonding has failed but there are other bearers connected don't mark
the device as temporary.

Fixes: https://github.com/bluez/bluez/issues/856
---
src/device.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/src/device.c b/src/device.c
index 5dc1cd0cdbf2..486ffdb4ea8d 100644
--- a/src/device.c
+++ b/src/device.c
@@ -6428,7 +6428,8 @@ void device_bonding_complete(struct btd_device *device, uint8_t bdaddr_type,
/* Put the device back to the temporary state so that it will be
* treated as a newly discovered device.
*/
- if (!device_is_paired(device, bdaddr_type) &&
+ if (!btd_device_bearer_is_connected(device) &&
+ !device_is_paired(device, bdaddr_type) &&
!btd_device_is_trusted(device))
btd_device_set_temporary(device, true);

--
2.45.2



2024-06-13 18:45:05

by bluez.test.bot

[permalink] [raw]
Subject: RE: [BlueZ,v1] device: Fix marking device as temporary

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=861741

---Test result---

Test Summary:
CheckPatch PASS 0.49 seconds
GitLint PASS 0.34 seconds
BuildEll PASS 24.74 seconds
BluezMake PASS 1779.73 seconds
MakeCheck PASS 12.94 seconds
MakeDistcheck PASS 178.01 seconds
CheckValgrind PASS 251.64 seconds
CheckSmatch PASS 352.13 seconds
bluezmakeextell PASS 119.39 seconds
IncrementalBuild PASS 1681.50 seconds
ScanBuild PASS 1031.29 seconds



---
Regards,
Linux Bluetooth

2024-06-14 15:00:35

by patchwork-bot+bluetooth

[permalink] [raw]
Subject: Re: [PATCH BlueZ v1] device: Fix marking device as temporary

Hello:

This patch was applied to bluetooth/bluez.git (master)
by Luiz Augusto von Dentz <[email protected]>:

On Thu, 13 Jun 2024 13:03:13 -0400 you wrote:
> From: Luiz Augusto von Dentz <[email protected]>
>
> If bonding has failed but there are other bearers connected don't mark
> the device as temporary.
>
> Fixes: https://github.com/bluez/bluez/issues/856
>
> [...]

Here is the summary with links:
- [BlueZ,v1] device: Fix marking device as temporary
https://git.kernel.org/pub/scm/bluetooth/bluez.git/?id=48b7f7e5fe53

You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html