2015-10-01 12:56:22

by Mutharaju, Prasanna (P.)

Subject: [PATCH] bluetooth: bt3c_cs: clean up bt3c_cs driver code

From: Prasanna Karthik <[email protected]>

Patch fixes the checkpatch warnings:
- use linux/io.h instead of asm/io.h
- NULL comparison could be re-written

Signed-off-by: Prasanna Karthik <[email protected]>
---
drivers/bluetooth/bt3c_cs.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/bluetooth/bt3c_cs.c b/drivers/bluetooth/bt3c_cs.c
index 772a277..5597eef 100644
--- a/drivers/bluetooth/bt3c_cs.c
+++ b/drivers/bluetooth/bt3c_cs.c
@@ -39,7 +39,7 @@
#include <linux/serial.h>
#include <linux/serial_reg.h>
#include <linux/bitops.h>
-#include <asm/io.h>
+#include <linux/io.h>
=20
#include <linux/device.h>
#include <linux/firmware.h>
@@ -233,7 +233,7 @@ static void bt3c_receive(struct bt3c_info *info)
info->hdev->stat.byte_rx++;
=20
/* Allocate packet */
- if (info->rx_skb =3D=3D NULL) {
+ if (!info->rx_skb) {
info->rx_state =3D RECV_WAIT_PACKET_TYPE;
info->rx_count =3D 0;
info->rx_skb =3D bt_skb_alloc(HCI_MAX_FRAME_SIZE, GFP_ATOMIC);
--=20
1.9.1

2015-10-01 13:23:24

by Marcel Holtmann

Subject: Re: [PATCH] bluetooth: bt3c_cs: clean up bt3c_cs driver code

Hi Prasanna,

> Patch fixes the checkpatch warnings:
> - use linux/io.h instead of asm/io.h
> - NULL comparison could be re-written
>
> Signed-off-by: Prasanna Karthik <[email protected]>
> ---
> drivers/bluetooth/bt3c_cs.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)

the patch does not apply to bluetooth-next tree.

Regards

Marcel