2019-11-12 10:44:17

by Michał Lowas-Rzechonek

Subject: [PATCH BlueZ] mesh: Add missing property interface to node objects

---
mesh/node.c | 8 ++++++++
1 file changed, 8 insertions(+)

diff --git a/mesh/node.c b/mesh/node.c
index e23f32dd1..d2dff3a51 100644
--- a/mesh/node.c
+++ b/mesh/node.c
@@ -294,6 +294,10 @@ static void free_node_dbus_resources(struct mesh_node *node)

l_dbus_object_remove_interface(dbus_get_bus(), node->obj_path,
MESH_MANAGEMENT_INTERFACE);
+
+ l_dbus_object_remove_interface(dbus_get_bus(), node->obj_path,
+ L_DBUS_INTERFACE_PROPERTIES);
+
l_free(node->obj_path);
node->obj_path = NULL;
}
@@ -1156,6 +1160,10 @@ static bool register_node_object(struct mesh_node *node)
MESH_MANAGEMENT_INTERFACE, node))
return false;

+ if (!l_dbus_object_add_interface(dbus_get_bus(), node->obj_path,
+ L_DBUS_INTERFACE_PROPERTIES, NULL))
+ return false;
+
return true;
}

--
2.19.1

2019-11-13 17:24:38

by Gix, Brian

Subject: Re: [PATCH BlueZ] mesh: Add missing property interface to node objects

Applied with style-guide corrections:
Reduce max line length to <80 charactors

On Tue, 2019-11-12 at 11:43 +0100, Michał Lowas-Rzechonek wrote:
> ---
> mesh/node.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/mesh/node.c b/mesh/node.c
> index e23f32dd1..d2dff3a51 100644
> --- a/mesh/node.c
> +++ b/mesh/node.c
> @@ -294,6 +294,10 @@ static void free_node_dbus_resources(struct mesh_node *node)
>
> l_dbus_object_remove_interface(dbus_get_bus(), node->obj_path,
> MESH_MANAGEMENT_INTERFACE);
> +
> + l_dbus_object_remove_interface(dbus_get_bus(), node->obj_path,
> + L_DBUS_INTERFACE_PROPERTIES);
> +
> l_free(node->obj_path);
> node->obj_path = NULL;
> }
> @@ -1156,6 +1160,10 @@ static bool register_node_object(struct mesh_node *node)
> MESH_MANAGEMENT_INTERFACE, node))
> return false;
>
> + if (!l_dbus_object_add_interface(dbus_get_bus(), node->obj_path,
> + L_DBUS_INTERFACE_PROPERTIES, NULL))
> + return false;
> +
> return true;
> }
>

2019-11-13 19:59:55

by Michał Lowas-Rzechonek

Subject: Re: [PATCH BlueZ] mesh: Add missing property interface to node objects

On 11/13, Gix, Brian wrote:
> Applied with style-guide corrections:
> Reduce max line length to <80 charactors

Thanks, and sorry about the formatting.

--
Michał Lowas-Rzechonek <[email protected]>
Silvair http://silvair.com
Jasnogórska 44, 31-358 Krakow, POLAND