2022-05-22 22:53:46

by Linus Walleij

[permalink] [raw]
Subject: Re: [PATCH 1/2] dt-bindings: bluetooth: broadcom: Add BCM4349B1 DT binding

On Sat, May 21, 2022 at 10:07 PM Ahmad Fatoum <[email protected]> wrote:

> The BCM4349B1 chip is a single-chip Bluetooth 5.0 controller and
> Transceiver. It is contained in the CYW/BCM89359 WiFi+BT package.

So the BT and the package have two different names.

> + - brcm,bcm4349-bt

Then why do you have to tag on "-bt" on this compatible?

That is typically used when the wifi and bt has the *same* name, so
the only way to distinguish between them is a suffix.

Yours,
Linus Walleij


2022-05-23 06:31:26

by Ahmad Fatoum

[permalink] [raw]
Subject: Re: [PATCH 1/2] dt-bindings: bluetooth: broadcom: Add BCM4349B1 DT binding

On 22.05.22 23:03, Linus Walleij wrote:
> On Sat, May 21, 2022 at 10:07 PM Ahmad Fatoum <[email protected]> wrote:
>
>> The BCM4349B1 chip is a single-chip Bluetooth 5.0 controller and
>> Transceiver. It is contained in the CYW/BCM89359 WiFi+BT package.
>
> So the BT and the package have two different names.

The package also goes by the name BCM4349B1 apparently.
Cypress support had later confirmed BCM4349B1 and BCM89359 to
be the same chipset. I should probably rephrase the commit message.


>> + - brcm,bcm4349-bt
>
> Then why do you have to tag on "-bt" on this compatible?
>
> That is typically used when the wifi and bt has the *same* name, so
> the only way to distinguish between them is a suffix.
I think that's the case here too.

Cheers,
Ahmad

>
> Yours,
> Linus Walleij
>


--
Pengutronix e.K. | |
Steuerwalder Str. 21 | http://www.pengutronix.de/ |
31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |

2022-05-23 08:54:01

by Linus Walleij

[permalink] [raw]
Subject: Re: [PATCH 1/2] dt-bindings: bluetooth: broadcom: Add BCM4349B1 DT binding

On Mon, May 23, 2022 at 12:16 AM Ahmad Fatoum <[email protected]> wrote:
> On 22.05.22 23:03, Linus Walleij wrote:
> > On Sat, May 21, 2022 at 10:07 PM Ahmad Fatoum <[email protected]> wrote:
> >
> >> The BCM4349B1 chip is a single-chip Bluetooth 5.0 controller and
> >> Transceiver. It is contained in the CYW/BCM89359 WiFi+BT package.
> >
> > So the BT and the package have two different names.
>
> The package also goes by the name BCM4349B1 apparently.
> Cypress support had later confirmed BCM4349B1 and BCM89359 to
> be the same chipset. I should probably rephrase the commit message.
>
>
> >> + - brcm,bcm4349-bt
> >
> > Then why do you have to tag on "-bt" on this compatible?
> >
> > That is typically used when the wifi and bt has the *same* name, so
> > the only way to distinguish between them is a suffix.

> I think that's the case here too.

OK then!
Reviewed-by: Linus Walleij <[email protected]>

Yours,
Linus Walleij