2024-03-13 05:11:29

by Youwan Wang

[permalink] [raw]
Subject: [V1] Bluetooth: btusb: Add return error code

Add return error code

Signed-off-by: Youwan Wang <[email protected]>
---
drivers/bluetooth/btusb.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
index b8e9de887b5d..ec6bdc9687b1 100644
--- a/drivers/bluetooth/btusb.c
+++ b/drivers/bluetooth/btusb.c
@@ -2826,8 +2826,10 @@ static int btusb_mtk_hci_wmt_sync(struct hci_dev *hdev,
goto err_free_wc;
}

- if (data->evt_skb == NULL)
+ if (data->evt_skb == NULL) {
+ err = -ENOBUFS;
goto err_free_wc;
+ }

/* Parse and handle the return WMT event */
wmt_evt = (struct btmtk_hci_wmt_evt *)data->evt_skb->data;
--
2.25.1



2024-03-13 05:55:25

by bluez.test.bot

[permalink] [raw]
Subject: RE: [V1] Bluetooth: btusb: Add return error code

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=834847

---Test result---

Test Summary:
CheckPatch PASS 0.43 seconds
GitLint PASS 0.18 seconds
SubjectPrefix PASS 0.05 seconds
BuildKernel PASS 25.80 seconds
CheckAllWarning PASS 28.46 seconds
CheckSparse PASS 33.44 seconds
CheckSmatch PASS 92.12 seconds
BuildKernel32 PASS 25.18 seconds
TestRunnerSetup PASS 474.74 seconds
TestRunner_l2cap-tester PASS 17.45 seconds
TestRunner_iso-tester FAIL 29.03 seconds
TestRunner_bnep-tester PASS 4.48 seconds
TestRunner_mgmt-tester PASS 105.73 seconds
TestRunner_rfcomm-tester PASS 6.90 seconds
TestRunner_sco-tester PASS 14.49 seconds
TestRunner_ioctl-tester PASS 7.21 seconds
TestRunner_mesh-tester PASS 5.41 seconds
TestRunner_smp-tester PASS 6.46 seconds
TestRunner_userchan-tester PASS 4.62 seconds
IncrementalBuild PASS 24.31 seconds

Details
##############################
Test: TestRunner_iso-tester - FAIL
Desc: Run iso-tester with test-runner
Output:
Total: 117, Passed: 116 (99.1%), Failed: 1, Not Run: 0

Failed Test Cases
ISO Connect Suspend - Success Failed 4.154 seconds


---
Regards,
Linux Bluetooth

2024-03-13 07:19:18

by Paul Menzel

[permalink] [raw]
Subject: Re: [V1] Bluetooth: btusb: Add return error code

Dear Youwan,


Thank you for your patch. In the commit message summary/title maybe be
more specific:

Bluetooth: btusb: Set error code in btusb_mtk_hci_wmt_sync()

Am 13.03.24 um 06:11 schrieb Youwan Wang:
> Add return error code

Could you please elaborate and describe the problem?

> Signed-off-by: Youwan Wang <[email protected]>
> ---
> drivers/bluetooth/btusb.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
> index b8e9de887b5d..ec6bdc9687b1 100644
> --- a/drivers/bluetooth/btusb.c
> +++ b/drivers/bluetooth/btusb.c
> @@ -2826,8 +2826,10 @@ static int btusb_mtk_hci_wmt_sync(struct hci_dev *hdev,
> goto err_free_wc;
> }
>
> - if (data->evt_skb == NULL)
> + if (data->evt_skb == NULL) {
> + err = -ENOBUFS;
> goto err_free_wc;
> + }
>
> /* Parse and handle the return WMT event */
> wmt_evt = (struct btmtk_hci_wmt_evt *)data->evt_skb->data;


Kind regards,

Paul