2009-03-17 10:13:47

by alok barsode

[permalink] [raw]
Subject: [PATCH] Adding version check for plugins.

Hi Marcel,

As per the discussion on IRC, I am attaching a version check patch for plugins.

Let me know if anything needs modifications.

Cheers,
Alok.

Attachments:
0001-Adding-version-check-for-plugins.patch (4.93 kB)

2009-03-14 06:14:39

by Marcel Holtmann

[permalink] [raw]
Subject: Re: [PATCH] Adding version check for plugins.

Hi Alok,

I did say something about top-posting, right? Never ever do that.

> Thanks for spotting them, fixed.
> Attaching the modified patch.

Patch has been applied. Thanks.

Regards

Marcel



2009-03-17 13:29:06

by alok barsode

[permalink] [raw]
Subject: Re: [PATCH] Adding version check for plugins.

Luiz,

Thanks for spotting them, fixed.
Attaching the modified patch.


On Tue, Mar 17, 2009 at 6:52 PM, Luiz Augusto von Dentz
<[email protected]> wrote:
> Hi Alok,
>
> 2009/3/17 alok barsode <[email protected]>:
>> Hi Marcel,
>>
>> As per the discussion on IRC, I am attaching a version check patch for plugins.
>>
>> Let me know if anything needs modifications.
>>
>> Cheers,
>> Alok.
>>
>
> There are some trailing spaces around if (g_str_equal(desc->version,
> VERSION) == FALSE), could you please fix them.
>
> --
> Luiz Augusto von Dentz
> Engenheiro de Computa??o
>

Attachments:
0001-Adding-version-check-for-plugins.patch (4.94 kB)

2009-03-17 13:22:54

by Luiz Augusto von Dentz

[permalink] [raw]
Subject: Re: [PATCH] Adding version check for plugins.

Hi Alok,

2009/3/17 alok barsode <[email protected]>:
> Hi Marcel,
>
> As per the discussion on IRC, I am attaching a version check patch for plugins.
>
> Let me know if anything needs modifications.
>
> Cheers,
> Alok.
>

There are some trailing spaces around if (g_str_equal(desc->version,
VERSION) == FALSE), could you please fix them.

--
Luiz Augusto von Dentz
Engenheiro de Computa??o