2010-09-22 00:05:32

by Jaikumar Ganesh

Subject: [PATCH] Fix Headset Audio gateway SDP record.

Headset Audio Gateway does not have the Supported Features
in the SDP records according to the HSP specification.
---
tools/sdptool.c | 6 +-----
1 files changed, 1 insertions(+), 5 deletions(-)

diff --git a/tools/sdptool.c b/tools/sdptool.c
index d06b159..140a46a 100644
--- a/tools/sdptool.c
+++ b/tools/sdptool.c
@@ -1477,8 +1477,7 @@ static int add_headset_ag(sdp_session_t *session, svc_info_t *si)
sdp_list_t *aproto, *proto[2];
sdp_record_t record;
uint8_t u8 = si->channel ? si->channel : 7;
- uint16_t u16 = 0x17;
- sdp_data_t *channel, *features;
+ sdp_data_t *channel;
uint8_t netid = si->network ? si->network : 0x01; // ???? profile document
sdp_data_t *network = sdp_data_alloc(SDP_UINT8, &netid);
int ret = 0;
@@ -1511,9 +1510,6 @@ static int add_headset_ag(sdp_session_t *session, svc_info_t *si)
proto[1] = sdp_list_append(proto[1], channel);
apseq = sdp_list_append(apseq, proto[1]);

- features = sdp_data_alloc(SDP_UINT16, &u16);
- sdp_attr_add(&record, SDP_ATTR_SUPPORTED_FEATURES, features);
-
aproto = sdp_list_append(0, apseq);
sdp_set_access_protos(&record, aproto);

--
1.6.5.7

2010-09-22 07:22:22

by Johan Hedberg

Subject: Re: [PATCH] Fix Headset Audio gateway SDP record.

Hi Jaikumar,

On Tue, Sep 21, 2010, Jaikumar Ganesh wrote:
> Headset Audio Gateway does not have the Supported Features
> in the SDP records according to the HSP specification.
> ---
> tools/sdptool.c | 6 +-----
> 1 files changed, 1 insertions(+), 5 deletions(-)

Thanks. The patch has been pushed upstream.

Johan

2010-09-22 00:05:20

by Jaikumar Ganesh

Subject: Re: [PATCH] Fix Headset Audio gateway SDP record.

Please ignore. Sending again with a valid "to address".

On Tue, Sep 21, 2010 at 4:50 PM, <[email protected]> wrote:
> From: Jaikumar Ganesh <[email protected]>
>
> Headset Audio Gateway does not have the Supported Features
> in the SDP records according to the HSP specification.
> ---
> ?tools/sdptool.c | ? ?6 +-----
> ?1 files changed, 1 insertions(+), 5 deletions(-)
>
> diff --git a/tools/sdptool.c b/tools/sdptool.c
> index d06b159..140a46a 100644
> --- a/tools/sdptool.c
> +++ b/tools/sdptool.c
> @@ -1477,8 +1477,7 @@ static int add_headset_ag(sdp_session_t *session, svc_info_t *si)
> ? ? ? ?sdp_list_t *aproto, *proto[2];
> ? ? ? ?sdp_record_t record;
> ? ? ? ?uint8_t u8 = si->channel ? si->channel : 7;
> - ? ? ? uint16_t u16 = 0x17;
> - ? ? ? sdp_data_t *channel, *features;
> + ? ? ? sdp_data_t *channel;
> ? ? ? ?uint8_t netid = si->network ? si->network : 0x01; // ???? profile document
> ? ? ? ?sdp_data_t *network = sdp_data_alloc(SDP_UINT8, &netid);
> ? ? ? ?int ret = 0;
> @@ -1511,9 +1510,6 @@ static int add_headset_ag(sdp_session_t *session, svc_info_t *si)
> ? ? ? ?proto[1] = sdp_list_append(proto[1], channel);
> ? ? ? ?apseq = sdp_list_append(apseq, proto[1]);
>
> - ? ? ? features = sdp_data_alloc(SDP_UINT16, &u16);
> - ? ? ? sdp_attr_add(&record, SDP_ATTR_SUPPORTED_FEATURES, features);
> -
> ? ? ? ?aproto = sdp_list_append(0, apseq);
> ? ? ? ?sdp_set_access_protos(&record, aproto);
>
> --
> 1.6.5.7
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-bluetooth" in
> the body of a message to [email protected]
> More majordomo info at ?http://vger.kernel.org/majordomo-info.html
>