2011-01-26 11:21:55

by Pavan Savoy

[permalink] [raw]
Subject: [PATCH] plugins: hciops: remove scan disable on poweroff

From: Pavan Savoy <[email protected]>

remove sending of the scan disable command when the
device is being powered off.

Signed-off-by: Pavan Savoy <[email protected]>
---
plugins/hciops.c | 5 -----
1 files changed, 0 insertions(+), 5 deletions(-)

diff --git a/plugins/hciops.c b/plugins/hciops.c
index 719ef01..59a15a0 100644
--- a/plugins/hciops.c
+++ b/plugins/hciops.c
@@ -335,14 +335,9 @@ static int hciops_set_pairable(int index, gboolean pairable)
static int hciops_power_off(int index)
{
struct dev_info *dev = &devs[index];
- uint8_t mode = SCAN_DISABLED;

DBG("hci%d", index);

- if (hci_send_cmd(dev->sk, OGF_HOST_CTL,
- OCF_WRITE_SCAN_ENABLE, 1, &mode) < 0)
- return -errno;
-
if (ioctl(dev->sk, HCIDEVDOWN, index) < 0 && errno != EALREADY)
return -errno;

--
1.7.0.4



2011-01-26 12:39:38

by Pavan Savoy

[permalink] [raw]
Subject: Re: [PATCH] plugins: hciops: remove scan disable on poweroff

On Wed, Jan 26, 2011 at 5:06 PM, Johan Hedberg <[email protected]> wrote:
> Hi Pavan,
>
> On Wed, Jan 26, 2011, [email protected] wrote:
>> From: Pavan Savoy <[email protected]>
>>
>> remove sending of the scan disable command when the
>> device is being powered off.
>>
>> Signed-off-by: Pavan Savoy <[email protected]>
>> ---
>>  plugins/hciops.c |    5 -----
>>  1 files changed, 0 insertions(+), 5 deletions(-)
>
> Pushed upstream after I added some extra info to the commit message and
> removed the signed-off-by line (since we don't use that in user space).

Thanks Johan..

> Johan
>

2011-01-26 11:36:08

by Johan Hedberg

[permalink] [raw]
Subject: Re: [PATCH] plugins: hciops: remove scan disable on poweroff

Hi Pavan,

On Wed, Jan 26, 2011, [email protected] wrote:
> From: Pavan Savoy <[email protected]>
>
> remove sending of the scan disable command when the
> device is being powered off.
>
> Signed-off-by: Pavan Savoy <[email protected]>
> ---
> plugins/hciops.c | 5 -----
> 1 files changed, 0 insertions(+), 5 deletions(-)

Pushed upstream after I added some extra info to the commit message and
removed the signed-off-by line (since we don't use that in user space).

Johan

2011-01-26 11:26:31

by Pavan Savoy

[permalink] [raw]
Subject: Re: [PATCH] plugins: hciops: remove scan disable on poweroff

On Wed, Jan 26, 2011 at 4:46 PM, Johan Hedberg <[email protected]> wrote:
> Hi Pavan,
>
> On Tue, Jan 25, 2011, Pavan Savoy wrote:
>> From: Pavan Savoy <[email protected]>
>>
>> remove sending of the scan disable command when the
>> device is being powered off.
>>
>> Signed-off-by: Pavan Savoy <[email protected]>
>> ---
>>  plugins/hciops.c |    5 -----
>>  1 files changed, 0 insertions(+), 5 deletions(-)
>
> The patch seems to be corrupted (looks like the whitespace is messed
> up):
>
> Applying: plugins: hciops: remove scan disable on poweroff
> fatal: corrupt patch at line 10
> Patch failed at 0001 plugins: hciops: remove scan disable on poweroff
>
> Could you try re-sending it e.g. with git send-email?

Yes, have sent it now, may be it was corrupted because it was
forwarded from a mail which
got it via git send-email.
I wasn't registered to linux-bluetooth, with the mail ID with which i
have smtp ..

so I hope it's ok now..

> Johan
>

2011-01-26 11:16:17

by Johan Hedberg

[permalink] [raw]
Subject: Re: [PATCH] plugins: hciops: remove scan disable on poweroff

Hi Pavan,

On Tue, Jan 25, 2011, Pavan Savoy wrote:
> From: Pavan Savoy <[email protected]>
>
> remove sending of the scan disable command when the
> device is being powered off.
>
> Signed-off-by: Pavan Savoy <[email protected]>
> ---
> ?plugins/hciops.c | ? ?5 -----
> ?1 files changed, 0 insertions(+), 5 deletions(-)

The patch seems to be corrupted (looks like the whitespace is messed
up):

Applying: plugins: hciops: remove scan disable on poweroff
fatal: corrupt patch at line 10
Patch failed at 0001 plugins: hciops: remove scan disable on poweroff

Could you try re-sending it e.g. with git send-email?

Johan