2011-06-16 07:34:59

by Luiz Augusto von Dentz

Subject: [PATCH obexd] Fix build when pcsuite plugin is enabled

From: Luiz Augusto von Dentz <[email protected]>

Commit 4ae4f7c4949c6e53cd4c874c9cc533038cd03fb2 breakes the pcsuite
plugin by changing the .read API.
---
plugins/pcsuite.c | 6 +-----
1 files changed, 1 insertions(+), 5 deletions(-)

diff --git a/plugins/pcsuite.c b/plugins/pcsuite.c
index fc60114..125f25a 100644
--- a/plugins/pcsuite.c
+++ b/plugins/pcsuite.c
@@ -428,17 +428,13 @@ static int backup_close(void *object)
return 0;
}

-static ssize_t backup_read(void *object, void *buf, size_t count,
- uint8_t *hi, unsigned int *flags)
+static ssize_t backup_read(void *object, void *buf, size_t count, uint8_t *hi)
{
struct backup_object *obj = object;
ssize_t ret = 0;

*hi = OBEX_HDR_BODY;

- if (flags)
- *flags = 0;
-
if (obj->pending_call) {
DBG("cmd = %s, IN WAITING STAGE", obj->cmd);
return -EAGAIN;
--
1.7.5.4

2011-06-16 07:42:56

by Johan Hedberg

Subject: Re: [PATCH obexd] Fix build when pcsuite plugin is enabled

Hi Luiz,

On Thu, Jun 16, 2011, Luiz Augusto von Dentz wrote:
> Commit 4ae4f7c4949c6e53cd4c874c9cc533038cd03fb2 breakes the pcsuite
> plugin by changing the .read API.
> ---
> plugins/pcsuite.c | 6 +-----
> 1 files changed, 1 insertions(+), 5 deletions(-)

Applied. Thanks.

Johan

2011-06-16 07:42:38

by Slawomir Bochenski

Subject: Re: [PATCH obexd] Fix build when pcsuite plugin is enabled

On Thu, Jun 16, 2011 at 9:34 AM, Luiz Augusto von Dentz
<[email protected]> wrote:
> Commit 4ae4f7c4949c6e53cd4c874c9cc533038cd03fb2 breakes the pcsuite
> plugin by changing the .read API.

Ouch! Somehow I've missed that one.

--
Slawomir Bochenski