Hey!
I stopped converting profiles to DBus.Properties due to some reasons
like 1) lack of time; 2) I don't use or can't test the conversion or
3) I'm seeing a lots of patches to that profile and my changes would
conflict.
Here is a list of missing profiles (except audio):
└ bluez ➤ git grep -l GetProperties | grep -e " | grep -v -e "^audio"
attrib/client.c
profiles/cups/main.c
profiles/network/connection.c
profiles/proximity/monitor.c
profiles/proximity/reporter.c
profiles/thermometer/thermometer.c
Most of them are trivial and mostly a manual conversion job. These
fall in categories (1) and (2) above. If no one interested in that
profiles does the conversion, I'll try my best to convert them, but
I'd like they to at least check/ack the changes.
And the audio ones, in category (1) and (3) above:
└ bluez ➤ git grep -l GetProperties | grep -e " | grep -v -e "^audio"
audio/device.c
audio/gateway.c
audio/gstavdtpsink.c
audio/headset.c
audio/player.c
audio/sink.c
audio/source.c
audio/telephony-ofono.c
audio/transport.c
Luiz, do you plan to convert to DBus.Properties after you finish the
pending features you are doing? I think audio/transport.c is the only
one still requiring a feature in gdbus: security check for the sender
as discussed previously. I can add this when we are converting audio.
Anyone to step up and help to finish the conversions? The sooner these
are finished, the sooner other projects can adapt themselves to the
upcoming API.
Lucas De Marchi
Hi,
On Wed, Nov 7, 2012 at 11:34 PM, Luiz Augusto von Dentz
<[email protected]> wrote:
> Hi Lucas,
>
> On Wed, Nov 7, 2012 at 9:20 PM, Lucas De Marchi
> <[email protected]> wrote:
>> Luiz, do you plan to convert to DBus.Properties after you finish the
>> pending features you are doing? I think audio/transport.c is the only
>> one still requiring a feature in gdbus: security check for the sender
>> as discussed previously. I can add this when we are converting audio.
>
> I can take care of converting the audio after we move it to profiles,
> and yes we need the sender check for in gdbus, but that can come
> latter.
I agree that we need to move to the new profile infrastructure first.
Some of these D-Bus interfaces might even disappear completely
(Headset, AudioSink, etc.), to be replaced by the generic
profile-handling API.
I sent some related patches in a previous RFC, which I will resend now
focusing on the audio part only.
Cheers,
Mikel
Hi Lucas,
On Wed, Nov 7, 2012 at 9:20 PM, Lucas De Marchi
<[email protected]> wrote:
> Luiz, do you plan to convert to DBus.Properties after you finish the
> pending features you are doing? I think audio/transport.c is the only
> one still requiring a feature in gdbus: security check for the sender
> as discussed previously. I can add this when we are converting audio.
I can take care of converting the audio after we move it to profiles,
and yes we need the sender check for in gdbus, but that can come
latter.
--
Luiz Augusto von Dentz
Hi Lucas,
On Wed, Nov 7, 2012 at 8:20 PM, Lucas De Marchi
<[email protected]> wrote:
> Hey!
>
> I stopped converting profiles to DBus.Properties due to some reasons
> like 1) lack of time; 2) I don't use or can't test the conversion or
> 3) I'm seeing a lots of patches to that profile and my changes would
> conflict.
>
>
> Here is a list of missing profiles (except audio):
> └ bluez ➤ git grep -l GetProperties | grep -e " | grep -v -e "^audio"
> attrib/client.c
> profiles/cups/main.c
> profiles/network/connection.c
> profiles/proximity/monitor.c
> profiles/proximity/reporter.c
> profiles/thermometer/thermometer.c
<snip>
> Anyone to step up and help to finish the conversions? The sooner these
> are finished, the sooner other projects can adapt themselves to the
> upcoming API.
I have patches for thermometer (together with some other changes
there) - just need to test them and will send soon.
BR,
Andrzej