2017-07-08 14:43:41

by Leif Liddy

Subject: [RFC PATCH] Bluetooth: btusb: fix QCA Rome suspend/resume

this is an reference to:
https://bugzilla.kernel.org/show_bug.cgi?id=193571

There's been numerous reported instances where BTUSB_QCA_ROME
bluetooth controllers stop functioning upon resume from suspend. These
devices seem to be losing power during suspend. Patch will detect a
status change on resume and perform a reset.

**patch below is based on this previous patch that affected Realtek
btusb devices
http://www.spinics.net/lists/linux-bluetooth/msg61943.html


diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
index fa24d69..2503709 100644
--- a/drivers/bluetooth/btusb.c
+++ b/drivers/bluetooth/btusb.c
@@ -3067,6 +3067,12 @@ static int btusb_probe(struct usb_interface *intf,
if (id->driver_info & BTUSB_QCA_ROME) {
data->setup_on_usb = btusb_setup_qca;
hdev->set_bdaddr = btusb_set_bdaddr_ath3012;
+
+ /* QCA Rome devices lose their updated firmware over suspend,
+ * but the USB hub doesn't notice any status change.
+ * Explicitly request a device reset on resume.
+ */
+ set_bit(BTUSB_RESET_RESUME, &data->flags);
}

#ifdef CONFIG_BT_HCIBTUSB_RTL

2017-07-08 17:38:36

by Marcel Holtmann

Subject: Re: [RFC PATCH] Bluetooth: btusb: fix QCA Rome suspend/resume

Hi Leif,

> this is an reference to:
> https://bugzilla.kernel.org/show_bug.cgi?id=193571
>
> There's been numerous reported instances where BTUSB_QCA_ROME
> bluetooth controllers stop functioning upon resume from suspend. These
> devices seem to be losing power during suspend. Patch will detect a
> status change on resume and perform a reset.
>
> **patch below is based on this previous patch that affected Realtek
> btusb devices
> http://www.spinics.net/lists/linux-bluetooth/msg61943.html
>
>
> diff --git a/drivers/bluetooth/btusb.c b/drivers/bluetooth/btusb.c
> index fa24d69..2503709 100644
> --- a/drivers/bluetooth/btusb.c
> +++ b/drivers/bluetooth/btusb.c
> @@ -3067,6 +3067,12 @@ static int btusb_probe(struct usb_interface *intf,
> if (id->driver_info & BTUSB_QCA_ROME) {
> data->setup_on_usb = btusb_setup_qca;
> hdev->set_bdaddr = btusb_set_bdaddr_ath3012;
> +
> + /* QCA Rome devices lose their updated firmware over suspend,
> + * but the USB hub doesn't notice any status change.
> + * Explicitly request a device reset on resume.
> + */
> + set_bit(BTUSB_RESET_RESUME, &data->flags);
> }

this is all mangled up with spaces.

Regards

Marcel