Hi,
Since we now have a proper library for SBC codec
(http://git.kernel.org/?p=bluetooth/sbc.git;a=summary) and its patent
has expired June 2, 2010. (source:
http://en.wikipedia.org/wiki/SBC_(codec)), I wonder if it wouldn't be
a good idea to move the plugin to gstreamer tree?
The plugin has the following elements:
bluetooth: sbcenc: Bluetooth SBC encoder
bluetooth: sbcdec: Bluetooth SBC decoder
bluetooth: sbcparse: Bluetooth SBC parser
bluetooth: avdtpsink: Bluetooth AVDTP sink
bluetooth: a2dpsink: Bluetooth A2DP sink
bluetooth: rtpsbcpay: RTP packet payloader
--
Luiz Augusto von Dentz
Hi Tim,
> > Since we now have a proper library for SBC codec
> > (http://git.kernel.org/?p=bluetooth/sbc.git;a=summary) and its patent
> > has expired June 2, 2010. (source:
> > http://en.wikipedia.org/wiki/SBC_(codec)), I wonder if it wouldn't be
> > a good idea to move the plugin to gstreamer tree?
> >
> > The plugin has the following elements:
> >
> > bluetooth: sbcenc: Bluetooth SBC encoder
> > bluetooth: sbcdec: Bluetooth SBC decoder
> > bluetooth: sbcparse: Bluetooth SBC parser
> > bluetooth: avdtpsink: Bluetooth AVDTP sink
> > bluetooth: a2dpsink: Bluetooth A2DP sink
> > bluetooth: rtpsbcpay: RTP packet payloader
>
> Sounds like a good idea to me.
>
> We'd probably add them to gst-plugins-bad first though, since that's
> where new plugins are usually added before they get moved to -good or
> elsewhere. And probably only to git master (ie. for the upcoming
> 0.11/1.0 API version).
>
> Would the idea be that you'd turn libsbc from noinst into a proper
> library, or would we just move that over into the plugin as well?
as Luiz pointed out, that has already been done. It is standalone now
with its own GIT tree and a released 1.0 tarball for distributions to
package.
Regards
Marcel
On Thu, Aug 16, 2012 at 2:09 PM, Tim-Philipp Müller <[email protected]> wrote:
> On Thu, 2012-08-16 at 16:25 +0300, Luiz Augusto von Dentz wrote:
>
> Hi,
>
>> Since we now have a proper library for SBC codec
>> (http://git.kernel.org/?p=bluetooth/sbc.git;a=summary) and its patent
>> has expired June 2, 2010. (source:
>> http://en.wikipedia.org/wiki/SBC_(codec)), I wonder if it wouldn't be
>> a good idea to move the plugin to gstreamer tree?
>>
>> The plugin has the following elements:
>>
>> bluetooth: sbcenc: Bluetooth SBC encoder
>> bluetooth: sbcdec: Bluetooth SBC decoder
>> bluetooth: sbcparse: Bluetooth SBC parser
>> bluetooth: avdtpsink: Bluetooth AVDTP sink
>> bluetooth: a2dpsink: Bluetooth A2DP sink
>> bluetooth: rtpsbcpay: RTP packet payloader
>
> Sounds like a good idea to me.
>
> We'd probably add them to gst-plugins-bad first though, since that's
> where new plugins are usually added before they get moved to -good or
> elsewhere. And probably only to git master (ie. for the upcoming
> 0.11/1.0 API version).
>
> Would the idea be that you'd turn libsbc from noinst into a proper
> library, or would we just move that over into the plugin as well?
>
It will be a shared lib, also used by pulseaudio's bluetooth modules.
--
João Paulo Rechi Vita
Openbossa Labs - INdT
On Thu, 2012-08-16 at 16:25 +0300, Luiz Augusto von Dentz wrote:
Hi,
> Since we now have a proper library for SBC codec
> (http://git.kernel.org/?p=bluetooth/sbc.git;a=summary) and its patent
> has expired June 2, 2010. (source:
> http://en.wikipedia.org/wiki/SBC_(codec)), I wonder if it wouldn't be
> a good idea to move the plugin to gstreamer tree?
>
> The plugin has the following elements:
>
> bluetooth: sbcenc: Bluetooth SBC encoder
> bluetooth: sbcdec: Bluetooth SBC decoder
> bluetooth: sbcparse: Bluetooth SBC parser
> bluetooth: avdtpsink: Bluetooth AVDTP sink
> bluetooth: a2dpsink: Bluetooth A2DP sink
> bluetooth: rtpsbcpay: RTP packet payloader
Sounds like a good idea to me.
We'd probably add them to gst-plugins-bad first though, since that's
where new plugins are usually added before they get moved to -good or
elsewhere. And probably only to git master (ie. for the upcoming
0.11/1.0 API version).
Would the idea be that you'd turn libsbc from noinst into a proper
library, or would we just move that over into the plugin as well?
Cheers
- Tim
On Thu, 2012-11-08 at 17:20 +0200, Luiz Augusto von Dentz wrote:
Hi Luiz,
> Im about to send a patch to remove this from BlueZ, I hope somebody
> from gstreamer community can step up and take the task to move this to
> gstreamer tree, if nobody does I will eventually do it but this might
> take some time for me since Im quite busy with upcoming BlueZ 5.0
> (which is also the reason why we are cleaning up the tree).
This is the plan for the current GStreamer dev cycle (1.1.x) [0], so
should happen really soon now. (I'll do it if no one else is faster.)
Cheers
-Tim
[0] http://gstreamer.freedesktop.org/wiki/ReleasePlanning/RoadMap
Hi Guys,
On Fri, Aug 17, 2012 at 12:26 PM, sreerenj b <[email protected]> wrote:
> Hi Tim,
>
> Are you planning to integrate bluez-gstreamer to plugsin-bad? or some new
> plugins for sbc?
>
>
> On Fri, Aug 17, 2012 at 6:13 AM, Marcel Holtmann <[email protected]>
> wrote:
>>
>> Hi Tim,
>>
>> > > Since we now have a proper library for SBC codec
>> > > (http://git.kernel.org/?p=bluetooth/sbc.git;a=summary) and its patent
>> > > has expired June 2, 2010. (source:
>> > > http://en.wikipedia.org/wiki/SBC_(codec)), I wonder if it wouldn't be
>> > > a good idea to move the plugin to gstreamer tree?
>> > >
>> > > The plugin has the following elements:
>> > >
>> > > bluetooth: sbcenc: Bluetooth SBC encoder
>> > > bluetooth: sbcdec: Bluetooth SBC decoder
>> > > bluetooth: sbcparse: Bluetooth SBC parser
>> > > bluetooth: avdtpsink: Bluetooth AVDTP sink
>> > > bluetooth: a2dpsink: Bluetooth A2DP sink
>> > > bluetooth: rtpsbcpay: RTP packet payloader
>> >
>> > Sounds like a good idea to me.
>> >
>> > We'd probably add them to gst-plugins-bad first though, since that's
>> > where new plugins are usually added before they get moved to -good or
>> > elsewhere. And probably only to git master (ie. for the upcoming
>> > 0.11/1.0 API version).
>> >
>> > Would the idea be that you'd turn libsbc from noinst into a proper
>> > library, or would we just move that over into the plugin as well?
>>
>> as Luiz pointed out, that has already been done. It is standalone now
>> with its own GIT tree and a released 1.0 tarball for distributions to
>> package.
>>
>> Regards
>>
>> Marcel
Im about to send a patch to remove this from BlueZ, I hope somebody
from gstreamer community can step up and take the task to move this to
gstreamer tree, if nobody does I will eventually do it but this might
take some time for me since Im quite busy with upcoming BlueZ 5.0
(which is also the reason why we are cleaning up the tree).
--
Luiz Augusto von Dentz