2011-08-02 08:18:01

by Min Jun,Xi

[permalink] [raw]
Subject: Regarding to TI WL1283 support in the "hciattach" command

Hi All,

Recently, I got one TI WL1283 devkit, which is not supported in the
current bluez code. When I am trying to attach it to my ubuntu desktop
by running the
"hciattach ttyUSB0 texasalt 115200"
command, I failed because "wl1283" can not be recognized.
In order to make it work, I read through the code in
"tools/hciattach_tialt.c", and made several code changes in
"texasalt_init()" function. And here is the diff:

index 1ba009c..2514ee0 100644
--- a/tools/hciattach_tialt.c
+++ b/tools/hciattach_tialt.c
@@ -211,7 +211,7 @@ int texasalt_init(int fd, int speed, struct termios *ti)
{
unsigned short lmp_subv = resp[13] | (resp[14] << 8);
unsigned short brf_chip = (lmp_subv & 0x7c00) >> 10;
- static const char *c_brf_chip[8] = {
+ static const char *c_brf_chip[11] = {
"unknown",
"unknown",
"brf6100",
@@ -219,7 +219,10 @@ int texasalt_init(int fd, int speed, struct termios *ti)
"brf6300",
"brf6350",
"unknown",
- "wl1271"
+ "wl1271",
+ "unknown",
+ "unknown",
+ "wl1283"
};
char fw[100];

@@ -231,7 +234,7 @@ int texasalt_init(int fd, int speed, struct termios *ti)
"\tchip: %s (%d)\n",
lmp_subv & 0x7f,
((lmp_subv & 0x8000) >> (15-3)) |
((lmp_subv & 0x380) >> 7),
- ((brf_chip > 7) ? "unknown" :
c_brf_chip[brf_chip]),
+ ((brf_chip > 10) ? "unknown" :
c_brf_chip[brf_chip]),
brf_chip);

sprintf(fw, "/etc/firmware/%s.bin", c_brf_chip[brf_chip]);

Is there anybody from TI can update the code to support WL1283? Or can
I commit the code to bluez? Thank you!

--
best regards,
Xi Minjun


2011-08-02 13:11:34

by Ganir, Chen

[permalink] [raw]
Subject: RE: Regarding to TI WL1283 support in the "hciattach" command

SGkgWGkgTWluanVuLg0KDQpJcyB0aGVyZSBhIHJlYXNvbiBmb3IgdXNpbmcgdGhlIHRleGFzYWx0
ID8gSSd2ZSBhbHdheXMgdXNlZCB0aGUgdGV4YXMgY29tbWFuZCBhbmQgaXQgd29ya2VkLg0KDQpJ
J3ZlIGJlZW4gdXNpbmcgdGhlIHdsMTI4MyBhbmQgdGhlIHdsMTI3MyB3aXRoIHRoZSBoY2lhdHRh
Y2gsIHdpdGggdGhlIGZvbGxvd2luZyBjb21tYW5kIDoNCnN1ZG8gaGNpYXR0YWNoIC1uIC9kZXYv
dHR5VVNCMCB0ZXhhcyAxMTUyMDAgLXQgMTAwMDANCg0KdGhlIC10IDEwMDAwIG1heSBub3QgYmUg
bmVlZGVkLCBkZXBlbmRpbmcgb24gdGhlIFRJIEluaXQgc2NyaXB0IHlvdSBhcmUgdXNpbmcuDQoN
CkluIGFkZGl0aW9uIG9mIGNvdXJzZSwgeW91IHdpbGwgbmVlZCB0byBwdXQgdGhlIFRJSW5pdF8x
MC54LnkuYnRzIGluIC9saWIvZmlybXdhcmUuDQoNCg0KVGhhbmtzLA0KQ2hlbiBHYW5pcg0KDQoN
Cj4gLS0tLS1PcmlnaW5hbCBNZXNzYWdlLS0tLS0NCj4gRnJvbTogbGludXgtYmx1ZXRvb3RoLW93
bmVyQHZnZXIua2VybmVsLm9yZyBbbWFpbHRvOmxpbnV4LWJsdWV0b290aC0NCj4gb3duZXJAdmdl
ci5rZXJuZWwub3JnXSBPbiBCZWhhbGYgT2YgTWluIEp1bixYaQ0KPiBTZW50OiBUdWVzZGF5LCBB
dWd1c3QgMDIsIDIwMTEgMTE6MTggQU0NCj4gVG86IGxpbnV4LWJsdWV0b290aEB2Z2VyLmtlcm5l
bC5vcmcNCj4gU3ViamVjdDogUmVnYXJkaW5nIHRvIFRJIFdMMTI4MyBzdXBwb3J0IGluIHRoZSAi
aGNpYXR0YWNoIiBjb21tYW5kDQo+IA0KPiBIaSBBbGwsDQo+IA0KPiBSZWNlbnRseSwgSSBnb3Qg
b25lIFRJIFdMMTI4MyBkZXZraXQsIHdoaWNoIGlzIG5vdCBzdXBwb3J0ZWQgaW4gdGhlDQo+IGN1
cnJlbnQgYmx1ZXogY29kZS4gV2hlbiBJIGFtIHRyeWluZyB0byBhdHRhY2ggaXQgdG8gbXkgdWJ1
bnR1IGRlc2t0b3ANCj4gYnkgcnVubmluZyB0aGUNCj4gICAgICJoY2lhdHRhY2ggdHR5VVNCMCB0
ZXhhc2FsdCAxMTUyMDAiDQo+IGNvbW1hbmQsIEkgZmFpbGVkIGJlY2F1c2UgIndsMTI4MyIgY2Fu
IG5vdCBiZSByZWNvZ25pemVkLg0KPiBJbiBvcmRlciB0byBtYWtlIGl0IHdvcmssIEkgcmVhZCB0
aHJvdWdoIHRoZSBjb2RlIGluDQo+ICJ0b29scy9oY2lhdHRhY2hfdGlhbHQuYyIsIGFuZCBtYWRl
IHNldmVyYWwgY29kZSBjaGFuZ2VzIGluDQo+ICJ0ZXhhc2FsdF9pbml0KCkiIGZ1bmN0aW9uLiBB
bmQgaGVyZSBpcyB0aGUgZGlmZjoNCj4gDQo+IGluZGV4IDFiYTAwOWMuLjI1MTRlZTAgMTAwNjQ0
DQo+IC0tLSBhL3Rvb2xzL2hjaWF0dGFjaF90aWFsdC5jDQo+ICsrKyBiL3Rvb2xzL2hjaWF0dGFj
aF90aWFsdC5jDQo+IEBAIC0yMTEsNyArMjExLDcgQEAgaW50IHRleGFzYWx0X2luaXQoaW50IGZk
LCBpbnQgc3BlZWQsIHN0cnVjdCB0ZXJtaW9zDQo+ICp0aSkNCj4gICAgICAgICB7DQo+ICAgICAg
ICAgICAgICAgICB1bnNpZ25lZCBzaG9ydCBsbXBfc3VidiA9IHJlc3BbMTNdIHwgKHJlc3BbMTRd
IDw8IDgpOw0KPiAgICAgICAgICAgICAgICAgdW5zaWduZWQgc2hvcnQgYnJmX2NoaXAgPSAobG1w
X3N1YnYgJiAweDdjMDApID4+IDEwOw0KPiAtICAgICAgICAgICAgICAgc3RhdGljIGNvbnN0IGNo
YXIgKmNfYnJmX2NoaXBbOF0gPSB7DQo+ICsgICAgICAgICAgICAgICBzdGF0aWMgY29uc3QgY2hh
ciAqY19icmZfY2hpcFsxMV0gPSB7DQo+ICAgICAgICAgICAgICAgICAgICAgICAgICJ1bmtub3du
IiwNCj4gICAgICAgICAgICAgICAgICAgICAgICAgInVua25vd24iLA0KPiAgICAgICAgICAgICAg
ICAgICAgICAgICAiYnJmNjEwMCIsDQo+IEBAIC0yMTksNyArMjE5LDEwIEBAIGludCB0ZXhhc2Fs
dF9pbml0KGludCBmZCwgaW50IHNwZWVkLCBzdHJ1Y3QNCj4gdGVybWlvcyAqdGkpDQo+ICAgICAg
ICAgICAgICAgICAgICAgICAgICJicmY2MzAwIiwNCj4gICAgICAgICAgICAgICAgICAgICAgICAg
ImJyZjYzNTAiLA0KPiAgICAgICAgICAgICAgICAgICAgICAgICAidW5rbm93biIsDQo+IC0gICAg
ICAgICAgICAgICAgICAgICAgICJ3bDEyNzEiDQo+ICsgICAgICAgICAgICAgICAgICAgICAgICJ3
bDEyNzEiLA0KPiArICAgICAgICAgICAgICAgICAgICAgICAidW5rbm93biIsDQo+ICsgICAgICAg
ICAgICAgICAgICAgICAgICJ1bmtub3duIiwNCj4gKyAgICAgICAgICAgICAgICAgICAgICAgInds
MTI4MyINCj4gICAgICAgICAgICAgICAgIH07DQo+ICAgICAgICAgICAgICAgICBjaGFyIGZ3WzEw
MF07DQo+IA0KPiBAQCAtMjMxLDcgKzIzNCw3IEBAIGludCB0ZXhhc2FsdF9pbml0KGludCBmZCwg
aW50IHNwZWVkLCBzdHJ1Y3QgdGVybWlvcw0KPiAqdGkpDQo+ICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICAgIlx0Y2hpcDogJXMgKCVkKVxuIiwNCj4gICAgICAgICAgICAgICAgICAgICAg
ICAgICAgICAgICBsbXBfc3VidiAmIDB4N2YsDQo+ICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgICAgKChsbXBfc3VidiAmIDB4ODAwMCkgPj4gKDE1LTMpKSB8DQo+ICgobG1wX3N1YnYgJiAw
eDM4MCkgPj4gNyksDQo+IC0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKChicmZfY2hp
cCA+IDcpID8gInVua25vd24iIDoNCj4gY19icmZfY2hpcFticmZfY2hpcF0pLA0KPiArICAgICAg
ICAgICAgICAgICAgICAgICAgICAgICAgICgoYnJmX2NoaXAgPiAxMCkgPyAidW5rbm93biIgOg0K
PiBjX2JyZl9jaGlwW2JyZl9jaGlwXSksDQo+ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg
ICAgYnJmX2NoaXApOw0KPiANCj4gICAgICAgICAgICAgICAgIHNwcmludGYoZncsICIvZXRjL2Zp
cm13YXJlLyVzLmJpbiIsDQo+IGNfYnJmX2NoaXBbYnJmX2NoaXBdKTsNCj4gDQo+IElzIHRoZXJl
IGFueWJvZHkgZnJvbSBUSSBjYW4gdXBkYXRlIHRoZSBjb2RlIHRvIHN1cHBvcnQgV0wxMjgzPyBP
ciBjYW4NCj4gSSBjb21taXQgdGhlIGNvZGUgdG8gYmx1ZXo/IFRoYW5rIHlvdSENCj4gDQo+IC0t
DQo+IGJlc3QgcmVnYXJkcywNCj4gWGkgTWluanVuDQo+IC0tDQo+IFRvIHVuc3Vic2NyaWJlIGZy
b20gdGhpcyBsaXN0OiBzZW5kIHRoZSBsaW5lICJ1bnN1YnNjcmliZSBsaW51eC0NCj4gYmx1ZXRv
b3RoIiBpbg0KPiB0aGUgYm9keSBvZiBhIG1lc3NhZ2UgdG8gbWFqb3Jkb21vQHZnZXIua2VybmVs
Lm9yZw0KPiBNb3JlIG1ham9yZG9tbyBpbmZvIGF0ICBodHRwOi8vdmdlci5rZXJuZWwub3JnL21h
am9yZG9tby1pbmZvLmh0bWwNCg==