2011-08-03 22:20:38

by Daniele Forsi

Subject: [PATCH obexd] Fix compilation when NEED_G_SLIST_FREE_FULL is defined

From: Daniele Forsi <[email protected]>

To use the replacement for g_slist_free_full() both compat.h and
glib-helper.h need to be included.

Fixes:
gobex/gobex.c:911: error: implicit declaration of function 'g_slist_free_full'
tools/test-server.c:344: error: implicit declaration of function ‘g_slist_free_full’
---
gobex/gobex.c | 5 +++++
tools/test-server.c | 4 ++++
2 files changed, 9 insertions(+), 0 deletions(-)

diff --git a/gobex/gobex.c b/gobex/gobex.c
index 2a64849..ff35830 100644
--- a/gobex/gobex.c
+++ b/gobex/gobex.c
@@ -19,11 +19,16 @@
*
*/

+#ifdef HAVE_CONFIG_H
+# include "config.h"
+#endif
+
#include <unistd.h>
#include <string.h>
#include <errno.h>

#include "gobex.h"
+#include "glib-helper.h"

#define G_OBEX_DEFAULT_MTU 4096
#define G_OBEX_MINIMUM_MTU 255
diff --git a/tools/test-server.c b/tools/test-server.c
index 87742ec..6096737 100644
--- a/tools/test-server.c
+++ b/tools/test-server.c
@@ -19,6 +19,10 @@
*
*/

+#ifdef HAVE_CONFIG_H
+# include "config.h"
+#endif
+
#include <sys/types.h>
#include <sys/socket.h>
#include <fcntl.h>
--
1.7.1

2011-08-04 08:43:22

by Johan Hedberg

Subject: Re: [PATCH obexd] Fix compilation when NEED_G_SLIST_FREE_FULL is defined

Hi,

On Thu, Aug 04, 2011, Daniele Forsi wrote:
> To use the replacement for g_slist_free_full() both compat.h and
> glib-helper.h need to be included.
>
> Fixes:
> gobex/gobex.c:911: error: implicit declaration of function 'g_slist_free_full'
> tools/test-server.c:344: error: implicit declaration of function ‘g_slist_free_full’
> ---
> gobex/gobex.c | 5 +++++
> tools/test-server.c | 4 ++++
> 2 files changed, 9 insertions(+), 0 deletions(-)

Applied. Thanks.

Johan

2011-08-04 08:23:44

by Luiz Augusto von Dentz

Subject: Re: [PATCH obexd] Fix compilation when NEED_G_SLIST_FREE_FULL is defined

Hi Daniele,

On Thu, Aug 4, 2011 at 1:20 AM, Daniele Forsi <[email protected]> wrote:
> From: Daniele Forsi <[email protected]>
>
> To use the replacement for g_slist_free_full() both compat.h and
> glib-helper.h need to be included.
>
> Fixes:
> gobex/gobex.c:911: error: implicit declaration of function 'g_slist_free_full'
> tools/test-server.c:344: error: implicit declaration of function ?g_slist_free_full?
> ---
> ?gobex/gobex.c ? ? ? | ? ?5 +++++
> ?tools/test-server.c | ? ?4 ++++
> ?2 files changed, 9 insertions(+), 0 deletions(-)
>
> diff --git a/gobex/gobex.c b/gobex/gobex.c
> index 2a64849..ff35830 100644
> --- a/gobex/gobex.c
> +++ b/gobex/gobex.c
> @@ -19,11 +19,16 @@
> ?*
> ?*/
>
> +#ifdef HAVE_CONFIG_H
> +# include "config.h"
> +#endif
> +
> ?#include <unistd.h>
> ?#include <string.h>
> ?#include <errno.h>
>
> ?#include "gobex.h"
> +#include "glib-helper.h"
>
> ?#define G_OBEX_DEFAULT_MTU ? ? 4096
> ?#define G_OBEX_MINIMUM_MTU ? ? 255
> diff --git a/tools/test-server.c b/tools/test-server.c
> index 87742ec..6096737 100644
> --- a/tools/test-server.c
> +++ b/tools/test-server.c
> @@ -19,6 +19,10 @@
> ?*
> ?*/
>
> +#ifdef HAVE_CONFIG_H
> +# include "config.h"
> +#endif
> +
> ?#include <sys/types.h>
> ?#include <sys/socket.h>
> ?#include <fcntl.h>
> --
> 1.7.1
>
> --

Thank you for catching this.


--
Luiz Augusto von Dentz