2021-06-16 18:23:48

by Alain Michaud

[permalink] [raw]
Subject: [Bluez PATCH v2] monitor: Adding missing device found flag in the parser

A new flag was added to the kernel implementation of the Device Found
event, but had not been added to the parser leading to an "Unknown device
flag" error in btmon.

Reviewed-by: Yu Liu <[email protected]>

Signed-off-by: Alain Michaud <[email protected]>
---

Changes in v2:
- Addressing Marcel's feedback

monitor/packet.c | 7 ++++---
1 file changed, 4 insertions(+), 3 deletions(-)

diff --git a/monitor/packet.c b/monitor/packet.c
index 82513a63c..5a928c296 100644
--- a/monitor/packet.c
+++ b/monitor/packet.c
@@ -12030,9 +12030,10 @@ static void mgmt_print_io_capability(uint8_t capability)
}

static const struct bitfield_data mgmt_device_flags_table[] = {
- { 0, "Confirm Name" },
- { 1, "Legacy Pairing" },
- { 2, "Not Connectable" },
+ { 0, "Confirm Name" },
+ { 1, "Legacy Pairing" },
+ { 2, "Not Connectable" },
+ { 3, "Connection Locally Initiated" },
{ }
};

--
2.32.0.272.g935e593368-goog


2021-06-16 19:53:40

by bluez.test.bot

[permalink] [raw]
Subject: RE: [Bluez,v2] monitor: Adding missing device found flag in the parser

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=501559

---Test result---

Test Summary:
CheckPatch PASS 0.70 seconds
GitLint PASS 0.09 seconds
Prep - Setup ELL PASS 38.67 seconds
Build - Prep PASS 0.09 seconds
Build - Configure PASS 6.50 seconds
Build - Make PASS 161.00 seconds
Make Check PASS 8.75 seconds
Make Distcheck PASS 189.81 seconds
Build w/ext ELL - Configure PASS 6.51 seconds
Build w/ext ELL - Make PASS 150.88 seconds

Details
##############################
Test: CheckPatch - PASS
Desc: Run checkpatch.pl script with rule in .checkpatch.conf

##############################
Test: GitLint - PASS
Desc: Run gitlint with rule in .gitlint

##############################
Test: Prep - Setup ELL - PASS
Desc: Clone, build, and install ELL

##############################
Test: Build - Prep - PASS
Desc: Prepare environment for build

##############################
Test: Build - Configure - PASS
Desc: Configure the BlueZ source tree

##############################
Test: Build - Make - PASS
Desc: Build the BlueZ source tree

##############################
Test: Make Check - PASS
Desc: Run 'make check'

##############################
Test: Make Distcheck - PASS
Desc: Run distcheck to check the distribution

##############################
Test: Build w/ext ELL - Configure - PASS
Desc: Configure BlueZ source with '--enable-external-ell' configuration

##############################
Test: Build w/ext ELL - Make - PASS
Desc: Build BlueZ source with '--enable-external-ell' configuration



---
Regards,
Linux Bluetooth

2021-06-17 02:31:52

by Luiz Augusto von Dentz

[permalink] [raw]
Subject: Re: [Bluez,v2] monitor: Adding missing device found flag in the parser

Hi Alain,

On Wed, Jun 16, 2021 at 12:53 PM <[email protected]> wrote:
>
> This is automated email and please do not reply to this email!
>
> Dear submitter,
>
> Thank you for submitting the patches to the linux bluetooth mailing list.
> This is a CI test results with your patch series:
> PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=501559
>
> ---Test result---
>
> Test Summary:
> CheckPatch PASS 0.70 seconds
> GitLint PASS 0.09 seconds
> Prep - Setup ELL PASS 38.67 seconds
> Build - Prep PASS 0.09 seconds
> Build - Configure PASS 6.50 seconds
> Build - Make PASS 161.00 seconds
> Make Check PASS 8.75 seconds
> Make Distcheck PASS 189.81 seconds
> Build w/ext ELL - Configure PASS 6.51 seconds
> Build w/ext ELL - Make PASS 150.88 seconds
>
> Details
> ##############################
> Test: CheckPatch - PASS
> Desc: Run checkpatch.pl script with rule in .checkpatch.conf
>
> ##############################
> Test: GitLint - PASS
> Desc: Run gitlint with rule in .gitlint
>
> ##############################
> Test: Prep - Setup ELL - PASS
> Desc: Clone, build, and install ELL
>
> ##############################
> Test: Build - Prep - PASS
> Desc: Prepare environment for build
>
> ##############################
> Test: Build - Configure - PASS
> Desc: Configure the BlueZ source tree
>
> ##############################
> Test: Build - Make - PASS
> Desc: Build the BlueZ source tree
>
> ##############################
> Test: Make Check - PASS
> Desc: Run 'make check'
>
> ##############################
> Test: Make Distcheck - PASS
> Desc: Run distcheck to check the distribution
>
> ##############################
> Test: Build w/ext ELL - Configure - PASS
> Desc: Configure BlueZ source with '--enable-external-ell' configuration
>
> ##############################
> Test: Build w/ext ELL - Make - PASS
> Desc: Build BlueZ source with '--enable-external-ell' configuration
>
>
>
> ---
> Regards,
> Linux Bluetooth

Applied, thanks.

--
Luiz Augusto von Dentz