On Mon, Apr 24, 2023 at 03:35:40PM +0200, Johan Hovold wrote:
> These patches fixes a couple of issues with the two bdaddr quirks:
>
> The first one allows HCI_QUIRK_INVALID_BDADDR to be used with
> HCI_QUIRK_NON_PERSISTENT_SETUP.
>
> The second patch restores the original semantics of the
> HCI_QUIRK_USE_BDADDR_PROPERTY so that the controller is marked as
> unconfigured when no device address is specified in the devicetree (as
> the quirk is documented to work).
>
> This specifically makes sure that Qualcomm HCI controllers such as
> wcn6855 found on the Lenovo X13s are marked as unconfigured until user
> space has provided a valid address.
>
> Long term, the HCI_QUIRK_USE_BDADDR_PROPERTY should probably be dropped
> in favour of HCI_QUIRK_INVALID_BDADDR and always checking the devicetree
> property.
> Johan Hovold (2):
> Bluetooth: fix invalid-bdaddr quirk for non-persistent setup
> Bluetooth: fix use-bdaddr-property quirk
>
> net/bluetooth/hci_sync.c | 30 +++++++++++-------------------
> 1 file changed, 11 insertions(+), 19 deletions(-)
Any further comments to this series, or can this one be merged for 6.5
now?
Johan
Hi Johan,
On Tue, May 30, 2023 at 7:25 AM Johan Hovold <[email protected]> wrote:
>
> On Mon, Apr 24, 2023 at 03:35:40PM +0200, Johan Hovold wrote:
> > These patches fixes a couple of issues with the two bdaddr quirks:
> >
> > The first one allows HCI_QUIRK_INVALID_BDADDR to be used with
> > HCI_QUIRK_NON_PERSISTENT_SETUP.
> >
> > The second patch restores the original semantics of the
> > HCI_QUIRK_USE_BDADDR_PROPERTY so that the controller is marked as
> > unconfigured when no device address is specified in the devicetree (as
> > the quirk is documented to work).
> >
> > This specifically makes sure that Qualcomm HCI controllers such as
> > wcn6855 found on the Lenovo X13s are marked as unconfigured until user
> > space has provided a valid address.
> >
> > Long term, the HCI_QUIRK_USE_BDADDR_PROPERTY should probably be dropped
> > in favour of HCI_QUIRK_INVALID_BDADDR and always checking the devicetree
> > property.
>
> > Johan Hovold (2):
> > Bluetooth: fix invalid-bdaddr quirk for non-persistent setup
> > Bluetooth: fix use-bdaddr-property quirk
> >
> > net/bluetooth/hci_sync.c | 30 +++++++++++-------------------
> > 1 file changed, 11 insertions(+), 19 deletions(-)
>
> Any further comments to this series, or can this one be merged for 6.5
> now?
Looks like this was removed from Patchwork since it has passed 30 days
without updates, could you please resend it so CI can pick it up and
test it again.
> Johan
--
Luiz Augusto von Dentz
On Tue, May 30, 2023 at 01:06:01PM -0700, Luiz Augusto von Dentz wrote:
> On Tue, May 30, 2023 at 7:25 AM Johan Hovold <[email protected]> wrote:
> > On Mon, Apr 24, 2023 at 03:35:40PM +0200, Johan Hovold wrote:
> > > These patches fixes a couple of issues with the two bdaddr quirks:
> > Any further comments to this series, or can this one be merged for 6.5
> > now?
>
> Looks like this was removed from Patchwork since it has passed 30 days
> without updates, could you please resend it so CI can pick it up and
> test it again.
Both series resent:
https://lore.kernel.org/lkml/[email protected]/
https://lore.kernel.org/lkml/[email protected]/
Getting both of these, or at least the first one, into 6.4 would of
course be even better.
Thanks.
Johan