2014-12-05 12:48:27

by Andrei Emeltchenko

Subject: [PATCHv2] monitor: Fix RFCOMM parity type mask

From: Andrei Emeltchenko <[email protected]>

Fix RFCOMM RPN parity type bit according to Spec. GSM 07.10 version
6.3.0. (PT1 - PT2 indicates the parity type).
---
*v2: Fixed parity type bits

monitor/rfcomm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/monitor/rfcomm.c b/monitor/rfcomm.c
index fe3afb7..4ba61c8 100644
--- a/monitor/rfcomm.c
+++ b/monitor/rfcomm.c
@@ -67,7 +67,7 @@ static char *cr_str[] = {
#define GET_RPN_DB(parity) (parity & 0x03)
#define GET_RPN_SB(parity) ((parity & 0x04) >> 2)
#define GET_RPN_PARITY(parity) ((parity & 0x08) >> 3)
-#define GET_RPN_PTYPE(parity) ((parity & 0x03) >> 3)
+#define GET_RPN_PTYPE(parity) ((parity & 0x30) >> 4)
#define GET_RPN_XIN(io) (io & 0x01)
#define GET_RPN_XOUT(io) ((io & 0x02) >> 1)
#define GET_RPN_RTRI(io) ((io & 0x04) >> 2)
--
1.9.1

2014-12-05 15:03:27

by Luiz Augusto von Dentz

Subject: Re: [PATCHv2] monitor: Fix RFCOMM parity type mask

Hi Andrei,

On Fri, Dec 5, 2014 at 2:48 PM, Andrei Emeltchenko
<[email protected]> wrote:
> From: Andrei Emeltchenko <[email protected]>
>
> Fix RFCOMM RPN parity type bit according to Spec. GSM 07.10 version
> 6.3.0. (PT1 - PT2 indicates the parity type).
> ---
> *v2: Fixed parity type bits
>
> monitor/rfcomm.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/monitor/rfcomm.c b/monitor/rfcomm.c
> index fe3afb7..4ba61c8 100644
> --- a/monitor/rfcomm.c
> +++ b/monitor/rfcomm.c
> @@ -67,7 +67,7 @@ static char *cr_str[] = {
> #define GET_RPN_DB(parity) (parity & 0x03)
> #define GET_RPN_SB(parity) ((parity & 0x04) >> 2)
> #define GET_RPN_PARITY(parity) ((parity & 0x08) >> 3)
> -#define GET_RPN_PTYPE(parity) ((parity & 0x03) >> 3)
> +#define GET_RPN_PTYPE(parity) ((parity & 0x30) >> 4)
> #define GET_RPN_XIN(io) (io & 0x01)
> #define GET_RPN_XOUT(io) ((io & 0x02) >> 1)
> #define GET_RPN_RTRI(io) ((io & 0x04) >> 2)
> --
> 1.9.1

Pushed, thanks.


--
Luiz Augusto von Dentz