2014-09-22 07:12:08

by Gowtham Anandha Babu

Subject: [PATCH v3] obexd/src/manager: Fix the double check for agent

Removes the check for NULL agent.
---
agent_free() function contains the NULL check already.
---
obexd/src/manager.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/obexd/src/manager.c b/obexd/src/manager.c
index 326e56f..97ae278 100644
--- a/obexd/src/manager.c
+++ b/obexd/src/manager.c
@@ -521,8 +521,7 @@ void manager_cleanup(void)

/* FIXME: Release agent? */

- if (agent)
- agent_free(agent);
+ agent_free(agent);

g_dbus_detach_object_manager(connection);

--
1.9.1

2014-09-22 16:08:27

by Luiz Augusto von Dentz

Subject: Re: [PATCH v3] obexd/src/manager: Fix the double check for agent

Hi,

On Mon, Sep 22, 2014 at 10:12 AM, Gowtham Anandha Babu
<[email protected]> wrote:
> Removes the check for NULL agent.
> ---
> agent_free() function contains the NULL check already.
> ---
> obexd/src/manager.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/obexd/src/manager.c b/obexd/src/manager.c
> index 326e56f..97ae278 100644
> --- a/obexd/src/manager.c
> +++ b/obexd/src/manager.c
> @@ -521,8 +521,7 @@ void manager_cleanup(void)
>
> /* FIXME: Release agent? */
>
> - if (agent)
> - agent_free(agent);
> + agent_free(agent);
>
> g_dbus_detach_object_manager(connection);
>
> --
> 1.9.1

Pushed, thanks.


--
Luiz Augusto von Dentz