2021-05-21 20:23:37

by Tedd Ho-Jeong An

Subject: [BlueZ PATCH] src/main: Fix double free str

From: Tedd Ho-Jeong An <[email protected]>

This patch fixes the double free the string.
The string variable is always freed within its if statement so no need
to free it again in the end.
---
src/main.c | 1 -
1 file changed, 1 deletion(-)

diff --git a/src/main.c b/src/main.c
index ed19e3e28..57db9c134 100644
--- a/src/main.c
+++ b/src/main.c
@@ -804,7 +804,6 @@ static void parse_config(GKeyFile *config)

parse_br_config(config);
parse_le_config(config);
- g_free(str);
}

static void init_defaults(void)
--
2.26.3

2021-05-21 20:27:00

by bluez.test.bot

Subject: RE: [BlueZ] src/main: Fix double free str

This is automated email and please do not reply to this email!

Dear submitter,

Thank you for submitting the patches to the linux bluetooth mailing list.
This is a CI test results with your patch series:
PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=486651

---Test result---

Test Summary:
CheckPatch PASS 0.40 seconds
GitLint PASS 0.12 seconds
Prep - Setup ELL PASS 40.84 seconds
Build - Prep PASS 0.09 seconds
Build - Configure PASS 7.15 seconds
Build - Make PASS 170.35 seconds
Make Check PASS 8.91 seconds
Make Distcheck PASS 205.87 seconds
Build w/ext ELL - Configure PASS 7.05 seconds
Build w/ext ELL - Make PASS 159.02 seconds

Details
##############################
Test: CheckPatch - PASS
Desc: Run checkpatch.pl script with rule in .checkpatch.conf

##############################
Test: GitLint - PASS
Desc: Run gitlint with rule in .gitlint

##############################
Test: Prep - Setup ELL - PASS
Desc: Clone, build, and install ELL

##############################
Test: Build - Prep - PASS
Desc: Prepare environment for build

##############################
Test: Build - Configure - PASS
Desc: Configure the BlueZ source tree

##############################
Test: Build - Make - PASS
Desc: Build the BlueZ source tree

##############################
Test: Make Check - PASS
Desc: Run 'make check'

##############################
Test: Make Distcheck - PASS
Desc: Run distcheck to check the distribution

##############################
Test: Build w/ext ELL - Configure - PASS
Desc: Configure BlueZ source with '--enable-external-ell' configuration

##############################
Test: Build w/ext ELL - Make - PASS
Desc: Build BlueZ source with '--enable-external-ell' configuration



---
Regards,
Linux Bluetooth

2021-05-21 23:55:55

by Luiz Augusto von Dentz

Subject: Re: [BlueZ] src/main: Fix double free str

Hi Tedd,

On Fri, May 21, 2021 at 1:27 PM <[email protected]> wrote:
>
> This is automated email and please do not reply to this email!
>
> Dear submitter,
>
> Thank you for submitting the patches to the linux bluetooth mailing list.
> This is a CI test results with your patch series:
> PW Link:https://patchwork.kernel.org/project/bluetooth/list/?series=486651
>
> ---Test result---
>
> Test Summary:
> CheckPatch PASS 0.40 seconds
> GitLint PASS 0.12 seconds
> Prep - Setup ELL PASS 40.84 seconds
> Build - Prep PASS 0.09 seconds
> Build - Configure PASS 7.15 seconds
> Build - Make PASS 170.35 seconds
> Make Check PASS 8.91 seconds
> Make Distcheck PASS 205.87 seconds
> Build w/ext ELL - Configure PASS 7.05 seconds
> Build w/ext ELL - Make PASS 159.02 seconds
>
> Details
> ##############################
> Test: CheckPatch - PASS
> Desc: Run checkpatch.pl script with rule in .checkpatch.conf
>
> ##############################
> Test: GitLint - PASS
> Desc: Run gitlint with rule in .gitlint
>
> ##############################
> Test: Prep - Setup ELL - PASS
> Desc: Clone, build, and install ELL
>
> ##############################
> Test: Build - Prep - PASS
> Desc: Prepare environment for build
>
> ##############################
> Test: Build - Configure - PASS
> Desc: Configure the BlueZ source tree
>
> ##############################
> Test: Build - Make - PASS
> Desc: Build the BlueZ source tree
>
> ##############################
> Test: Make Check - PASS
> Desc: Run 'make check'
>
> ##############################
> Test: Make Distcheck - PASS
> Desc: Run distcheck to check the distribution
>
> ##############################
> Test: Build w/ext ELL - Configure - PASS
> Desc: Configure BlueZ source with '--enable-external-ell' configuration
>
> ##############################
> Test: Build w/ext ELL - Make - PASS
> Desc: Build BlueZ source with '--enable-external-ell' configuration
>
>
>
> ---
> Regards,
> Linux Bluetooth

Applied, thanks.

--
Luiz Augusto von Dentz